Contribute to Open Source. Search issue labels to find the right project for you!

Add Jenkins pipeline

cyberark/slosilo

Adds a test.sh script which should work generically anywhere docker is available. JUnit reports get generated in specs/reports.

Then adds a trivial, Conjur-internal-Jenkins-specific Jenkinsfile on top of that.

Example: screenshot-2017-10-17 jenkins cyberark--slosilo feature pipeline 5 (https://jenkins.conjur.net/blue/organizations/jenkins/cyberark–slosilo/detail/feature%2Fpipeline/5/pipeline)

(Also fixed some small, unrelated issues I uncovered while working on that, so please DO NOT squash merge.)

Updated 17/10/2017 09:15 1 Comments

[6.3] Restore activation key and content hosts subscriptions

SatelliteQE/robottelo

cover: https://bugzilla.redhat.com/show_bug.cgi?id=1296978 ```console (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ pytest -v tests/foreman/cli/test_subscription.py::SubscriptionTestCase::test_positive_restore_ak_and_content_hosts_subscriptions ================================================= test session starts ================================================== platform linux2 – Python 2.7.13, pytest-3.1.3, py-1.4.34, pluggy-0.4.0 – /home/dlezz/.pyenv/versions/sat-6.3.0/bin/python2.7 cachedir: .cache rootdir: /home/dlezz/projects/robottelo-fork, inifile: plugins: xdist-1.20.0, services-1.2.1, mock-1.6.2, forked-0.2, cov-2.5.1 collected 1 item 2017-10-17 10:51:47 - conftest - DEBUG - Deselect of WONTFIX BZs is disabled in settings

tests/foreman/cli/test_subscription.py::SubscriptionTestCase::test_positive_restore_ak_and_content_hosts_subscriptions PASSED

============================================== 1 passed in 656.55 seconds ============================================== ```

Updated 17/10/2017 09:13 1 Comments

Rewords a few sections of the readme

cyberark/conjur

What does this pull request do?

Rewords a few sections of the readme that I found awkward.

What background context can you provide?

I read this readme pretty often, and wrote much of it the first place. It’s hard for me to edit my own work because I get so steeped in it. But reading it again with fresh eyes motivated me to want to do some rewriting.

Where should the reviewer start?

README.md

Updated 17/10/2017 01:50

Reimplemented fragments to be more lightweight

couchbase/couchbase-lite-ios

(This is not dependent on the PR I submitted last week.)

  • Parent returns nil if it knows the fragment doesn’t exist
  • Fragments are always initialized with parent and key/index; the value is derived lazily
  • Numeric and boolean accessors don’t create any intermediate NSObjects
  • Chained subscripts reuse the same fragment object
  • Removed expensive -conformsToProtocol: checks in setter
  • All of CBLFragment turned out to be unnecessary except the setter
  • Fixed a bug where booleanValue returned NO for non-numeric values
Updated 17/10/2017 00:47

update meta_tags with facebook recommendations

AfroPython/afropython-site

Qual é o propósito deste Pull Request? Atualização de algumas meta_tags conforme depurador do facebook

depfb

O que foi feito para alcançar esse propósito? Atualizei as tags: - og:image - og:type - e o valor absoluto para og:ur

Como testar se isso realmente funciona? Somente após fazer o deploy para confirmar

Quem pode ajudar a revisar este PR? @anaschwendler @lipemorais

Updated 16/10/2017 22:32

[Website] Component status page design tweaks

mineral-ui/mineral-ui

Description

  • add hierarchy to pages array (and thus the navigation)
  • cleanup design on Component Status page
  • move some keys around to fix another markdown error

Motivation and context

The Component Status page isn’t really a Guideline page, and making the Components header a link isn’t super discoverable. This PR adds a couple top-level nav headers to organize things a bit more.

Also some design tweaks so the table (with its icon-only column) doesn’t look insane on larger monitors. Deprecate margin-top in favor of better css.

https://status-page-tweaks–mineral-ui.netlify.com/

How to test

  1. cd mineral-ui && npm start
  2. Navigate to /component-status
  3. Check everything out. The table should feel a bit tighter.

Types of changes

  • design cleanup

Checklist

<!– Put an x in all the boxes that apply and are complete. If an item does not apply, put an x in it anyway and add “[n/a]” to the end of the line. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help! –> * [x] Renders and functions properly in all supported browsers * [x] Automated tests written and passing [n/a] * [x] Accessibility and inclusivity considered * [x] Rendering performance (initial load time & 60fps) and perceived performance considered [n/a] * [x] Documentation created or updated * [x] Tested in sandbox if new component or breaking change [n/a]

<!– If any of the above need further details, you should include those here. –>

How does this PR make you feel?

graphic design

Updated 16/10/2017 20:41

Truthy and falsy - Result of value type(string) is wrong

loiane/javascript-datastructures-algorithms

On topic ‘Truthy and falsy’ chapter 1, both editions;

The description of value type(string) which you can see on example:

The result is false if the string is empty (length is 0); otherwise, the result is true (length > 1).

Can be verify on output as true when val.length is 1. Using the same function example, below the table of truthy and falsy, we can see:

function testTruthy(val){
    return val ? console.log('truthy') : console.log('falsy');
}

testTruthy('a');  //true
Updated 16/10/2017 19:34 1 Comments

Enterprise cta

cyberark/conjur

Closes GH Issue 437

What does this pull request do?

  • more prominent Enterprise CTA
  • more primary Hero CTAs (Install & Try Conjur)
  • more prominent secondary CTAs (Webinars)
  • adds Puppet integration graphic to Puppet page
  • tweaks to typography for better consistency
  • moves “How Conjur Works” page onto homepage (This was the only page linked under Welcome)
  • adds link to Enterprise documentation in top-nav
  • redrawn feature icons for bolder, more consistent design

What background context can you provide?

Where should the reviewer start?

homepage

How should this be manually tested?

  • confirm that CTA links are linking to appropriate pages

Screenshots (if appropriate)

conjur_org_home_designupdate conjur_puppet_screenshot

Link to build in Jenkins (if appropriate)

https://jenkins.conjur.net/job/cyberark–conjur/job/enterprise-cta/

Questions:

Does this have automated Cucumber tests? no

Can we make a blog post, video, or animated GIF out of this? no

Is this explained in documentation? no

Does the knowledge base need an update? no

Updated 16/10/2017 22:03

[REVIEW]: pyGPGO: Bayesian Optimization for Python

openjournals/joss-reviews

Submitting author: @hawk31 (<a href=“http://orcid.org/0000-0002-5335-7834”>Jiménez J.</a>) Repository: <a href=“https://github.com/hawk31/pyGPGO” target =“_blank”>https://github.com/hawk31/pyGPGO</a> Version: 0.3.0.dev1 Editor: @arfon Reviewer: @dfm Archive: Pending

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/7d60820fabf7fa81501e3d638cac522d"><img src="http://joss.theoj.org/papers/7d60820fabf7fa81501e3d638cac522d/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/7d60820fabf7fa81501e3d638cac522d/status.svg)](http://joss.theoj.org/papers/7d60820fabf7fa81501e3d638cac522d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=“https://github.com/hawk31/pyGPGO” target=“_blank”>target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

@dfm, please carry out your review in this issue by updating the checklist below (please make sure you’re logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the <a target=“_blank” href=“https://github.com/hawk31/pyGPGO”>repository url</a>?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (0.3.0.dev1)?
  • [x] Authorship: Has the submitting author (@hawk31) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [ ] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [ ] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
Updated 16/10/2017 21:07 3 Comments

[Accessibility] Improve filter bar accessibility

elastic/kibana

This PR improves the accessibility of the filter bar, by implementing the following two changes:

  • Make each filter tabable, so the focus won’t directly jump to the first action button of each filter when navigating by keyboard, but have the focus on the actual filter (and its text beforehand).
  • Adding aria-disabled to indicate the present the disabled state of a filter to a screen reader.
  • Prefix the filter with “NOT” when it’s a negated filter, to not rely on color solely, fix #14456
Updated 16/10/2017 18:23 3 Comments

[Popover] Popover portals

mineral-ui/mineral-ui

Description

  • Add usePortal prop to Popover and Dropdown - allows rendering of content to body instead of as sibling to trigger
  • Improves Popover and Dropdown a11y
  • Extract reusable Portal component
  • Extract reusable EventListener component

Note: This PR is awaiting https://github.com/FezVrasta/popper.js/pull/454 to hopefully be merged and published prior to the Portal examples behaving as desired. Currently, the content remains visible when the trigger scrolled out of view in the scrollParent. Once merged, the content will be hidden when the trigger is scrolled out of view.

Motivation and context

Using a portal will allow Popovers, Dropdowns, Tooltips, etc to visually “break out” of bounding containers that have overflow: hidden styles applied. It is needed particularly in the case where the component lives inside of a scrollable container.

closes #395

Screenshots, videos, or demo, if appropriate

https://395-popover-portal–mineral-ui.netlify.com/

How to test

  1. Visit demo - Popover and Dropdown components
  2. Note the behavior of the Portal examples
  3. Try Dropdown in VoiceOver

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

<!– Put an x in all the boxes that apply and are complete. If an item does not apply, put an x in it anyway and add “ - [n/a]” to the end of the line. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help! –> * [x] Renders and functions properly in all supported browsers * [x] Automated tests written and passing * [x] Accessibility and inclusivity considered * [x] Rendering performance (initial load time & 60fps) and perceived performance considered * [x] Documentation created or updated * [x] Tested in sandbox if new component or breaking change - [n/a]

Updated 16/10/2017 17:02 2 Comments

Send all imporovements

dagcoin/dagcoin

closes #311 * added notification popup that transaction fee will be automatically excluded from all stable amount user holds * Made amount changeable after send all

Updated 17/10/2017 08:51

revisit the jest import error and our workaround

CraveFood/farmblocks

Currently we are using an ugly workaround to avoid the jest / babel bug that causes jest to not transpile es modules imports.

The workaround is to re-add jest as a dev dependency after installing everything, see: https://github.com/CraveFood/farmblocks/blob/2496b87128fc0c0cfa01f60c5208da3e23911adc/.travis.yml#L25

But after updating yarn to 1.2.1 that workaround will no longer work. So we need a permanent fix.

Some (old?) references / hints:

  • https://github.com/storybooks/storybook/issues/910
  • https://github.com/storybooks/storybook/issues/880
  • https://github.com/facebook/jest/issues/1468#issuecomment-276753756
Updated 16/10/2017 18:42 1 Comments

Fixed preservation of timezone in handling of datetimes

ActivityWatch/aw-webui

I think this fixes the following issue: https://github.com/ActivityWatch/activitywatch/issues/117

The reason is that new Date().toISOString() returns a datetime normalized to UTC with the ‘Z’ suffix. When this is later used to construct moment objects the timezone information is lost. moment().format() preserves the timezone information in the string using the +HH:MM suffix.

Updated 16/10/2017 12:23

[REVIEW]: micompm - A MATLAB/Octave toolbox for multivariate independent comparison of observations

openjournals/joss-reviews

Submitting author: @fakenmc (<a href=“http://orcid.org/0000-0002-8487-5837”>Nuno Fachada</a>) Repository: <a href=“https://github.com/fakenmc/micompm” target =“_blank”>https://github.com/fakenmc/micompm</a> Version: v1.0.0 Editor: @cMadan Reviewer: @jordigh Archive: Pending

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/6901c663f02916e5a80dad9a8bbda537"><img src="http://joss.theoj.org/papers/6901c663f02916e5a80dad9a8bbda537/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/6901c663f02916e5a80dad9a8bbda537/status.svg)](http://joss.theoj.org/papers/6901c663f02916e5a80dad9a8bbda537)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=“https://github.com/fakenmc/micompm” target=“_blank”>target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

@jordigh, please carry out your review in this issue by updating the checklist below (please make sure you’re logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @cMadan know.

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the <a target=“_blank” href=“https://github.com/fakenmc/micompm”>repository url</a>?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (v1.0.0)?
  • [x] Authorship: Has the submitting author (@fakenmc) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [ ] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [ ] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
Updated 17/10/2017 02:18 1 Comments

Add maven dependency, remove library code from repository

yugandhargangu/JspMyAdmin2

Hi, I saw your repository. There are several library code in the repository. So, I removed codes derived from libraries, then added maven dependency.

I added following libraries: + org.json:json:20170516 + commons-codec:commons-codec:1.10

Please check it.

<!– Reviewable:start –>

This change is <img src=“https://reviewable.io/review_button.svg” height=“34” align=“absmiddle” alt=“Reviewable”/> <!– Reviewable:end –>

Updated 17/10/2017 01:41 2 Comments

closes #56

gabriela229/grace-shopper

As I mentioned in slack, I was considering that 1.) we might want to be able to get reviews by userId and/or productId, and 2.) it might be better to fetch the reviews rather than to include them (as well as users) in a nested get route for products.

I commented out some basic code that might serve as the basis for that approach, but for now the SingleProduct component loads reviews with basic styling, and shows “No reviews yet!” if there are no reviews. Reviews are fetched in Main.

Store and routes are based on similar code that we have so far.

Updated 17/10/2017 02:39

Added Delete Index support to high-level REST client

elastic/elasticsearch

Added high-level REST client support for one of the endpoints covered by https://github.com/elastic/elasticsearch/issues/25847. Will try and add some more, if this one’s fine. 🙂

(Haven’t been able to get gradle check to run through yet - due to error: ``` :docs:integTestCluster#installAnalysisIcuPlugin FAILED

FAILURE: Build failed with an exception.

  • What went wrong: Execution failed for task ‘:docs:integTestCluster#installAnalysisIcuPlugin’.

    A problem occurred starting process ‘command 'cmd’‘ ``` but ES builds fine, and the newly added tests pass.)

Updated 16/10/2017 13:22 4 Comments

- Modified link.py to allow a special host name of "default" to apply to

arcticicestudio/snowsaw

machines that do not have a specific entry.

  • Rewrote for loop that processes hosts to immediately exit if the host name is matched

  • Modified host matching so that if the hostname is not matched, and a default is not set, it will immediately return to the caller

These changes allow for the following scenarios: 1) Apply the link to all hosts (no hosts specified) 2) Apply link to ONLY specific hosts (hosts specified with no default) 3) Apply host-specific links, or a default for non-matched hostnames (hosts and default specified)

Updated 16/10/2017 03:50

Delete two unnecessary queries

copona/copona

The delete query in addGeoZone is unnecessary because the related record won’t exist - the zone_id it’s was just generated in the preceding query.

In editGeoZone - there is already a DELETE query preceding the foreach loop which would have deleted anything that the more specific DELETE in the loop would have found.

Both unnecessary.

Updated 16/10/2017 22:53 2 Comments

Remmina only shows black screen without any text after connection to an SSH server

FreeRDP/Remmina

If I connect to an SSH server, I only get a black screen without any text in Remmina. This seems to be a regression in the latest release, it worked on older 1.2.0 releases. This is what I can see on the console:

StatusNotifier/Appindicator support: your desktop does support it and libappindicator is compiled in remmina. Good!

(remmina:20712): Gtk-WARNING **: Theme parsing error: gtk.css:101:18: Not using units is deprecated. Assuming 'px'.

(remmina:20712): Gtk-WARNING **: Theme parsing error: gtk.css:101:20: Not using units is deprecated. Assuming 'px'.

(remmina:20712): Gtk-WARNING **: /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkcontainer.c:1166: child property `position' of container class `GtkHeaderBar' is not writable

(remmina:20712): Gtk-WARNING **: gtk_menu_attach_to_widget(): menu already attached to GtkMenuItem
  • Client (OS name and version): Kubuntu 14.04.5
  • Remmina version (remmina –version): 1.2.0-rcgit-21-0~remmina201710082254.rc3f630d.de61f735~ubuntu14.04.1
  • Desktop environment (GNOME, Unity, KDE, ..): KDE
  • Connecting to (OS and version): Ubuntu 16.04, Debian 7/8/9
  • Connecting via (RDP, VNC, …): SSH
Updated 15/10/2017 21:08 3 Comments

Stop invoking non-existant syscall

elastic/elasticsearch

Today when getting ready to enter seccomp, we do some probes to ensure that we are really talking to seccomp, etc. One of these probes is pure paranoia. The paranoia was driven by a kernel bug (https://lkml.org/lkml/2014/7/20/222) that only impacted 32-bit x86 kernels wherein invoking a non-existant syscall was not returning ENOSYS (as it should). This probe causes problems though, for example in containers with syscall filters, invoking a non-existant syscall will lead to the process being sent SIGSYS and terminated. We do not need this paranoid, we do not support 32-bit, and our other probes give us enough of a defense to ensure that we are talking to seccomp (and we hardcode the seccomp syscall number for platforms that we support). Given that this probe offers us little value, but does cause problems in valid use-cases, this commit removes this paranoia.

Closes #20179

Updated 17/10/2017 09:30

Streaming inmem2tsi conversion.

influxdata/influxdb

Overview

Changes the influx_inspect inmem2tsi tool to stream each TSM/WAL file and convert to a TSI index instead of loading the entire shard’s in-memory index first.

Required for all non-trivial PRs
  • [x] Rebased/mergable
  • [x] Tests pass
  • [ ] CHANGELOG.md updated
  • [ ] Update man page when modifying a command
  • [ ] InfluxData Documentation: issue filed or pull request submitted \<link to issue or pull request>
Updated 16/10/2017 15:49

22 change json timestamp format

hashmapinc/nifi-opcua-bundle

Support phoenix timestamp format yyyy-MM-dd HH:mm:ss in both CSV and JSON timestamps

Verify the GetOPCData processor returns the timestamp format yyyy-MM-dd HH:mm:ss for all DataFormat options (CSV, JSON) and Return Timestamp options (Server, Source) when Use Long Timestamp = false.

{ “values” : [ { “q” : 0, “id” : “SimulationExamples.Functions.Ramp1”, “vs” : “35”, “ts” : “2017-10-13 17:11:53” }, { “q” : 0, “id” : “SimulationExamples.Functions.Ramp2”, “vs” : “150.75”, “ts” : “2017-10-13 17:11:53” }…

ns=2;s=SimulationExamples.Functions.Ramp1,2017-10-13 17:11:53,35,0 ns=2;s=SimulationExamples.Functions.Ramp2,2017-10-13 17:11:53,150.75,0 …

Updated 16/10/2017 16:28

Base styling

Benja-Ross/EventSwipeDashboard

Migrations

NO

Description

Adds base styling

Does this close any currently open issues?

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Styling
Updated 13/10/2017 17:30

Fork me on GitHub