Contribute to Open Source. Search issue labels to find the right project for you!

script/test: run 'go tool vet' during testing

git-lfs/git-lfs

This pull request fixes go tool vet violations found in Git LFS, and runs go tool vet on the same list of packages being tested by any invocation of script/test.

@technoweenie’s comment in https://github.com/git-lfs/git-lfs/issues/2743#issuecomment-346107557 got me thinking:

[ … ]

In fact, what do you think of adding go vet to script/test? I doubt it passes now, but I’d like to start nudging lfs towards a standard go codebase.

I think that this is a good idea. go tool vet provides useful insight on code correctness, not style as opposed to golint. I think that correctness of this sort is useful information to know about while testing, so let’s do both at the same time.

In doing so, this pull request comes in two parts:

  1. https://github.com/git-lfs/git-lfs/compare/7e4013d%5E1…a393bb1: fix current correctness violations found by go tool vet.
  2. 49de92b: refactor script/test to:
  3. Accept relative package names or subdirectories (git, ./git respectively) as arguments.
  4. Correctly run go tool vet over the same set of packages.

I think as a future point of discussion, adding golint (source) would be fruitful (as perhaps a part of script/lint, not script/test), but I believe that this discussion is out of the current scope.

/cc @git-lfs/core

Updated 15/12/2017 02:13

[REVIEW]: Gophernotes: the Go kernel for Jupyter and nteract

openjournals/joss-reviews

Submitting author: @dwhitena (<a href=“http://orcid.org/0000-0003-1155-8889”>Daniel Whitenack</a>) Repository: <a href=“https://github.com/gopherdata/gophernotes” target =“_blank”>https://github.com/gopherdata/gophernotes</a> Version: v1.0.0-RC Editor: @arokem Reviewer: @vsivsi Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b0034f120957e93c9f645cd04a8c4d1a"><img src="https://joss.theoj.org/papers/b0034f120957e93c9f645cd04a8c4d1a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b0034f120957e93c9f645cd04a8c4d1a/status.svg)](https://joss.theoj.org/papers/b0034f120957e93c9f645cd04a8c4d1a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=“https://github.com/gopherdata/gophernotes” target=“_blank”>target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@vsivsi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please: 1. Make sure you’re logged in to your GitHub account 2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.

Conflict of interest

Code of Conduct

General checks

  • [ ] Repository: Is the source code for this software available at the <a target=“_blank” href=“https://github.com/gopherdata/gophernotes”>repository url</a>?
  • [ ] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [ ] Version: Does the release version given match the GitHub release (v1.0.0-RC)?
  • [ ] Authorship: Has the submitting author (@dwhitena) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [ ] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [ ] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
Updated 15/12/2017 02:16 4 Comments

Fix sass build

IFRCGo/go-frontend

Sass was complaining about $cycle: none on a production build. Setting 0 instead of none worked. Dunno what this does so @ascalamogna or @danielfdsilva could you weigh in?

Updated 15/12/2017 00:36

[Card] Add CardActions, CardFooter; update styles

mineral-ui/mineral-ui

<!– NOTE: We’re just getting started. While we appreciate any feedback, we’re not yet ready to accept public contributions.

Thank you for your contribution! Here’s a template to help you format your PR.

Your title should look like: [ComponentName] Clear, brief title using imperative tense For example: [Button] Add support for type=submit

For a PR to be considered, each item in the checklist must be checked. –>

Description

<!– Describe your changes in detail –>

  • Add CardActions
  • Add CardFooter
  • Add actions, avatar, and variant to CardTitle
  • Add icons used within Card components
  • Various style updates to all Card components
  • Remove/update component theme variables
  • Add/update global theme variables
  • Update website demos and content
  • Update snapshots
  • Remove no-longer-needed customization in Popover
  • Fix small layout bug in website’s Page (necessary to allow clearing of floats inside examples)

Motivation and context

<!– Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here and auto-close them via commit messages: https://help.github.com/articles/closing-issues-via-commit-messages. –> Closes #470

Screenshots, videos, or demo, if appropriate

<!– To record and share a video: http://recordit.co/ –>

https://470-card-updates–mineral-ui.netlify.com/components/card

How to test

<!– Please describe the steps for reviewers to take to cover all facets of this feature. –>

  1. cd mineral-ui && npm start
  2. Navigate to Card (and CardActions, CardBlock, CardFooter, etc…)
  3. Confirm all necessary functionality
  4. Check all demo content for clarity, consistency, and errors

Types of changes

<!– What types of changes does your code introduce? Remove the lines below that are NOT applicable. Note: Whatever you choose here should match your commit messages. –> - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to change)

Breaking:

  • Card: CardRow_margin & CardRow_padding theme variables changed to CardRow_marginVertical & CardRow_paddingHorizontal, respectively
  • CardTitle: Removed minor prop and all associated theme variables; significant change to usage of meta prop; removed CardTitle_marginTop theme variable

Checklist

<!– Put an x in all the boxes that apply and are complete. If an item does not apply, put an x in it anyway and add “[n/a]” to the end of the line. If you’re unsure about any of these, don’t hesitate to ask. We’re here to help! –> * [ ] Renders and functions properly in all supported browsers * [x] Automated tests written and passing * [x] Accessibility and inclusivity considered * [x] Rendering performance (initial load time & 60fps) and perceived performance considered * [x] Documentation created or updated * [ ] Tested in sandbox if new component or breaking change

<!– If any of the above need further details, you should include those here. –>

How does this PR make you feel?

<!– 1. Find a gif: http://giphy.com/categories/ 2. Click ‘Copy link’ 3. Copy the ‘GIF Link’, paste it in place of the URL below, and update the alt text –> Card haircut

Updated 15/12/2017 00:24

TemplateUpgradeService rechecks for updates after in progress updates finish

elastic/elasticsearch

There is a rare scenario where the TemplateUpgradeService fails to perform an update for an extended period of time. This happens when the service starts an upgrade and a template that was up to date is deleted or otherwise modified during the upgrade. The upgrader will eventually catch this but it is dependent on a cluster state update, which can take time. This is problematic if waiting on a template (update) to be present.

The change in this commit adds a check at the end of the current execution so that this scenario can be avoided.

Updated 14/12/2017 21:48

1.1.6-rc

veg/hyphy-vision

I’d like to release HyPhy 2.3.8 to datamonkey before the holidays. We should bring in hyphy-vision’s latest changes as well.

Updated 14/12/2017 21:14

Remove source and model directory code

osate/osate2-core

The code related to managing a source directory and a model directory in each project should be removed. This is left over from before we moved to Xtext when we used to keep separately aadl and aaxl files. This issue came up in the context of this pull request: https://github.com/osate/osate2-core/pull/973#event-1388092467

Updated 14/12/2017 22:08

few enhancements to default sidebar editor

elastic/kibana

Adds a few enhancements to the default sidebar editor: - the options tab title will not be displayed if there is no data tab present and we only have a single option tab - its now possible to resize the sidebar editor - auto apply button was added and can be enabled with editorConfig.enableAutoApply on per visualization basis

todo: - [ ] check if this is functionally OK - [ ] improve code quality - [ ] add unit tests - [ ] add selenium tests

Updated 14/12/2017 19:54

Add code to read discovered attributes

mozilla-iot/gateway

This PR adds the following features:

1 - A timeout mechanism. If a response isn’t received from a ZigBee command, then the command will be reissued a few times before failing. 2 - If enabled, when doing a discover attributes, all of the attributes will also be read, and the value will be printed alongside the attribute information. This is especially useful when adding support (i.e. new classifiers) for new device types. 3 - Adds some support for printing out the internal zigbee command queue (typically only used for debugging).

Updated 14/12/2017 21:20 1 Comments

feat(rest): Single-server RestApplication

strongloop/loopback-next

Description

This implementation simplifies the use-case for anyone that wants to create a single-server REST application without needing to handle RestComponent.

Related issues

connected to https://github.com/strongloop/loopback-next/pull/770 (see https://github.com/strongloop/loopback-next/pull/770#issuecomment-350200436) for details

Checklist

  • [x] New tests added or existing tests modified to cover all changes
  • [x] Code conforms with the style guide
Updated 14/12/2017 22:15 2 Comments

Use lastSyncedGlobalCheckpoint in deletion policy

elastic/elasticsearch

Today we use the in-memory global checkpoint from SequenceNumbersService to clean up unneeded commit points, however the latest global checkpoint may haven’t fsynced to the disk yet. If the translog checkpoint fsync failed and we already use a higher global checkpoint to clean up commit points, then we may have removed a safe commit which we try to keep for recovery.

This commit updates the deletion policy using lastSyncedGlobalCheckpoint from Translog rather the in memory global checkpoint.

Relates #27606

Updated 14/12/2017 23:02

Fixes #2951: 404 Returned when deleting guest user.

couchbase/sync_gateway

DELETE /{db}/_user/GUEST now returns an error explaining that you should disable the guest account, not delete it.

Integration Tests

http://uberjenkins.sc.couchbase.com/view/Build/job/sync-gateway-integration-master/254/ http://uberjenkins.sc.couchbase.com/view/Build/job/sync-gateway-integration-master/255/

Updated 14/12/2017 18:13

Fixed #2221: double attribution in print preview for leaflet

geosolutions-it/MapStore2

Description

See title

Issues

  • See title Please check if the PR fulfills these requirements
  • [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with “x”, remove the others)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other… Please describe:

What is the current behavior? (You can also link to an open issue here) double attribution in print preview for leaflet

What is the new behavior? single attribution in print preview for leaflet

Does this PR introduce a breaking change? (check one with “x”, remove the other)

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: …

Other information:

Updated 14/12/2017 16:25 1 Comments

v1 of JVS reporting journey map

18F/federal-grant-reporting

[time blocked, one co-working session on 12/14]

Taking research from phase 1 and quickly putting it into a journey map.

This will be a starting point and can be a quick sketch. This will help us understand what info we have, and what we still need to learn more about about the process that we are hoping to improve (more journey mapping to follow)

Updated 14/12/2017 23:38 3 Comments

Subscritpion.read() failing because of system filed having "host_id" instead of "id"

SatelliteQE/nailgun

6.2.z branch

Example:

    subs = Subscription(cfg, organization=1).search()[0]
    print(subs.read())

Result console Traceback (most recent call last): File "/home/renzo/PycharmProjects/nailgun/nailgun/entities.py", line 5704, in <module> print(subs.read()) File "/home/renzo/PycharmProjects/nailgun/nailgun/entities.py", line 5167, in read return super(Subscription, self).read(entity, attrs, ignore) File "/home/renzo/PycharmProjects/nailgun/nailgun/entity_mixins.py", line 808, in read in _get_entity_ids(field_name, attrs) File "/home/renzo/PycharmProjects/nailgun/nailgun/entity_mixins.py", line 284, in _get_entity_ids return [entity['id'] for entity in attrs[plural_field_name]] KeyError: 'id'

Updated 14/12/2017 15:21

Fixes #2137: WMS.parseLayerCapabilities does not consider nested layers

geosolutions-it/MapStore2

Description

WMS.parseLayerCapabilities does not consider nested layers

Issues

  • See title

Please check if the PR fulfills these requirements - [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with “x”, remove the others)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other… Please describe:

What is the current behavior? (You can also link to an open issue here) WMS.parseLayerCapabilities does not consider nested layers

What is the new behavior? WMS.parseLayerCapabilities considers nested layers

Does this PR introduce a breaking change? (check one with “x”, remove the other)

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: …

Other information:

Updated 14/12/2017 15:09 1 Comments

[gatsby-plugin-netlify] create rewrite rules for pages that use matchPath

gatsbyjs/gatsby

This adds feature to gatsby-plugin-netlify that automaticly generate _redirects entries for pages that use matchPath. It’s implementation of idea from https://github.com/gatsbyjs/gatsby/pull/3168#issuecomment-351257197

It seems that react router path parameters are compatible with netlify so I just write them as they are. Not sure if they need to be prefixed (in case of pathPrefix)?

This will propably need updated readme, I’ll add that when code is agreed on (in case if this would feature would be changed to opt-in).

Updated 14/12/2017 17:43 3 Comments

Fixes #2130: CRS not normalized in openlayers WMS requests

geosolutions-it/MapStore2

Description

OpenLayers is appending a wrong CRS attribute to WMS requests if projection is EPSG:900913. The result is SRS=EPSG:3857&CRS=EPSG:900913

Issues

  • See title

Please check if the PR fulfills these requirements - [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with “x”, remove the others)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other… Please describe:

What is the current behavior? (You can also link to an open issue here) OpenLayers is appending a wrong CRS attribute to WMS requests if projection is EPSG:900913. The result is SRS=EPSG:3857&CRS=EPSG:900913

What is the new behavior? SRS=EPSG:3857&CRS=EPSG:3857

Does this PR introduce a breaking change? (check one with “x”, remove the other)

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: …

Other information:

Updated 14/12/2017 13:30 1 Comments

Fixes #2252: switching from tiled to single tiled in leaflet wms some…

geosolutions-it/MapStore2

… parameters are lost

Description

Switching WMS layers from single tile to tiled and viceversa, some parameters are lost

Issues

  • See title

Please check if the PR fulfills these requirements - [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with “x”, remove the others)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other… Please describe:

What is the current behavior? (You can also link to an open issue here) Switching WMS layers from single tile to tiled and viceversa, some parameters are lost

What is the new behavior? Switching WMS layers from single tile to tiled and viceversa, some parameters are not lost anymore (e.g. maxZoom)

Does this PR introduce a breaking change? (check one with “x”, remove the other)

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: …

Other information:

Updated 14/12/2017 12:51 2 Comments

Fixes #1307: correctly imports Shapefiles with EPSG:3857

geosolutions-it/MapStore2

Description

Correctly imports shapefiles with EPSG:3857 declared in PRJ file

Issues

  • Fixes #1305
  • Fixes #2175

Please check if the PR fulfills these requirements - [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with “x”, remove the others)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other… Please describe:

What is the current behavior? (You can also link to an open issue here) Shapefiles in EPSG:3857 are not correctly imported due to bugs in proj4js latest official release, same happens for axis inverted PRJs

What is the new behavior? Shapefiles in EPSG:3857 are correctly imported because we use a fixed version of proj4js not officially release yet (waiting for 2.4.5), also PRJs with axis inversion are correctly handles thanks to an unofficial fix of wkt-parser

Does this PR introduce a breaking change? (check one with “x”, remove the other)

  • [ ] Yes
  • [x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: …

Other information:

Updated 14/12/2017 11:40 2 Comments

Issue 397

dagcoin/dagcoin

<!— Provide a general summary of your changes in the Title above –>

Description

<!— Describe your changes in detail –>

Related Issue

<!— This project only accepts pull requests related to open issues –> <!— If suggesting a new feature or change, please discuss it in an issue first –> <!— If fixing a bug, there should be an issue describing it with steps to reproduce –> <!— If your PR is connected to an open issue, add a line in your PR’s description that says Closes #123, where #123 is the number of the issue you’re fixing. –> closes #592 closes #573

Updated 14/12/2017 08:34 1 Comments

Reformat module docs

elastic/beats

I’ve converted the format of the remaining modules in 6.1 to include steps for running the module and config examples.

I need help with the Kafka module config because it didn’t work completely (please see and respond to my notes to REVIEWERS).

Also, I haven’t done anything with the Traefik module because it doesn’t have docs. Should I add docs for that one?

Updated 15/12/2017 03:12 2 Comments

feat(tabs): add the pf tabs component

patternfly/patternfly-react

<!– What changes are being made? (What feature/bug is being fixed here?) –> What: This PR adds the PatternFly Tabs pattern. To be used to close #52 (Tabs) once done.

Storybook: https://rawgit.com/dabeng/patternfly-react/tabs-storybook/.out/index.html?knob-Justified=false&knob-Tab%203%20Disabled=false&knob-Tab%202%20Disabled=false&knob-Tab%201%20Disabled=false&knob-Navigation%20Style=tabs&knob-Label=Danger%20Will%20Robinson%21&knob-Tab%203%20Tittle=Tab%203&knob-Tab%202%20Tittle=Tab%202&knob-Tab%201%20Tittle=Tab%201&selectedKind=Tabs&selectedStory=Basic%20Tabs&full=0&down=1&left=1&panelRight=0&downPanel=storybooks%2Fstorybook-addon-knobs

<!– Why are these changes necessary? –> Why: Because #49 involves many dated code snippets and conflicts, I create new PR for component tabs.

How: Providing a tabs story of patternfly-react storybook based on react-bootstrap tabs component.

@priley86 , @jgiardino please review.

Updated 14/12/2017 22:05 4 Comments

Analysis Report showing incorrect cases completed at household level

ICTatRTI/coconut-analytics

Humphrey reported: “I have ran monthly report for November, 2017 (125 cases) and it appears that the analysis report [Screenshot B] does not account for the cases completed at household level (24 cases) [Screenshot A] i.e. case ids 116743; 116703; 116688; 116666; 116667 etc have been completely followed up to the household level but do not reflect in to the analysis report[Screenshot B].”

Updated 14/12/2017 14:36 3 Comments

Add Authorizer helper methods to auth package

Azure/go-autorest

Add helper methods for obtaining authorizers. See this PR for any comments https://github.com/Azure/go-autorest/pull/216

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions: - [ ] I’ve tested my changes, adding unit tests if applicable. - [ ] I’ve added Apache 2.0 Headers to the top of any new source files. - [ ] I’m submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release. - [ ] If I’m targeting master, I’ve updated CHANGELOG.md to address the changes I’m making.

Updated 14/12/2017 04:16

[REVIEW]: GIBBON: The Geometry and Image-Based Bioengineering add-ON

openjournals/joss-reviews

Submitting author: @Kevin-Mattheus-Moerman (<a href=“http://orcid.org/0000-0003-3768-4269”>Kevin Moerman</a>) Repository: <a href=“https://github.com/gibbonCode/GIBBON” target =“_blank”>https://github.com/gibbonCode/GIBBON</a> Version: v2.5.0 Editor: @cMadan Reviewer: @siboles Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7666e082975be31b8a64b5fe1e64f940"><img src="https://joss.theoj.org/papers/7666e082975be31b8a64b5fe1e64f940/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7666e082975be31b8a64b5fe1e64f940/status.svg)](https://joss.theoj.org/papers/7666e082975be31b8a64b5fe1e64f940)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=“https://github.com/gibbonCode/GIBBON” target=“_blank”>target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@siboles, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please: 1. Make sure you’re logged in to your GitHub account 2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @cMadan know.

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the <a target=“_blank” href=“https://github.com/gibbonCode/GIBBON”>repository url</a>?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (v2.5.0)?
  • [x] Authorship: Has the submitting author (@Kevin-Mattheus-Moerman) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [ ] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [ ] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
Updated 14/12/2017 20:12 4 Comments

Disk utilization fixes

influxdata/influxdb
Required for all non-trivial PRs
  • [ ] Rebased/mergable
  • [ ] Tests pass
  • [ ] CHANGELOG.md updated
  • [ ] Sign CLA (if not already signed)

This is a followup to #9206 to fix the higher disk utilization and lower write throughput in 1.4.2. One change in #9206 was to increase the snapshot size in order to create fewer and larger level 1 TSM files. This helped to slow down the frequency of compactions. Unfortunately, users with many databases or lots of active shards could OOM the process each shard is consuming more memory now.

This PR reverts that fix and fixes the issue slightly differently.
1. Snapshot concurrency is adjusted based on latency vs cardinality. 2. All TSM writing (compaction/snapshotting) is rate limited to reduce the impact of bursty snapshots and TSM fsyncs. The WAL is not part of this change. 3. Change compaction planning to run less frequently and adjusted the criteria for plans. Since compactions are completing roughly 2x-3x faster in 1.4 vs 1.3, we need to slow them down lot. 4. Fixed a compaction bug where only “fast” compactions would be run. This causes TSM files to be less compressed and bigger until a final full compaction runs.

This is a run on c4.4xlarge w/ 10B values, 2.5m series and 5 writers. The 1.4.2 run is only 1/5 of the way through, but the performance difference can be seen already. You can see in 1.4.2 that there are too many compactions getting run (combined w/ other issues) which increases disk utilization and lowers write throughput. This PR has perf that is similar or better to 1.3 in different areas. There are significantly fewer compactions, and write throughput is ~30% better than 1.3 now.

metrics

Fixes #9217 #9201

Updated 15/12/2017 03:37

Fix ORCID logins for Chrome 63+

OpenNeuroOrg/openneuro

1d4a455 is the fix, Chrome 63 returns a different URL for the error 400 request because it’s a failed request. This request should succeed since it’s the end of the oauth redirect flow, returning an empty 200 makes it work again in Chrome 63+

a63800a replaces the polling loop that checks for the redirect URL in the login window with an event handler for when the window closes and a document to trigger it.

Fixes #267

Updated 14/12/2017 23:18

Adjustable tree/detail width breaks page when used

opensalt/opensalt

Steps to reproduce:

Case 1: - move the centre bar to resize the width of the tree and detail sections (wider or narrower) - resize the browser to be narrower than the centre bar - ISSUE - the height of the page is increased significantly - the detail section is missing - the “toggle” arrows go missing

Case 2: - Using the Safari browser on a Mac - Drag the centre bar left - ISSUE - the “toggle” arrows do not move with the bar

Caused by #263

Updated 14/12/2017 17:16 7 Comments

Abstract the behavior of displaying tooltip for disable components into a HOC

CraveFood/farmblocks

Currently 3 components have a very similar behaviour:

  • a disabled property
  • that when true sets the onMouseOver and onMouseLeave event listeners
  • to display and hide a tooltip
  • that can have it’s default text changed using a tooltipText property

We should standardise it and centralize it in a lib imported by all the blocks with this behaviour and use it as a decorator.

Updated 14/12/2017 11:26 1 Comments

Feature/issue 3129 auth panic

couchbase/sync_gateway

This fixes the panic mentioned in #3129 caused by an uncaught error/uninitialized bucket and adds an integration test for this scenario.

The authentication error is explicitly checked to cause a fatal connection and halt further retries and log the reason.

Integration Tests

http://uberjenkins.sc.couchbase.com/view/Build/job/sync-gateway-integration-master/252/ http://uberjenkins.sc.couchbase.com/view/Build/job/sync-gateway-integration-master/253/

Updated 15/12/2017 01:39

Fork me on GitHub