Contribute to Open Source. Search issue labels to find the right project for you!

App/loginscreen

ericcornelissen/NervousFish
  • Relevant issues: #26

What

With this pull request a working login screen is added to the app.

Why

In the future we want to secure the app with a password. It could also be that we use the password to encrypt the private key, but this still has to be discussed.

How

The login screen is the new first screen you see when you open the app. The password is now hardcoded and is 12345. If you write something else, it will give an error. If you leave it empty you can still continue, for development purposes.

Updated 30/04/2017 15:18

Sort addresses in API outputs

DemocracyClub/UK-Polling-Stations

Deploying this will sort out the address picker on the EC’s YourVoteMatters site and also help us out when we come to implement the address picker on WCIVF as we don’t really want to have to implement this same logic across multiple sites.

Closes #744

Updated 29/04/2017 21:03 1 Comments

lifecycle: move ignore-scripts handling to actual place of use

npm/npm

Instead of overriding pkg.scripts when ignore-scripts is in effect, test the option when actually determining whether there is a script to invoke. Otherwise, published packages will not contain the proper scripts: fields when ignore-scripts is true.

Fixes: https://github.com/npm/npm/issues/16243

If you have any pointers for writing a test for this, I’d love to look into that. :)

Updated 29/04/2017 17:49

test: fix/skip test/tap/lifecycle-signal.js

npm/npm

The tests in test/tap/lifecycle-signal.js, as well as the features they are testing, are partially broken. This moves them from being skipped in CI to being disabled only for certain platforms.

In particular, because npm spawns its lifecycle scripts in a shell, signals are not necessarily forwarded by the shell and won’t cause scripts to exit; also, shells may report the signal they receive using their exit status, rather than terminating themselves with a signal.

Updated 29/04/2017 17:18

Add method to parse inner objects with unknown field names to ObjectParser

vagnerclementino/elasticsearch

When parsing aggregations and sub-aggregations we encounter cases where the aggregation name is written to the response as key for a new nested aggregation object on the same level that we want to parse other fields. Currently we cannot use ObjectParser in this situations because it requires some ParseField for matching the field name.

This adds a new declareUnknownFieldParser() method to ObjectParser that can be used to declare one specific ContextParser that gets called if no other FieldParsers that have been declared match.

Updated 29/04/2017 15:59

Add parsing methods for InternalDateHistogram and InternalHistogram

vagnerclementino/elasticsearch

Note: this pull request is against a feature branch.

This pull request adds the logic to parse InternalDateHistogram and InternalHistogram aggregations. To do that, it introduces a ParsedMultiBucketAggregation that implements the MultiBucketsAggregation from core. This class provides a base ParsedBucket that can be extended by parsed implementations to fit their specific needs.

For now, the parsing logic for aggregations and buckets reside in the ParsedHistogram and ParsedDateHistogram implementations. Some code could be shared but it makes everything harder to read and understand (I’m still looking at how to improve this).

The ParsedHistogram.ParsedBucket and ParsedDateHistogram.ParsedBucket are able to parse sub aggregations. They also handle the parsing logic when aggregations and buckets are keyed/not keyed.

It also introduces a InternalMultiBucketAggregationTestCase that takes care of verifying the aggregations and multiple buckets. It has a assertMultiBucketsAggregation that can checks the buckets in order or not.

Similarly to the existing InternalSingleBucketAggregationTestCase, the InternalMultiBucketAggregationTestCase randomly creates multi bucket aggregations that have sub aggregations of the same type (ie during tests, InternalDateHistogram can only have buckets with aggregations of type InternalDateHistogram). This makes things easier when checking the aggregations contained in a bucket - it uses a recursive call to assertMultiBucketsAggregation.

Updated 29/04/2017 15:57

Honor masking of systemd-sysctl.service

vagnerclementino/elasticsearch

During package install on systemd-based systems, some sysctl settings should be set (e.g. vm.max_map_count).

In some environments, changing sysctl settings plainly does not work; previously a global environment variable named ES_SKIP_SET_KERNEL_PARAMETERS was introduced to skip calling sysctl, but this causes trouble for: * configuration management systems, which usually cannot apply an env var when running a package manager * package upgrades, which will not have the env var set any more, and thus leaving the package management system in a bad state (possibly half-way upgraded, can be very hard to recover)

This removes the env var again and instead of calling systemd-sysctl manually, tells systemd to restart the wrapper unit - which itself can be masked by system administrators or management tools if it is known that sysctl does not work in a given environment. The restart is not silent on systems in their default configuration, but is ignored if the unit is masked.

Related: #21899, elastic/puppet-elasticsearch#806

Updated 29/04/2017 15:56

Add Vagrant based testing fixture

vagnerclementino/elasticsearch

This PR extends the functionality of the existing testing fixture code in our gradle build source. Previously, testing fixtures were locked into being executed by an Ant task. In order to take advantage of the existing enhanced Vagrant logging support in the build code, I have split the existing Fixture object into an interface (Fixture.groovy) and an implementation (AntFixture.groovy), and added a new implementation (VagrantFixture.groovy) that is based on the existing VagrantCommand task.

This is related to #23439 in that the integration tests will need to spin up a Kerberos KDC based in a virtual machine run by Vagrant.

Updated 29/04/2017 15:56

Introduce NioTransport into framework for testing

vagnerclementino/elasticsearch

This commit introduces a nio based tcp transport into framework for testing.

Currently Elasticsearch uses a simple blocking tcp transport for testing purposes (MockTcpTransport). This diverges from production where our current transport (netty) is non-blocking.

The point of this commit is to introduce a testing variant that more closely matches the behavior of production instances.

Updated 29/04/2017 15:56

Build the java query DSL api docs from a test

vagnerclementino/elasticsearch

We’ve had QueryDSLDocumentationTests for a while but it had a very hopeful comment at the top about how we want to make sure that the example in the query-dsl docs match up with the test but we never had anything that made sure that they did. This changes that!

Now the examples from the query-dsl docs are all built from the QueryDSLDocumentationTests. All except for the percolator example because that is hard to do as it stands now.

To make this easier this change moves QueryDSLDocumentationTests from core and into the high level rest client. This is useful for two reasons: 1. We expect the high level rest client to be able to use the builders. 2. The code that builds that docs doesn’t check out all of Elasticsearch. It only checks out certain directories. Since we’re already including snippets from that directory we don’t have to make any changes to that process.

Closes #24320

Updated 29/04/2017 15:55

Add UpgraderPlugin

vagnerclementino/elasticsearch

The UpgraderPlugin adds two additional extension points called during cluster upgrade and when old indices are introduced into the cluster state during initial recovery, restore from a snapshot or as a dangling index. One extension point allows plugin to update old templates and another extension points allows to update/check index metadata.

This change should simplify upgrade process for plugins that are using special indices to store their data, and should prevent situations when, for example, an accidental restore of an obsolete index would break the plugin.

Updated 29/04/2017 15:54

Update production notes in docs for Docker

vagnerclementino/elasticsearch

Add info about the base image used and the github repo of elasticsearch-docker.

Clarify that setting memlock=-1:-1 is only a requirement when bootstrap_memory_lock=true and the alternatives we document elsewhere in docs for disabling swap are valid for Docker as well.

Additionally, with latest versions of docker-ce shipping with unlimited (or high enough) defaults for nofile and nproc, clarify that explicitly setting those per ES container is not required, unless they are not defined in the Docker daemon.

Finally simplify production docker-compose.yml example by removing unneeded options. One such option is cap_add: IPC_LOCK which seems to be not required anymore in combination with memlock=-1:-1.

Updated 29/04/2017 15:54

Add support for early termination of search request

vagnerclementino/elasticsearch

Relates #6720 This change introduce early termination of search request for indices sorted by specific fields. When the index is sorted, the option called early_terminate indicates that top documents must be sorted by the index sort criteria and that only the top N documents per segment should be visited. Let’s say for example that we have an index sorted by timestamp:

PUT events
{
    "settings" : {
        "index" : {
            "sort.field" : "timestamp",
            "sort.order" : "desc" <2>
        }
    },
    "mappings": {
        "doc": {
            "properties": {
                "timestamp": {
                    "type": "date"
                }
            }
        }
    }
}

… it is then possible to retrieve the N last events without visiting all the documents in the index with the following query:

GET /events/_search
{
    "size": 10,
    "early_terminate": true
}

The sort of this search request is automatically set to the index sort and each segment will visit the first 10 matching documents at most.

Setting this option on an index that is not sorted by any criteria will throw an exception.

Updated 29/04/2017 15:54

Move IndicesAliasesRequest#concreteAliases to TransportIndicesAliasesAction

vagnerclementino/elasticsearch

IndicesAliasesRequest#concreteAliases has to do with how the transport action may or may not resolve wildcards expressions to aliases names. It is only needed in TransportIndicesAliasesAction and for this reason it should be a private method in it rather than part of a request class which is also part of the Java API and later in the high level REST client.

Updated 29/04/2017 15:54

Open/Close index api to allow_no_indices by default

vagnerclementino/elasticsearch

Open/Close index api have allow_no_indices set to false by default, while delete index has it set to true. The flag controls where a wildcard expression that matches no indices will be ignored or an error will be thrown instead. This commit aligns open/close default behaviour to that of delete index.

This is a followup to #24031. Also related to #24341.

Updated 29/04/2017 15:54

Simplify file store

vagnerclementino/elasticsearch

Today we go to heroic lengths to workaround bugs in the JDK or around issues like BSD jails to get information about the underlying file store. For example, we went to lengths to work around a JDK bug where the file store returned would incorrectly report whether or not a path is writable in certain situations in Windows operating systems. We never needed to work around these bugs, we could simply try to write to disk and let an I/O exception arise if we could not write to the disk. Additionally, we collected information about all file stores on the system which meant that if the user had a state NFS mount, Elasticsearch could hang and fail on startup if that mount point was not available. Finally, we collected information through Lucene about whether or not a disk was a spinning disk versus an SSD, information that we do not need since we assume SSDs by default. This commit takes into consideration that we simply do not need this heroic effort, we do not need information about all file stores, and we do not need information about whether or not a disk spins to greatly simplfy file store handling.

Closes #24390

Updated 29/04/2017 15:54

Block global checkpoint advances when recovering

vagnerclementino/elasticsearch

After a replica shard finishes recovery, it will be marked as active and its local checkpoint will be considered in the calculation of the global checkpoint on the primary. If there were operations in flight during recovery, when the replica is activated its local checkpoint could be lagging behind the global checkpoint on the primary. This means that when the replica shard is activated, we can end up in a situtaion where a global checkpoint update would want to move the global checkpoint backwards, violating an invariant of the system. This only arises if a background global checkpoint sync executes, which today is only a scheduled operation and might be delayed until the in-flight operations complete and the replica catches up to the primary. Yet, we are going to move to inlining global checkpoints which will cause this issue to be more likely to manifest. Additionally, the global checkpoint on the replica, which is the local knowledge on the replica updated under the mandate of the primary, could be higher than the local checkpoint on the replica, again violating an invariant of the system. This commit addresses these issues by blocking global checkpoint on the primary when a replica shard is finalizing recovery. While we have blocked global checkpoint advancement, recovery on the replica shard will not be considered complete until its local checkpoint advances to the blocked global checkpoint.

Relates #10708

Updated 29/04/2017 15:54

Block global checkpoint advances when recovering

elastic/elasticsearch

After a replica shard finishes recovery, it will be marked as active and its local checkpoint will be considered in the calculation of the global checkpoint on the primary. If there were operations in flight during recovery, when the replica is activated its local checkpoint could be lagging behind the global checkpoint on the primary. This means that when the replica shard is activated, we can end up in a situtaion where a global checkpoint update would want to move the global checkpoint backwards, violating an invariant of the system. This only arises if a background global checkpoint sync executes, which today is only a scheduled operation and might be delayed until the in-flight operations complete and the replica catches up to the primary. Yet, we are going to move to inlining global checkpoints which will cause this issue to be more likely to manifest. Additionally, the global checkpoint on the replica, which is the local knowledge on the replica updated under the mandate of the primary, could be higher than the local checkpoint on the replica, again violating an invariant of the system. This commit addresses these issues by blocking global checkpoint on the primary when a replica shard is finalizing recovery. While we have blocked global checkpoint advancement, recovery on the replica shard will not be considered complete until its local checkpoint advances to the blocked global checkpoint.

Relates #10708

Updated 30/04/2017 11:10

Move content about processors to filtering section in the doc

elastic/beats

@monicasarbu I’d like for you to take a quick look at this before I change the docs for the other beats. I’ve streamlined the intro because I want users to know that the prospector-level options exist, but I don’t think we should cover them in very much detail since the main point of the section (after the reorg) is to cover processors. Here’s what the TOC looks like (with some slight changes from your suggested titles because they made the TOC entries harder to scan):

image

Updated 29/04/2017 03:14

Simplify file store

elastic/elasticsearch

Today we go to heroic lengths to workaround bugs in the JDK or around issues like BSD jails to get information about the underlying file store. For example, we went to lengths to work around a JDK bug where the file store returned would incorrectly report whether or not a path is writable in certain situations in Windows operating systems. Another bug prevented getting file store information on Windows on a virtual drive on Windows. We no longer need to work around these bugs, we could simply try to write to disk and let an I/O exception arise if we could not write to the disk or take advantage of the fact that these bugs are fixed in recent releases of the JDK (e.g., the file store bug is fixed since 8u72). Additionally, we collected information about all file stores on the system which meant that if the user had a stale NFS mount, Elasticsearch could hang and fail on startup if that mount point was not available. Finally, we collected information through Lucene about whether or not a disk was a spinning disk versus an SSD, information that we do not need since we assume SSDs by default. This commit takes into consideration that we simply do not need this heroic effort, we do not need information about all file stores, and we do not need information about whether or not a disk spins to greatly simplfy file store handling.

Closes #24390

Updated 29/04/2017 19:38

Update botocore to 1.5.45

mozilla/telemetry-analysis-service

There’s a new version of botocore available. You are currently using 1.5.43. I have updated it to 1.5.45

These links might come in handy: <a href=“https://pypi.python.org/pypi/botocore”>PyPI</a> | <a href=“https://pyup.io/changelogs/botocore/”>Changelog</a> | <a href=“https://github.com/boto/botocore”>Repo</a>

Changelog

1.5.45


  • api-change:cloudformation: Update cloudformation client to latest version
  • api-change:snowball: Update snowball client to latest version
  • api-change:sqs: Update sqs client to latest version
  • api-change:rekognition: Update rekognition client to latest version
  • bugfix:Paginator: Fixes bug where pagination would fail if the pagination token contained bytes.
  • api-change:rds: Update rds client to latest version

1.5.44


  • enhancement:rds: Add rds database presigner.
  • api-change:rds: Update rds client to latest version

Got merge conflicts? Close this PR and delete the branch. I’ll create a new PR for you.

Happy merging! 🤖

Updated 29/04/2017 00:22 1 Comments

Prevent bad optimization of SQLite queries for view indexing & changes

couchbase/couchbase-lite-ios

I’ve also added explicit JOIN syntax in a few places, since it’s said to give the optimizer more insight into the meaning of the query.

I also removed several unnecessary indexes, where SQLite already indexes the column in question to implement a UNIQUE constraint. This was recommended by SQLite gurus to avoid confusing the optimizer.

Fixes #1737

NOTE: If you’re not familiar with it, the unary “+” operator in SQLite tells the query optimizer to avoid using an index on the referenced column. It’s otherwise a no-op.

Updated 29/04/2017 00:00 1 Comments

[babel] tweak babel options for performance and debugging

elastic/kibana

Closes #9472

  • Removes stage-1 preset and uses individual plugins as necessary
  • Consolidates the babel config into a preset for node and a preset for webpack
  • Enable babel-preset-env’s useBuiltIns option which trims the core-js polyfills to just those necessary for the current node version
  • Removes the all stage 1 and 2 plugins except babel-plugin-transform-class-properties
Updated 28/04/2017 23:52

View indexing is very slow, due to mis-optimized SQLite query

couchbase/couchbase-lite-ios

(CBSE-3690) View indexing has gotten drastically slower, at least in some use cases, in iOS 10 due to SQLite’s mis-optimization of the main query used to find the new revisions to index — it takes a very long time (~500ms) and generates huge numbers of reads.

Using EXPLAIN QUERY PLAN I found that the optimizer has generated a horrifically bad plan, essentially an inside-out join, that results in linear scans of two large tables. (Presumably this is due to some change in the optimizer between the older and newer versions of SQLite in iOS.)

The query, with some extraneous details removed, looks like: sql SELECT docs.doc_id, revs.sequence, docs.docid, rev.revid, rev.json, […] FROM revs, docs WHERE revs.sequence>? AND revs.current!=0 AND revs.doc_id = docs.doc_id ORDER BY revs.doc_id, revs.deleted, revs.revid DESC Basically this query is meant to find the latest revs, including their “docid” strings joined from the “docs” table. It should just be using the “revs” table’s primary index starting from the “?” parameter, then looking up the corresponding doc for each revision. Instead it does this: ``` selectid = 0 order = 0 from = 1 detail = SCAN TABLE docs USING COVERING INDEX docs_docid

selectid = 0 order = 1 from = 0 detail = SEARCH TABLE revs USING INDEX revs_current (doc_id=?)

selectid = 0 order = 0 from = 0 detail = USE TEMP B-TREE FOR ORDER BY ``` It’s scanning through all 50,000+ rows in “docs”, and then for each document looking up all the rows in “revs” that reference it (“revs” has 175,000 rows), and comparing their sequences to the parameter.

Updated 28/04/2017 23:18

D8 HASH_SALT section is not clear

pantheon-systems/documentation

D8 HASH_SALT section not clear. It appears to be contradictory or is discussing two different aspects of HASH_SALT, not sure

Closes #

Effect

PR includes the following changes: - I flagged the areas the seem contradictory.

Remaining Work

  • Actual correct edits still needed
Updated 28/04/2017 20:43

Move IndicesAliasesRequest#concreteAliases to TransportIndicesAliasesAction

elastic/elasticsearch

IndicesAliasesRequest#concreteAliases has to do with how the transport action may or may not resolve wildcards expressions to aliases names. It is only needed in TransportIndicesAliasesAction and for this reason it should be a private method in it rather than part of a request class which is also part of the Java API and later in the high level REST client.

Updated 28/04/2017 20:30

[6.3] Fix user account update password issue #4622

SatelliteQE/robottelo

close #4622 ```console (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ py.test -v tests/foreman/cli/test_myaccount.py::MyAccountEphemeralUserTestCase::test_positive_update_password ================================================= test session starts ================================================== platform linux2 – Python 2.7.13, pytest-3.0.7, py-1.4.32, pluggy-0.4.0 – /home/dlezz/.pyenv/versions/sat-6.3.0/bin/python2.7 cachedir: .cache rootdir: /home/dlezz/projects/robottelo-fork, inifile: plugins: xdist-1.15.0, services-1.1.14, cov-2.4.0 collected 2 items 2017-04-28 19:22:04 - conftest - DEBUG - Found WONTFIX in decorated tests [‘1110476’, ‘1269196’, ‘1378009’, ‘1245334’, ‘1221971’, ‘1217635’, ‘1226425’, ‘1156555’, ‘1199150’, ‘1204686’, ‘1267224’, ‘1103157’, ‘1230902’, ‘1214312’, ‘1079482’]

2017-04-28 19:22:04 - conftest - DEBUG - Collected 1 test cases

tests/foreman/cli/test_myaccount.py::MyAccountEphemeralUserTestCase::test_positive_update_password PASSED

================================================== 0 tests deselected ================================================== ============================================== 1 passed in 21.76 seconds =============================================== (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ py.test -v tests/foreman/ui/test_myaccount.py::MyAccountTestCase::test_positive_update_password ================================================= test session starts ================================================== platform linux2 – Python 2.7.13, pytest-3.0.7, py-1.4.32, pluggy-0.4.0 – /home/dlezz/.pyenv/versions/sat-6.3.0/bin/python2.7 cachedir: .cache rootdir: /home/dlezz/projects/robottelo-fork, inifile: plugins: xdist-1.15.0, services-1.1.14, cov-2.4.0 collected 12 items 2017-04-28 19:24:00 - conftest - DEBUG - Found WONTFIX in decorated tests [‘1110476’, ‘1269196’, ‘1378009’, ‘1245334’, ‘1221971’, ‘1217635’, ‘1226425’, ‘1156555’, ‘1199150’, ‘1204686’, ‘1267224’, ‘1103157’, ‘1230902’, ‘1214312’, ‘1079482’]

2017-04-28 19:24:00 - conftest - DEBUG - Collected 1 test cases

tests/foreman/ui/test_myaccount.py::MyAccountTestCase::test_positive_update_password PASSED

================================================== 0 tests deselected ================================================== ============================================== 1 passed in 239.50 seconds ============================================== (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ ```

Updated 28/04/2017 19:49 2 Comments

Add support for early termination of search request

elastic/elasticsearch

Relates #6720 This change introduce early termination of search request for indices sorted by specific fields. When the index is sorted, the option called early_terminate indicates that top documents must be sorted by the index sort criteria and that only the top N documents per segment should be visited. Let’s say for example that we have an index sorted by timestamp:

PUT events
{
    "settings" : {
        "index" : {
            "sort.field" : "timestamp",
            "sort.order" : "desc" <2>
        }
    },
    "mappings": {
        "doc": {
            "properties": {
                "timestamp": {
                    "type": "date"
                }
            }
        }
    }
}

… it is then possible to retrieve the N last events without visiting all the documents in the index with the following query:

GET /events/_search
{
    "size": 10,
    "early_terminate": true
}

The sort of this search request is automatically set to the index sort and each segment will visit the first 10 matching documents at most.

Setting this option on an index that is not sorted by any criteria will throw an exception.

Updated 28/04/2017 18:47

[6.3] Fix user groups issue #4616

SatelliteQE/robottelo

close issue https://github.com/SatelliteQE/robottelo/issues/4616 ```console “!!! Congratulations your changes are good to fly, make a great PR! dlezz++ !!!” (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ py.test tests/foreman/cli/test_usergroup.py::UserGroupTestCase -v -k “test_positive_create_with_usergroups or test_positive_create_with_usergroup_name or test_positive_create_with_usergroup_id” ================================================= test session starts ================================================== platform linux2 – Python 2.7.13, pytest-3.0.7, py-1.4.32, pluggy-0.4.0 – /home/dlezz/.pyenv/versions/sat-6.3.0/bin/python2.7 cachedir: .cache rootdir: /home/dlezz/projects/robottelo-fork, inifile: plugins: xdist-1.15.0, services-1.1.14, cov-2.4.0 collected 32 items 2017-04-28 18:20:47 - conftest - DEBUG - Found WONTFIX in decorated tests [‘1110476’, ‘1269196’, ‘1378009’, ‘1245334’, ‘1221971’, ‘1217635’, ‘1226425’, ‘1156555’, ‘1199150’, ‘1204686’, ‘1267224’, ‘1103157’, ‘1230902’, ‘1214312’, ‘1079482’]

2017-04-28 18:20:47 - conftest - DEBUG - Collected 32 test cases

tests/foreman/cli/test_usergroup.py::UserGroupTestCase::test_positive_create_with_usergroup_id PASSED tests/foreman/cli/test_usergroup.py::UserGroupTestCase::test_positive_create_with_usergroup_name PASSED tests/foreman/cli/test_usergroup.py::UserGroupTestCase::test_positive_create_with_usergroups PASSED

================================================= 29 tests deselected ================================================== ====================================== 3 passed, 29 deselected in 175.12 seconds ======================================= (sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ ```

Updated 28/04/2017 16:52 2 Comments

Static Series for Time Series Visual Builder

elastic/kibana

This PR adds the ability to define a static line on a chart. This can be used to add a threshold marker. You can also stack these series and create threshold backgrounds. In the image below I added 2 static values 1 at 0.3 and one at 0.1. Then I removed the lines, filled the series and stack only the two static lines. This creates the effect of background colors (or thresholds)

image

Updated 28/04/2017 20:41 1 Comments

Update production notes in docs for Docker

elastic/elasticsearch

Add info about the base image used and the github repo of elasticsearch-docker.

Clarify that setting memlock=-1:-1 is only a requirement when bootstrap_memory_lock=true and the alternatives we document elsewhere in docs for disabling swap are valid for Docker as well.

Additionally, with latest versions of docker-ce shipping with unlimited (or high enough) defaults for nofile and nproc, clarify that explicitly setting those per ES container is not required, unless they are not defined in the Docker daemon.

Finally simplify production docker-compose.yml example by removing unneeded options. One such option is cap_add: IPC_LOCK which seems to be not required anymore in combination with memlock=-1:-1.

Updated 28/04/2017 15:45

[6.3] qe_test_coverage_1398392

SatelliteQE/robottelo

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1398392 resolution show message “Invalid smart-proxy id” nightly show message “Invalid capsule id” resolved in https://github.com/shlomizadok/foreman/blob/aaeeeb33b03f263d36b71cdab7a06170bc90462b/app/controllers/api/v2/domains_controller.rb#L64

(sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ py.test tests/foreman/cli/test_domain.py -v -k "test_negative_create_with_invalid_dns_id"
================================================= test session starts ==================================================
platform linux2 -- Python 2.7.13, pytest-3.0.7, py-1.4.32, pluggy-0.4.0 -- /home/dlezz/.pyenv/versions/sat-6.3.0/bin/python2.7
cachedir: .cache
rootdir: /home/dlezz/projects/robottelo-fork, inifile:
plugins: xdist-1.15.0, services-1.1.14, cov-2.4.0
collected 12 items 
2017-04-28 17:12:30 - conftest - DEBUG - Found WONTFIX in decorated tests ['1110476', '1269196', '1378009', '1245334', '1221971', '1217635', '1226425', '1156555', '1199150', '1204686', '1267224', '1103157', '1230902', '1214312', '1079482']

2017-04-28 17:12:30 - conftest - DEBUG - Collected 12 test cases


tests/foreman/cli/test_domain.py::DomainTestCase::test_negative_create_with_invalid_dns_id <- robottelo/decorators/__init__.py PASSED

================================================= 11 tests deselected ==================================================
======================================= 1 passed, 11 deselected in 5.64 seconds ========================================
(sat-6.3.0) dlezz@elysion:~/projects/robottelo-fork$ 
Updated 28/04/2017 15:51 3 Comments

Move elasticsearch node_stats metricset under node.stats namespace

elastic/beats

So far the node_stats was putting all its data under elasticsearch.node_stats.*. This was changed to elasticsearch.node.stats.*.

Further changes:

  • Remove support for setting index in metricset. This was never used and can now be done through using format string in the index setting.
  • Remove support for setting type in metricset. Type will be removed in elasticsearch.
  • Rename ModuleData constant to ModuleDataKey.
  • Introduce NamespaceKey as constant to replace hardcoded _namespace.
  • Cleanup event generation for metricbeat.
  • Remove type from event as not needed.
Updated 28/04/2017 12:59

Split travis jobs for less timeouts

Project-OSRM/osrm-backend

Issue

Tries to address https://github.com/Project-OSRM/osrm-backend/issues/3976 by splitting the coverage and sanitizer builds. Also moves the script tests (formating, taginfo, docs) to an own job.

Tasklist

  • [ ] review
  • [ ] adjust for comments

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Updated 28/04/2017 16:57

PrimeNG 4.0.0-RC5: p-growl "life" property doesn't work

primefaces/primeng

<!– - IF YOU DON’T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING. - IF YOU’D LIKE TO SECURE OUR RESPONSE, YOU MAY CONSIDER PRIMENG PRO SUPPORT WHERE SUPPORT IS PROVIDED WITHIN 4 hours. –>

I’m submitting a … (check one with “x”) [X ] bug report => Search github for a similar issue or PR before submitting [ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap [ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports) Don’t have

Current behavior <!– Describe how the bug manifests. –> I have a p-growl component with life=“5000”. When it shows, it stays visible forever (until I click on the “x” icon).

Expected behavior <!– Describe what the behavior would be without the bug. –> p-growl is visible only for 5 seconds.

Minimal reproduction of the problem with instructions <!– If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5). –>

What is the motivation / use case for changing the behavior? <!– Describe the motivation or the concrete use case –>

Please tell us about your environment: <!– Operating system, IDE, package manager, HTTP server, … –>

  • Angular version: 4.1.X <!– Check whether this is still an issue in the most recent Angular version –>

  • PrimeNG version: 4.0.0-RC5 <!– Check whether this is still an issue in the most recent Angular version –>

  • Browser: [all] <!– All browsers where this could be reproduced –>

  • Language: [all | TypeScript 2.3 ES5]

  • Node (for AoT issues): node --version =

Updated 28/04/2017 14:27 7 Comments

Automate BZ1344033

SatelliteQE/robottelo

https://bugzilla.redhat.com/show_bug.cgi?id=1344033 ```python py.test tests/foreman/ui/test_activationkey.py -k test_positive_host_associations ============================= test session starts ============================== platform darwin – Python 2.7.13, pytest-3.0.7, py-1.4.33, pluggy-0.4.0 rootdir: /Users/andrii/workspace/robottelo, inifile: plugins: xdist-1.15.0, services-1.1.14, cov-2.3.1 collected 38 items 2017-04-28 14:40:29 - conftest - DEBUG - Found WONTFIX in decorated tests [‘1110476’, ‘1269196’, ‘1378009’, ‘1245334’, ‘1221971’, ‘1217635’, ‘1226425’, ‘1156555’, ‘1199150’, ‘1204686’, ‘1267224’, ‘1103157’, ‘1230902’, ‘1214312’, ‘1079482’]

2017-04-28 14:40:29 - conftest - DEBUG - Collected 38 test cases

tests/foreman/ui/test_activationkey.py .

============================= 37 tests deselected ============================== ================== 1 passed, 37 deselected in 320.35 seconds =================== ```

Updated 28/04/2017 12:01 2 Comments

[WIP] Kubelet dashboards

elastic/beats

This PR:

  • Unifies field names for kubelet modules
  • Adds initial dashboard (Kubernetes overview)

I would like to keep this one open until I do rename kubelet -> kubernetes. I’m working on a second k8s related module and want to test several ways of doing this first.

image

Updated 28/04/2017 11:26

Coordination of public consultation phase

okfn/opendatasurvey

We will need to respond to feedback from government, civil society, and link all stakeholders throughout the process.

We need to check all comments from March 15 onwards and respond

What are criteria to change a score - [ ] must relate to the time frame - [ ] what feedback qualifies so that we need to make changes

Updated 28/04/2017 10:33

Add UpgraderPlugin

elastic/elasticsearch

The UpgraderPlugin adds two additional extension points called during cluster upgrade and when old indices are introduced into the cluster state during initial recovery, restore from a snapshot or as a dangling index. One extension point allows plugin to update old templates and another extension points allows to update/check index metadata.

This change should simplify upgrade process for plugins that are using special indices to store their data, and should prevent situations when, for example, an accidental restore of an obsolete index would break the plugin.

Updated 29/04/2017 20:57 1 Comments

WIP: 151 refactor classifier

DistrictDataLabs/yellowbrick

This refactor of the classifier module resolves #151. It should be close, and can be merged as is, though I’d like to fix a few more things in it. Making the pull request now so you can see where it stands.

Note, this adds the enhancement of using the find_text_color util for the ClassificationReport. It also includes a partial fix of #141 - the code no longer errors out and a report is displayed, but it has weird dimensions (half the screen area isn’t used).

Still to do: 1) @bbengfort in your comment in 151 you said “don’t forget to update the documentation autodoc functionality.” I’m not sure what that refers to? 2) I’d also like to do a quick pass at cleaning up the docstrings while I’m here, plus maybe do a bit of mild inheritance adjustment to hoist some stuff up to the ClassificationScoreVisualizer, but if I don’t get to it I’ll add a a new issue. 3) Hoping to do complete fix of #141 by converting it to a mesh instead of imshow, the way I did for the ConfusionMatrix.

Updated 27/04/2017 23:43

Add Reaction method for adding default roles

reactioncommerce/reaction

Makes it trivial to add roles needed by a plugin to default visitor set

Includes 12 passing tests that should describe most of the functionality.

I wrote this while pulling in and trying to get some of the Stripe Connect stuff to work in the marketplace branch. To enable stripe connect accounts, we have to expose a callback url. This makes it easy to add that callback url route (or any other public facing route or permission) to the defaultRoles or defaultVisitorRole set

Takes an options object that looks like this: js { allShops: Boolean, // Should we update all shops or just specified shops shops: [String], // Array of shop ids to update if we are not updating all shops roleSets: [String], // Array of role sets to update, currently "defaultRoles" or "defaultVisitorRole" roles: [String], // Array of roles to add to the specified shops role sets }

Usage looks like this: ```js import { Reaction, Hooks } from “/server/api”;

Hooks.Events.add(“afterCoreInit”, () => { Reaction.addRolesToDefaultRoleSet({ allShops: true, // OR shops: [“shopId”], roleSets: [“defaultRoles”, “defaultVisitorRole”], roles: [“specific-role-that-visitors-should-have”] }); }); ```

Updated 28/04/2017 22:33

Account for PayPal in claiming workflow

gratipay/gratipay.com

Part of #4305, follows on #4424.

Brainstorm: let’s account for this by automatically using their newly verified email as their PayPal, and telling them that if they want to change it they can.

  • [x] look into possible bug in revive where one participants gets the other’s paypal linked … bumped to #4437
Updated 28/04/2017 20:59 6 Comments

Fork me on GitHub