Contribute to Open Source. Search issue labels to find the right project for you!

Windows presubmit failure: GetExitCodeProcess(): The handle is invalid.

bazelbuild/bazel

We saw this on the internal CI (bug 67878584).

Two parts of the build log: ``` Caused by: java.lang.IllegalStateException: GetExitCodeProcess(): The handle is invalid.

    at com.google.devtools.build.lib.windows.WindowsSubprocess.exitValue(WindowsSubprocess.java:195)
    at com.google.devtools.build.lib.shell.FutureCommandResultImpl.waitForProcess(FutureCommandResultImpl.java:89)
    at com.google.devtools.build.lib.shell.FutureCommandResultImpl.get(FutureCommandResultImpl.java:42)
    at com.google.devtools.build.lib.shell.Command.execute(Command.java:248)
    at com.google.devtools.build.lib.exec.local.LocalSpawnRunner$SubprocessHandler.start(LocalSpawnRunner.java:270)
    at com.google.devtools.build.lib.exec.local.LocalSpawnRunner$SubprocessHandler.run(LocalSpawnRunner.java:153)

In the same log, further down:

ERROR: T:/tmp/tmpg24w5c/third_party/BUILD:370:1: Extracting interface //third_party:guava failed (Exit -1). Note: Remote connection/protocol failed with: execution failed: ijar.exe failed: error executing command cd T:/tmp/bazel_kbuilder/glwgywz0/execroot/io_bazel SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\msys64\usr\bin\;C:\python27;C:\cygwin64\bin;(…);C:\Windows\System32\WindowsPowerShell\v1.0 SET TEMP=T:\tmp SET TMP=T:\tmp external/bazel_tools/tools/jdk/ijar/ijar.exe third_party/error_prone/error_prone_annotations-2.1.1.jar bazel-out/host/genfiles/third_party/ijar/guava/third_party/error_prone/error_prone_annotations-2.1.1-ijar.jar. Action failed to execute: java.io.IOException: CreatePipe(stdin): The handle is invalid. ```

/cc @lberki

Updated 17/10/2017 07:50 1 Comments

docs: Add Application as a Key Concept

strongloop/loopback-next

Overview

On loopback.io under the Concepts section, Application needs to be added as it is a foundational element for creating anything.

Applications are essentially a foundational building block which serves as a container for all other entities.

Link to Concepts Overview Page: http://loopback.io/doc/en/lb4/Concepts.html

Acceptance Criteria

  • [ ] Add a new page under LB4 Documentation under Concepts section to explain the concept of an Application.
  • [ ] Update loopback.io concepts page to include a summary of an Application and link to detailed concept explanation.

Must include: - [ ] Explanation of how Application is the basis of your app - [ ] Is a Context (link to Context page for more info) - [ ] Sugar function explanations - [ ] Controller - [ ] Server - [ ] Component - [ ] Explanation of the Application constructor arguments format - [ ] Explanation of how you can use Mixins with Applications (segue to a Mixins page) - [ ] Starting/stopping your Application

Updated 16/10/2017 18:17

Fix for #2752 pull alt text from key definition

dita-ot/dita-ot

Description

The DITA spec says that when a key reference is resolved on an <image>, what would normally be pulled as link text for that key should go into <alt>. This is required to make keys really work for images, because alt text is required for virtually every image, and is likely to change when the image changes with a key definition.

Motivation and Context

As discussed in #2752 – this updates key processing to put resolved key text into <alt>. It follows the same logic used elsewhere to put a <linktext> wrapper around key text resolved for a <link>. As part of this, it changes <image> designation from an empty element with no content, to an element that allows content – which is true of the created <alt> element (in the same way that <link> allows content once we create <linktext>).

How Has This Been Tested?

Tested with existing tests, which are extended to add the “normal” case of alternate text inside <linktext> inside the key definition.

Also tested with local key definition that gets alt text from each of:

  • <linktext>
  • <navtitle>
  • @navtitle
  • <keyword>
  • no alt text

Repeated each of those cases for <image>, <image> with <alt> (use that), image/@alt (key text overrides the deprecated @alt), and image without @href.

Type of Changes

Fix that follows the pattern of recent fix for other keys.

Checklist

X I have signed-off my commits per http://www.dita-ot.org/DCO. X Builds & tests completed successfully (./gradlew test integrationTest). X My code follows the code style of this project. - https://github.com/dita-ot/dita-ot/wiki/Java-Coding-Conventions - https://github.com/dita-ot/dita-ot/wiki/XSLT-Coding-Conventions X I have updated the unit tests to reflect the changes in my code.

Updated 16/10/2017 14:50

Write a better advice on testing custom sequences

strongloop/loopback-next

https://github.com/strongloop/loopback.io/pull/479 advices LoopBack users to write acceptance tests for their custom sequence implementation. As I wrote in https://github.com/strongloop/loopback.io/pull/479#discussion_r144544761, I think that may not be the best way, especially considering our own advice in Thinking in LoopBack:

How to create a great test suite? By thinking smaller and favoring fast, focused unit-tests over slow application-wide end-to-end tests.

On one hand, writing several end-to-end tests to verify how auth is applied to each endpoint brings quite a lot of confidence for the security of our app. On the other hand, these tests are repetitive to write and take a long time to execute.

I am proposing to rewrite sequence-related sections in “Testing your application” with the following advices:

  • A small number of integration tests to make sure all sequence customizations are applied for HTTP requests, these tests can invoke a dummy test controller method instead of real API endpoints - we are interested in the sequence, not any specific controller method.

  • Unit test for each controller method to ensure the method is correctly decorated with the metadata used by additional sequence actions used in our custom sequence.

For example, let’s say we are using @loopback/authentication and its @authenticate decorator and authenticate() sequence action. To test such app, we would write:

  • four integration tests: two tests for a controller method decorated with @authenticate (an anonymous request, an authenticated request), two tests for a controller method not decorated with @authenticate (again, an anonymous request, an authenticated request)

  • for each controller method, one unit test verifying that the method is (or is not) decorated with @authenticate

Updated 16/10/2017 17:18

cannot call again

vector-im/riot-android

https://github.com/matrix-org/riot-android-rageshakes/issues/1321

At first I made a call, which was answered only when my screen went out. The conversation was successful. After the conversation was over, I called again. And after the answer at that end, nothing happened to me. The next attempt is also unsuccessful. As you can see on the screenshot - in the window there simply does not appear any messages, such as Call connecting

Updated 16/10/2017 12:02

Allow injecting dependencies through `--override_repository`

bazelbuild/continuous-integration

Both rules_scala / intellij and the abseil people would like to test some downstream dependencies are not broken by downstream project.

We should have the possibility to git clone a repository and inject it with --override_repository. Right now it should be possible with configure in a hacky way (see https://github.com/bazelbuild/rules_scala/issues/308#issuecomment-336838679) but we should be able to inject that in an easier way. E.g. for now just specify the repository to git clone and once we have recursive workspace probably just specify a WORKSPACE file to override.

Ideally that could be passed down to bazel/presubmit so we have immediately global presubmit for abseil and other dependencies (not very efficient, but so far we are not constrained by that, more by peak hours during munich time).

/cc @ittaiz @gennadiycivil

Updated 16/10/2017 10:12

File System package simulator error

Microsoft/pxt

In the File System, the settings save number ["_"] as [_] causes the following simulator error: Program Error: pxsim.files.createDirectory is not a function fs

Same thing happens with the settings read number ["_"] block.

Updated 16/10/2017 16:03

cannot join #Furnet_#S:spydar007.com

vector-im/riot-android

reported by @mikaela:disroot.org https://github.com/matrix-org/riot-android-rageshakes/issues/1320

0-16 08:26:28.156Z 1 D/Room: Join the room !lONoDsVhriUeRDHnBr:spydar007.com with alias #Furnet#S:spydar007.com 10-16 08:26:28.156Z 1 D/RestAdapterCallback: Trigger the event [joinRoom : roomId #Furnet#S:spydar007.com] 10-16 08:26:28.259Z 1 D/RestAdapterCallback: ## failure(): [joinRoom : roomId #Furnet#S:spydar007.com] with error 404 Not Found 10-16 08:26:28.260Z 1 E/Room: join onMatrixError Room alias #Furnet#S:spydar007.com not found

Updated 16/10/2017 08:59 1 Comments

Card hostname can overflow

mozilla/activity-stream

If ShortURL.jsm can’t process the hostname of a url properly it falls back to using the page title. If the page title is too long then the hostname of the highlights card overflows as shown here.

<img width=“237” alt=“screen shot 2017-10-16 at 1 42 05 am” src=“https://user-images.githubusercontent.com/7688302/31591069-5fc6f724-b213-11e7-9bd0-6eef87696248.png”>

For reference, the url is this.

This issue is probably quite niche as it (presumably) has to be an unusual tld for the hostname to not be parsed properly (in this case gov.uk), and the page title has to be long enough.

One other issue the fallback causes is that highlights are no longer deduped by hostname, so all nine cards end up being from the same host, though that’s less of a problem.

Probably a straightforward fix to limit the hostname to one line? Though I’m not sure what would happen if a domain itself happened to be really long.

Updated 16/10/2017 20:37 6 Comments

Mention the benefits that immutable collections have over Java9's "Convenience Factory Methods for Collections" feature

google/guava

Java 9 has just introduced the “Convenience Factory Methods for Collections” feature. As ImmutableList.of() and similar methods in Guava, these factory methods create unmodifiable collections and prohibit null elements. The created collections are serializable if all of their elements are serializable. Please find more details on http://openjdk.java.net/jeps/269.

It’s worth considering to extend the Javadoc of the corresponding Guava classes (ImmutableList, ImmutableMap and ImmutableSet) like it happened in 3afc6e45c39504ece02d14f4a462f65acfa98652 to discourage using the old factory methods in favor of the Java 7 diamond syntax.

Updated 16/10/2017 15:38 5 Comments

Add an easy way to perform a new search from the ad search result page

litomba/www

Description

<!– A description of the bug (current behaviour / expected behaviour) or enhancement (expected behaviour) –> From the ad search result page, currently the user cannot perform a new search except by using the browser navigation button. The user should be able to easily perform a new search either by directly changing the search criteria displayed on the user page, or adding a “Retour” button to go back to the search page (not ideal at all but if it is less time consuming, it will be enough for now).

Steps to reproduce / User Story

<!– In case of a bug, include de steps de reproduce. –> <!– In case of an enhancement, provide the user story. –> 1. 2. 3. 4.

Environment

<!– In case of a bug, please select the environment where it happens –> <!– In case of an enhancement, please delete this section –>

Operating System

  • Android
  • iOS
  • Windows
  • macOS

Browser

  • Chrome
  • Firefox
  • Safari
  • Edge
  • Opéra
  • Internet Explorer

Notes

<!– Please feel free to add anything else you think is relevant to this issue –>

Updated 15/10/2017 16:22

enum values not displayed in example/model view (resubmitted using template)

swagger-api/swagger-ui

ENUM values in the schema definition are not displayed in the example/model view sections of the swagger-ui page.

Q A
Bug or feature request? Bug
Which Swagger/OpenAPI version? 2.0
Which Swagger-UI version? 3.3.1
How did you install Swagger-UI? embedded in swagger-tools module
Which browser & version? Safari Version 11.0 (12604.1.38.1.7)
Which operating system? macOS Sierra Version 10.12.6 (16G29)

Demonstration API definition

accessTokenReq:
    type: object
    properties:
      grant_type:
        enum:
          - client_credentials
      client_id:
        type: string
      client_secret:
        type: string

Expected Behavior

Rendered by UI:

Example section: { "grant_type": "client_credentials", "client_id": "string", "client_secret": "string" } Model section accessTokenReq { grant_type  = ['client_credentials'], client_id | string client_secret | string }

Current Behavior

Rendered by UI:

Example section: { "client_id": "string", "client_secret": "string" } Model section accessTokenReq { grant_type { } client_id | string client_secret | string }

Possible Solution

Context

Updated 16/10/2017 18:59 1 Comments

Widgets seem to say forbidden if viewed from different riot version (develop/staging/stable)

vector-im/riot-web

Description

I added a etherpad in #riotweb-translations:matrix.org via Riot develop. It works for me and some other but not for others in the room. The link itself works.

Steps to reproduce

  • Create a Etherpad widget via riot.im/develop
  • View it from staging or stable

Users see a permission denied error from scalar and not the widget.

Log: not sent

Version information of widget creator

  • Platform: web

For the web app:

  • Browser: Chrome
  • OS: Windows 10
  • URL: riot.im/develop

Version information of viewer

  • URL: riot.im/develop / riot.im/app / riot.im/staging
Updated 16/10/2017 17:18 5 Comments

"Cannot connect media" in voice call between regular Android clients

vector-im/riot-android

Android 7 “Nougat” (LG G5) <-> Android 6 “Marshmallow” (Moto G 2), Call “connecting” but abruptly ends before it can begin, citing “could not connect media”. Calls between two Nougat devices (LG G5 and Xperia Z4) seemed fine. Wondering if it was depending on something from Nougat, was RAM limited by Moto G2’s 1GB RAM, or both?

*Both devices were running 0.7.03 from Play Store.

Updated 16/10/2017 06:19

DateCreated for Rules should be maintained by the server and not modifiable by the client.

Azure/device-telemetry-java

Type of issue

<!– Please put an x without spaces (e.g. [x]) in all the boxes that apply: –> - [x] Bug - [ ] New feature - [ ] Enhancement

Description

<!– Please provide a succinct description –> The DateCreated field can be modified by the client, this should be maintained by the server.

Possible solution

<!– If you have a suggestion please describe how the issue could be solved –> The DateCreated field should be pulled from the StorageClient for existing Rules.

Updated 13/10/2017 21:08

[checkstyle] Resolve issues

AzureAD/azure-activedirectory-library-for-android

checkstyle reports the following unresolved issues as of 1.13.2

2017-10-13T18:11:23.2486689Z :adal:checkstyle[ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AcquireTokenRequestTest.java:336:72: warning: ',' is not followed by whitespace.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthenticationActivityUnitTest.java:93:59: warning: Variable 'mActivityRule' must be private and have accessor methods.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthenticationContextTest.java:38:8: warning: Unused import - android.support.v4.hardware.fingerprint.FingerprintManagerCompat.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthenticationContextTest.java:1266:48: warning: '3' is a magic number.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthenticationContextTest.java:1345:48: warning: '3' is a magic number.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthenticationContextTest.java:1478:47: warning: '8' is a magic number.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:65:60: warning: '5' is a magic number.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:99:37: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:100:21: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:101:73: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:102:63: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:103:34: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:104:50: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:105:42: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:106:44: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:107:41: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:108:21: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:109:22: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:110:21: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:111:72: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:112:70: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:113:34: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:114:48: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:115:21: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\AuthorityValidationMetadataCacheTest.java:116:21: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\BrokerAccountServiceTest.java:76:28: warning: Variable 'mServiceTestRule' must be private and have accessor methods.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\StorageHelperTests.java:295:17: warning: Name 'testKeyPair_AndroidKeyStore' must match pattern '^[a-z][a-zA-Z0-9]*$'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\Util.java:140:142: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\Util.java:141:68: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\androidTest\java\com\microsoft\aad\adal\Util.java:142:74: warning: '+' should be on a new line.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AcquireTokenRequest.java:60:28: warning: Name 'mHandler' must match pattern '^[s][a-zA-Z0-9]*$'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:320:9: warning: Missing a Javadoc comment.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:495:41: warning: Name 'sPrefix' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:497:13: warning: Missing a Javadoc comment.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:499:13: warning: Missing a Javadoc comment.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:501:13: warning: Missing a Javadoc comment.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:503:13: warning: Missing a Javadoc comment.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthenticationConstants.java:527: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\AuthorityValidationMetadataCache.java:43:1: warning: Utility classes should not have a public or default constructor.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\BrokerProxy.java:366:111: warning: '{' is not preceded with whitespace.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\BrokerProxy.java:465:108: warning: '{' is not preceded with whitespace.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\DRSMetadata.java:36: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\Discovery.java:70:22: warning: 'static' modifier out of order with the JLS suggestions.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\IdentityProviderService.java:38: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\JWSBuilder.java:62: warning: Class Claims should be declared as final.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\JWSBuilder.java:72: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\JWSBuilder.java:83: warning: Class JwsHeader should be declared as final.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\JWSBuilder.java:93: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\Link.java:47: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\PowerManagerWrapper.java:35:32: warning: Variable 'sInstance' must be private and have accessor methods.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\PowerManagerWrapper.java:54:51: warning: Expected @param tag for 'connectionContext'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\PowerManagerWrapper.java:64:65: warning: Expected @param tag for 'connectionContext'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\SSOStateSerializer.java:65: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\TokenCacheAccessor.java:116:25: warning: ')' is preceded with whitespace.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\TokenCacheAccessor.java:233:136: warning: '{' is not preceded with whitespace.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\UsageStatsManagerWrapper.java:35:37: warning: Variable 'sInstance' must be private and have accessor methods.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\UsageStatsManagerWrapper.java:54:48: warning: Expected @param tag for 'connectionContext'.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\main\java\com\microsoft\aad\adal\WebFingerMetadata.java:49: warning: First sentence should end with a period.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\telemetry\java\com\microsoft\aad\adal\TelemetryUtils.java:50:32: warning: 'mVersion' hides a field.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\telemetry\java\com\microsoft\aad\adal\TelemetryUtils.java:58:40: warning: 'mServerErrorCode' hides a field.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\telemetry\java\com\microsoft\aad\adal\TelemetryUtils.java:66:43: warning: 'mServerSubErrorCode' hides a field.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\telemetry\java\com\microsoft\aad\adal\TelemetryUtils.java:74:40: warning: 'mRefreshTokenAge' hides a field.
2017-10-13T18:11:23.2486689Z [ant:checkstyle] E:\ag\_work\25\s\adal\src\telemetry\java\com\microsoft\aad\adal\TelemetryUtils.java:82:32: warning: 'mSpeRing' hides a field.
Updated 13/10/2017 18:27

Suggestion for improved "Groups you're a member of"

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

Here’s what it currently looks like: image

The list feels not as warm/fuzzy as it could be. What are people’s thoughts on the following? image

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 16/10/2017 08:53 1 Comments

ACL Documentation and Reference information improvements

hyperledger/composer

System ACL information on Hyperledger Composer Access Control Language is confusing/incomplete. Some sort of table to show which permissions are required might help, and more examples would be useful, as would a link to the system model. (I was unable to create system ACL rules which worked correctly in the playground.) We need more information and a restructure of the ACL documentation we have as well as practical examples for combinations of ACLs. For example we now have a whole list of system resources in system.cto that users may want to put ACL restrictions on but we don’t document these resources or what in practical terms are sensible restrictions or what would break if you try to restrict these things. Our samples generally give all participants full access to all system resources but is that a good thing ?

Updated 16/10/2017 09:25

Extensions not being ignored properly by editor

swagger-api/swagger-ui

<!— Thanks for filing an issue 😄 ! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have asked the same thing before!

Issues on GitHub are only related to problems of Swagger-Editor itself. We’ll try to offer support here for your use case, but we can’t offer help with projects that use Swagger-UI indirectly, like Springfox or swagger-node.

If your issue has to do with the right-hand side of the Editor, you’re likely talking about Swagger-UI. Please file your issue there instead: https://github.com/swagger-api/swagger-ui/issues/new

Likewise, we can’t accept features or bugs within the Swagger/OpenAPI specifications themselves, or anything that violates the specifications.

–> As you will see with the provided evil, but valid swagger, there a number of things done incorrectly due to extensions not being properly ignored and being parsed as things like paths or responses. editor.swagger.io parses and validates the swagger, but shows things like “x-an-extension-fake-path” as paths rather than ignoring them as they are extensions. editor2.swagger.io fails to even parse the swagger document as it tries to read extensions as a variety of different object types instead of ignoring them (for example the following error seems to be due to trying to read path.consumes from an extension which is null or a primative. ✖ Unknown Error Cannot read property 'consumes' of undefined

<!— Provide a general summary of the issue in the title above –>

Q A
Bug or feature request? bug
Which Swagger/OpenAPI version? 2.0
Which Swagger-Editor version? editor.swagger.io and editor2.swagger.io as of 13/10/2017
Which browser & version? chrome 61
Which operating system? windows 10

Demonstration API definition

https://gist.github.com/alasdairhurst/a1073a85d3df4bc800e143a4d31dd168

Expected Behavior

<!— If you’re describing a bug, tell us what should happen –> <!— If you’re suggesting a change/improvement, tell us how it should work –> Swagger document is parsed correctly. Extensions are not displayed as paths, responses or any other type of object.

Current Behavior

<!— If describing a bug, tell us what happens instead of the expected behavior –> <!— If suggesting a change/improvement, explain the difference from current behavior –> extensions are not ignored by whatever is parsing the swagger, and the UI displays extensions as paths.

Possible Solution

<!— Not obligatory, but suggest a fix/reason for the bug, –> <!— or ideas how to implement the addition or change –> Extensions should be ignored in every location that they are allowed. They should not be parsed as, or show up as parameters, paths, responses and any other types of object. The provided swagger document should parse correctly and not display and extensions. It should also display all parameters and paths as expected.

Context

<!— How has this issue affected you? What are you trying to accomplish? –> <!— Providing context helps us come up with a solution that is most useful in the real world –> Tried to make a swagger for my own project which would allow project developers to find issues with the way swagger is handled. Instead, found issues with the official tools.

Updated 16/10/2017 19:57 3 Comments

Issue with k8s.io/docs/tutorials/kubernetes-basics/explore-interactive/

kubernetes/kubernetes.github.io

<!– Thanks for filing an issue! Before submitting, please fill in the following information. –>

<!–Required Information–>

This is a… <!– choose one by changing [ ] to [x] –> - [ ] Feature Request - [x] Bug Report

Problem:

In the third tutorial, it first asks to make sure the previous application was running and it wasn’t. I tried twice (went back, restarted 2nd, restarted 3rd, no dice).

Proposed Solution:

I don’t think whatever sessions mechanism is being retained between interactive tutorials.

Page to Update: http://kubernetes.io/…

<!–Optional Information (remove the comment tags around information you would like to include)–> <!–Kubernetes Version:–>

<!–Additional Information:–>

Updated 13/10/2017 16:35 2 Comments

Maximizing an always on top transparent frameless window causes the bottom to overflow under the taskbar

nwjs/nw.js

NWJS Version : SDK 26.0 beta 1 Operating System : Win7 x64

Expected behavior

The bottom of the window should not go under the taskbar when maximized.

Actual behavior

The bottom of the window goes under the taskbar when maximized.

How to reproduce

Basic app template with window frame set to false, transparent set to true and always_on_top set to true Maximize app and check the bottom of the window under the windows taskbar

Resulting behavior illustrated:

ss

Expected behavior:

ss

Updated 16/10/2017 05:28 7 Comments

Replace FwLinks with the actual target links

dotnet/docs

This is a good issue for people who want to learn how to work on open-source projects.

Our content uses a lot of what we call FwLinks links. Current search brings 2,639 results for FwLink links.

The problem with those is that users have no clue to which site we’re taking them if they hover the link with their mouse and also they can only be updated by employees. They were useful back in the day where we could only publish once every couple of weeks or sometimes even months.

We should keep links to downloads intact though.

For people interested in helping with this task, we’d break it down into much smaller issues (like 5-10 links per PR).

Sub-issues: - [ ] Core and F# folders - #3423 - [ ] C# folder - #3424 - [ ] Standard folder - #3425 - [ ] VB folder - #3426

Updated 16/10/2017 23:55 18 Comments

Issue with k8s.io/docs/admin/authentication/

kubernetes/kubernetes.github.io

<!– Thanks for filing an issue! Before submitting, please fill in the following information. –>

<!–Required Information–>

This is a… <!– choose one by changing [ ] to [x] –> - [ ] Feature Request - [x] Bug Report

Problem: In “Anonymous requests” section, there is a sentence following. In 1.5.1-1.5.x, anonymous access is disabled by default, and can be enabled by passing the --anonymous-auth=false option to the API server.

Is --anonymous-auth=false correct for enabling anonymous auth? It should be --anonymous-auth=true, I think.

Proposed Solution:

Change --anonymous-auth=false to --anonymous-auth=true in sentence for enabling anonymous access option of 1.5.1-1.5.x

Page to Update: https://kubernetes.io/docs/admin/authentication/#anonymous-requests

<!–Optional Information (remove the comment tags around information you would like to include)–> <!–Kubernetes Version:–>

<!–Additional Information:–>

Updated 13/10/2017 06:04

root-dir flag does not error if unspecified

googleapis/artman

What

If the root-dir flag is neither specified on the command line nor found in the artman user config file, an error should be raised.

Why

This is the intended behavior according to https://github.com/googleapis/artman/blob/8764b7994bbb1357ff7f1630bf2e2d7d569224ea/artman/cli/main.py#L145. If no error is raised, confusing errors may occur later in execution.

Updated 12/10/2017 22:59

[meta.trans.other] Simplifying the specification of common_reference and common_type

ericniebler/stl2

common_reference and common_type both uses COMMON_REF, but:

  • common_type only uses it with decayed types, so it can only ever use the last bullet.
  • common_reference only uses it on reference types, and only if the result is also a reference type, hence the last bullet, which always returns a decayed, non-reference type, is useless to it.

It would probably be cleaner to split the last bullet into its own macro, or even inline it directly into the only place it is used in common_type’s specification.

If we do that, then COMMON_REF is only used by common_reference, and only when the result is a reference type. Thus, if the result would not be a reference type, we might as well just make COMMON_REF fail. If we tweak the first bullet to fail if the result of COND_RES is not a reference, then we can simplify RREF_RES by removing the conditional, and easily inline it at its single use site if desired.

This basically sketches what I have in mind. My “simple common reference type” is COMMON_REF.

Updated 13/10/2017 19:56

Operation.service is inconsistent nomenclature

carbon-io/carbond

The service property on Collection, Endpoint, etc. refers to the parent Service class. However on Operation it is the handler method for the operation. To keep it consistent, the handler should be named something else (say opHandler) and Operation.service should refer to the parent Service.

Thoughts?

Updated 13/10/2017 17:34

"Only server admin can create group on this server" seems to be missing an 's' or 'the'

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

The intent is clear, but the message is a bit hard to read. Maybe “Only the server admins can create groups on this server” was intended?

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 16/10/2017 08:52 1 Comments

allow as few as two answers

drewrehfeld/opened

when instructor is creating the quiz, they should be able to have as few as two answers. also, the radio buttons should not show for any answer that is not completed. previously, i was able to create questions with just True and False answers, but the radio button would still show for the blank answers. now, it is not allowing me to create questions with only two answers at all.

screen shot 2017-10-12 at 11 28 36 am

Updated 12/10/2017 18:31

grpc version mismatch for composer modules

hyperledger/composer

For composer dependencies we have locked to fabric-client v1.0.1 which uses grpc 1.2.4. However we have specified grpc 1.6.0 in our dependencies (although composer doesn’t directly use grpc) which is there to get around fabric-ca-client not explicitly declaring it’s grpc level.

We should change our fabric-client dependencies to 1.0.2 to address this.

Updated 17/10/2017 08:03

Exception raised when processing __virtual__ function for salt.loaded.int.module.boto_elbv2. Module will not be loaded

saltstack/salt

Description of Issue/Question

In salt minion logs I see: 2017-10-12 12:26:16,832 [salt.utils.lazy ][DEBUG ][4571] LazyLoaded boto3.assign_funcs 2017-10-12 12:26:16,832 [salt.loader ][DEBUG ][4571] Error loading module.boto_elasticsearch_domain: __init__ failed Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1464, in _load_module module_init(self.opts) File "/usr/lib/python2.7/dist-packages/salt/modules/boto_elasticsearch_domain.py", line 135, in __init__ __utils__['boto3.assign_funcs'](__name__, 'es') File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1113, in __getitem__ func = super(LazyLoader, self).__getitem__(item) File "/usr/lib/python2.7/dist-packages/salt/utils/lazy.py", line 98, in __getitem__ return self._dict[key] KeyError: 'boto3.assign_funcs' 2017-10-12 12:26:16,833 [salt.utils.lazy ][DEBUG ][4571] LazyLoaded boto3.assign_funcs 2017-10-12 12:26:16,833 [salt.loader ][ERROR ][4571] Exception raised when processing __virtual__ function for salt.loaded.int.module.boto_elbv2. Module will not be loaded: 'boto3.assign_funcs' Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1672, in process_virtual virtual = getattr(mod, virtual_func)() File "/usr/lib/python2.7/dist-packages/salt/modules/boto_elbv2.py", line 71, in __virtual__ __utils__['boto3.assign_funcs'](__name__, 'elbv2') File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1113, in __getitem__ func = super(LazyLoader, self).__getitem__(item) File "/usr/lib/python2.7/dist-packages/salt/utils/lazy.py", line 98, in __getitem__ return self._dict[key] KeyError: 'boto3.assign_funcs' 2017-10-12 12:26:16,833 [salt.loader ][WARNING ][4571] salt.loaded.int.module.boto_elbv2.__virtual__() is wrongly returning `None`. It should either return `True`, `False` or a new name. If you're the developer of the module 'boto_elbv2', please fix this.

Versions Report

# salt --versions-report
Salt Version:
           Salt: 2017.7.1

Dependency Versions:
           cffi: 1.9.1
       cherrypy: 3.2.2
       dateutil: 2.4.2
      docker-py: Not Installed
          gitdb: 0.6.3
      gitpython: 0.3.4
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: 0.21.1
           Mako: 0.9.1
   msgpack-pure: Not Installed
 msgpack-python: 0.3.0
   mysql-python: 1.2.3
      pycparser: 2.17
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.6 (default, Oct 26 2016, 20:30:19)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 14.4.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.0.4

System Versions:
           dist: Ubuntu 14.04 trusty
         locale: UTF-8
        machine: x86_64
        release: 3.13.0-115-generic
         system: Linux
        version: Ubuntu 14.04 trusty
Updated 12/10/2017 18:29 1 Comments

Filename errors render behind the codemirror in Firefox

hyperledger/composer

To Recreate: Edit the name of a model file, and introduce some invalid characters. Then click off the editing field.

Results: In Chrome, you get error text displayed between the box and the codemirror. This is good: image

Same in Safari: looks good.

In Firefox, that error renders behind the code mirror, so you can’t see it. This is bad: image

Haven’t been able to test in other browsers.

Fix: Gotta get that error message visible on Firefox!

Updated 13/10/2017 09:15 1 Comments

Compile WebWorkers with nwjc and load them

nwjs/nw.js

It would be great if the WebWorkers could be protected with nwjc and loaded from protected nwjc content. This way there could be protected code running in the background of the application not affecting the GUI or other components.

If you need any help testing this. let me know!

NWJS Version : Actual Operating System : Both

Expected behavior

Load a compiled .bin with WebWorker and run it.

Actual behavior

Unable to load WebWorker files that are not .js files

How to reproduce

Try loading a compiled nwjc file with new Worker('compiled.bin')

Updated 16/10/2017 05:31

virt module generates macs in private range

saltstack/salt

Description of Issue/Question

Virt module generates macs in private range (instead of KVM range). This makes it hard to identify KVM VMs with their mac.

Setup

Creating a KVM vm with: test01: virt.running: - cpu: 2 - mem: 2048 - image: salt://images/foo.qcow2

Steps to Reproduce Issue

Created VM will have a generated mac like: virsh dumpxml test01|grep -A7 interface

<interface type='bridge'>
  <mac address='AC:DE:48:c1:18:c6'/>
  <source bridge='br0'/>
  <target dev='vnet6'/>
  <model type='virtio'/>
  <alias name='net0'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>

Versions Report

develop

Updated 12/10/2017 18:18 1 Comments

[Table] Shift-click to expand selection is buggy when not focused in last-selected region

palantir/blueprint

<!– Is this a support question? Please post to Stack Overflow with the “blueprintjs” tag instead. –> <!– Delete this template for feature requests. –>

Bug report

  • Package version(s): <!– fill this out –>
  • Browser and OS versions: <!– fill this out –>

Steps to reproduce

With allowMultipleSelection=true:

  1. Cmd/Ctrl + Click to select a few disjoint regions.
  2. Tab/Shift + Tab/Enter/Shift + Enter to move from the last-selected region to another one.
  3. Shift + Click to expand the focused region.

Actual behavior

The last-selected region is cleared and replaced with a region that has been expanded from the focused cell.

2017-10-12 00 31 42

Expected behavior

Only the focused region is affected:

2017-10-12 00 34 42

Updated 12/10/2017 07:35

Issue with k8s.io/docs/setup/independent/create-cluster-kubeadm/

kubernetes/kubernetes.github.io

<!– Thanks for filing an issue! Before submitting, please fill in the following information. –>

<!–Required Information–>

This is a… <!– choose one by changing [ ] to [x] –> - [ ] Feature Request - [ ] Bug Report

Problem: I have installed k8s v 1.8. I have installed on centos7. everything went fine as per doc but when i reboot server then im keep getting this error" the connection to the server 127.0.0.1:8080 was refused - did you specify the right host or port?“ https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/

Please help on it because it is annoying a lot and i cant proceed for next steps. i saw several post online but nothing is helpful. Proposed Solution:

Page to Update: http://kubernetes.io/…

<!–Optional Information (remove the comment tags around information you would like to include)–> <!–Kubernetes Version:–> 1.8 <!–Additional Information:–>

Updated 13/10/2017 21:05 4 Comments

Add back support for Go 1.6

grpc/grpc-go

If the cost is pretty low, could you add it back?

Go 1.8 isn’t the default on GAE yet (but will be soon)

Go 1.6 will continue to be available (opt-in) for at least several months, and the Cloud teams need to continue support for 1.6 for several packages that depend on gRPC. This complicates things for customers, as they’ll need to pin to the last version of grpc-go that supported 1.6.

Updated 16/10/2017 18:24 8 Comments

Confusing error message when a custom repository_rule fails

bazelbuild/bazel

Please provide the following information. The more we know about your system and use case, the more easily and likely we can help.

Description of the problem / feature request / question:

When a custom repository_rule fails, bazel displays something like:

ERROR: /path/to/BUILD:1:1: no such package '@my_custom_repository//':

The no such package part is very confusing, because there is such package, just it fails.

Something like error loading package will be much more clear?

I spent an afternoon trying to figure out why my custom repository rule implementation function isn’t executed because I thought no such package means it cannot find the package that is supposed to be provided by the custom repository rule. Then I finally realized that the function is indeed executed, it just fails.

If possible, provide a minimal example to reproduce the problem:

./WORKSPACE:

load("//:custom_repository.bzl", "custom_repository")

custom_repository(name="my_custom_repository")

./custom_repository.bzl:

def _custom_repository_impl(repository_ctx):
  fail("...")

custom_repository = repository_rule(
    implementation = _custom_repository_impl,
)

./BUILD:

cc_library(
    name = "shim",
    deps = ["@my_custom_repository//:lib"],
)

Run bazel build :shim, it produces something like:

ERROR: /path/to/BUILD:1:1: no such package '@my_custom_repository//': ... and referenced by '//:shim'.

Environment info

  • Operating System: macOS 10.12.6

  • Bazel version (output of bazel info release): release 0.6.1-homebrew

Updated 17/10/2017 07:37 2 Comments

Cannot expand/collapse RHS when editing a group

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

I often have the RHS collapsed because of my monitor layout. The RHS cannot be opened from the edit groups page, making it hard to invite then feature someone in one action.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 14:36 2 Comments

No way to promote/demote people in a group

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

This is particularly needed if someone creates a group by accident and wants to hand it off to someone else. In my case, I removed myself from the group, leaving my other account stuck with a group they can’t manage. I should be able to promote people using power levels or similar.

Would be even nicer if multiple people could be at the same level.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:54

Flair is cached for too long

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

After about 30 minutes, it seemed to updated. It should update in more real time.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:51 3 Comments

If no rooms, RHS feels too empty

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

Something like “There are no groups, consider adding one below”.

<!– Include screenshots if possible: you can drag and drop images below. –>

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:48

Clicking on a group member on the RHS puts loading icon above panel header

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

It should probably be the other way around

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:47

Hide panel button has a significant clickable area on groups RHS

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

The entire area highlighted in red is clickable. This should be much smaller.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:46 1 Comments

No obvious way to go back to group dashboard from looking at a group

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

This is only awkward for when you’re looking to manage several groups at a time. It’d be nice to be able to do that from the top of the screen instead of having to travel to the bottom left and click the groups icon again.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome, 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:46

Bright line under group header inconsistent with other elements

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

Other elements in the dark theme use a more faded line. A similar concept should be used here.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:43

Purple invite hard to see on dark theme

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

A slightly lighter color would be nice.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:38 1 Comments

No hover effect on group members (RHS)

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

The cursor changes, but it feels too different from how room members work. A similar effect (if not the same) would be nice.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:37 1 Comments

Buttons for leave/publish group feel too far away and large

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

image

The buttons could probably be made smaller, align better with the text, and be closer so they don’t appear completely unrelated.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:27

docker_container.running states fail if the argument ulimits is set and a watch requisite is triggered

saltstack/salt

Description of Issue/Question

docker_container.running states fail if the argument ulimits is set and a watch requisite is triggered.

Setup

docker_ulimits_test.sls ``` always-changes-and-succeeds: test.succeed_with_changes

redis: docker_container.running: - image: redis:alpine - ulimits: - nofile=10000:10000 - watch: - test: always-changes-and-succeeds ```

Steps to Reproduce Issue

  1. first run of salt-call state.apply docker_ulimits_test works fine. it creates and starts the docker container redis.
  2. the second run of salt-call state.apply docker_ulimits_test fails: ``` [INFO ] Loading fresh modules for state activity [INFO ] Fetching file from saltenv ‘base’, done ‘docker_ulimits_test.sls’ [INFO ] Running state [always-changes-and-succeeds] at time 16:11:46.530969 [INFO ] Executing state test.succeed_with_changes for [always-changes-and-succeeds] [INFO ] Made the following changes: ‘testing’ changed from ‘Unchanged’ to ‘Something pretended to change’

[INFO ] Completed state [always-changes-and-succeeds] at time 16:11:46.532644 duration_in_ms=1.674 [INFO ] Running state [redis] at time 16:11:46.560269 [INFO ] Executing state docker_container.running for [redis] [ERROR ] Container ‘redis’ is already configured as specified. Failed to start container ‘redis’: ‘Error 500: oci runtime error: container_linux.go:262: starting container process caused “process_linux.go:339: container init caused \"process_linux.go:289: setting rlimits for ready process caused \\"error setting rlimit type 7: invalid argument\\”\“” ’. [INFO ] Completed state [redis] at time 16:11:47.012841 duration_in_ms=452.575 [INFO ] Running state [redis] at time 16:11:47.013087 [INFO ] Executing state docker_container.mod_watch for [redis] [ERROR ] Failed to translate input. Additional info follows:

invalid: ———- ulimits: Ulimit definition ‘{'Hard’: 10000, ‘Soft’: 10000, ‘Name’: ‘nofile’}‘ is not in the format type=soft_limit[:hard_limit]

If you feel this information is incorrect, the skip_translate argument can be used to skip input translation for the argument(s) identified as invalid. See the documentation for details. [INFO ] Completed state [redis] at time 16:11:47.039872 duration_in_ms=26.783

local:

      ID: always-changes-and-succeeds
Function: test.succeed_with_changes
  Result: True
 Comment: Success!
 Started: 16:11:46.530970
Duration: 1.674 ms
 Changes:   
          ----------
          testing:
              ----------
              new:
                  Something pretended to change
              old:
                  Unchanged

      ID: redis
Function: docker_container.running
  Result: False
 Comment: Failed to translate input. Additional info follows:

          invalid:
              ----------
              ulimits:
                  Ulimit definition '{'Hard': 10000, 'Soft': 10000, 'Name': 'nofile'}' is not in the format type=soft_limit[:hard_limit]

          If you feel this information is incorrect, the skip_translate argument can be used to skip input translation for the argument(s) identified as invalid. See the documentation for details.
 Started: 16:11:47.013089
Duration: 26.783 ms
 Changes:   

Summary for local

Succeeded: 1 (changed=1)

Failed: 1

Total states run: 2 Total run time: 28.457 ms ```

if the suggested argument skip_translate: ulimits is added the docker_container.running state, the state fails always with: ID: redis Function: docker_container.running Result: False Comment: Unable to perform create_host_config: type object argument after ** must be a mapping, not str Started: 16:24:01.875622 Duration: 50.406 ms Changes:

Versions Report

Salt Version:
           Salt: 2017.7.2

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.4.2
      docker-py: 2.4.2
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: Ubuntu 16.04 xenial
         locale: UTF-8
        machine: x86_64
        release: 4.4.0-96-generic
         system: Linux
        version: Ubuntu 16.04 xenial
Updated 12/10/2017 18:05 1 Comments

Clicking on a user in a group should show me other groups I share with them

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

Currently it brings up a start chat dialog, which is a bit weird. Maybe show a profile page of sorts?

The profile page could be: * Groups they are in * Groups I share with them * Start chat button

<!– Include screenshots if possible: you can drag and drop images below. –>

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 14:52 2 Comments

Add indication of search results loading to users

loconomics/loconomics

Description

Currently, searches can take a few seconds and meanwhile two things occur: - past results show (from a different job title or city) - no results appear (referral cards still appear) Users may get the impression we have no results or could get confused seeing unrelated results.

To-do

  • clear cache of previous results
  • Implement loading icon with motion (the one we currently use) centered with text below it that says “One moment please”
Updated 11/10/2017 16:11

Should be able to click a group avatar to edit it (like with rooms)

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

When in a room, a user can click the avatar to edit the avatar and other settings. This functionality should be introduced to groups too.

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:18 1 Comments

Default group icon based off of alias instead of name

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

This feels awkward as rooms are the other way around.

+coolkids with display name “My Cool Group” should be an M.

<!– Include screenshots if possible: you can drag and drop images below. –>

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
Updated 12/10/2017 10:17 1 Comments

Dynamic Content in Email showing {leadfield=firstname} AND {contactfield=firstname}

mautic/mautic

What type of report is this: Bug

Q A
Bug report? Yes
Feature request? No
Enhancement? No

Description:

When editing Dynamic Content in email and adding “Hi {firstname}”, it is showing this as a leadfield but this should be contactfield NOT leadfield.

If a bug:

Q A
Mautic version
PHP version

Steps to reproduce:

  1. In an email, add dynamic content.
  2. Use token “first name” and see leadfield and contactfield….should only be contactfield

Log errors:

Please check for related errors in the latest log file in [mautic root]/app/log/ and/or the web server’s logs and post them here. Be sure to remove sensitive information if applicable.

Updated 11/10/2017 15:46

A message is displayed twice whereas it has been sent once

vector-im/riot-android

reported by @akleine:jcg.re https://github.com/matrix-org/riot-android-rageshakes/issues/1256 already submitted one concerning this Problem, but here u can See what i mean,it looks like the messages are sent twice when in reality as soon as you leave the chatroom and reenter it, the messages are displayed normally (pls excuse my bad English)

Updated 11/10/2017 11:51

The action of deleting was not correct

Microsoft/pxt-adafruit

Repro step: •Navigate to https://makecode.adafruit.com/beta •Drag the block “on button A click” to the content panel •Drag the block “on button A click” to the space of simulator when drag it to “Delete” •Drag the block at the space of simulator until it can’t be moved to left any more at some place

Expected result: The block was deleted when free the click button of mouse Actual result: The block was not deleted when free the click button of mouse, and it moved with the mouse

deletemovewithmouse

Updated 16/10/2017 22:33

The dragged block was not under the control of mouse

Microsoft/pxt-adafruit

Repro step: •Navigate to https://makecode.adafruit.com/beta •Put the block “forever” just close to the editor •Drag the block “show ring” to the content panel •Drag the block “show ring” to the “Delete”

Expected result: The dragged block was under the control of mouse Actual result: The dragged block was not under the control of mouse, the block “show ring” and “forever” all moved to the left a little

delete-move

Updated 16/10/2017 22:33

Issue with k8s.io/docs/tutorials/kubernetes-basics/cluster-interactive/

kubernetes/kubernetes.github.io

<!– Thanks for filing an issue! Before submitting, please fill in the following information. –>

<!–Required Information–>

This is a… <!– choose one by changing [ ] to [x] –> - [ ] Feature Request - [X] Bug Report

Problem: Tutorial step indicates both server and version are 1.5. Running kubectl version, as requested by the same tutorial, shows a server with version 1.8 and a client with version 1.5.

Proposed Solution: Amend the tutorial text.

Page to Update: http://kubernetes.io/kubernetes-basics/cluster-interactive/

<!–Optional Information (remove the comment tags around information you would like to include)–> <!–Kubernetes Version:–>

<!–Additional Information:–>

Updated 12/10/2017 09:15 3 Comments

Define scope of XMI generation

jasonvan/prexel
  • Are we going to need to make our own graphic generator? If so, how should is display see #1
  • Make export possible to other tools ( using valid UML 2.0 and XMI 2.1 )
  • Remember we aren’t trying, nor do we need to, implement everything in the spec
Updated 11/10/2017 04:15

Prueba de sincronía entre schema.sql y los scripts de migración

omegaup/omegaup

Actualmente si se ejecutan todos los scripts de migración, el resultado debería ser equivalente a correr schema.sql, pero no tenemos ningún mecanismo que se asegure que esto sea cierto. Deberíamos tener una prueba en Travis que, haciendo un dump del esquema de la base de datos después de aplicar los scripts de migración, este dump debería ser idéntico a schema.sql.

Updated 15/10/2017 01:38

changing webkit app region is not taking effect until the app repaints

nwjs/nw.js

NWJS Version : SDK 26.0beta1 Operating System : Win7 x64

Expected behavior

When setting or unsetting the -webkit-app-region: drag on an element the app should be draggable when dragging that element or stop dragging when the property is unset.

Actual behavior

The property change only takes effect when there is a full page repaint. (i.e. font-family change, window resize, etc.)

How to reproduce

With a basic template containing a simple HTML page and the window set to frameless, open the developer tools and set the css attribute -webkit-app-region: drag for the html or body element. Try to drag the window by dragging the body element on that page and it will not drag. Resize the app window and try dragging again, the page will now drag. Unset/remove that property and drag the window again, it keeps dragging when it shouldn’t since the property is no longer enabled. Resize the app window and try dragging again, the page will now no longer drag.

Updated 16/10/2017 06:01 3 Comments

client does not recover after bad server certificate

grpc/grpc-go

Please answer these questions before submitting your issue.

What version of gRPC are you using?

  revision = "f92cdcd7dcdc69e81b2d7b338479a19a8723cfa3"
  version = "v1.6.0"

What version of Go are you using (go version)?

go version go1.9 darwin/amd64

What operating system (Linux, Windows, …) and version?

darwin and linux

What did you do?

If possible, provide a recipe for reproducing the error. 1) Create a grpc client which uses TLS: creds := credentials.NewTLS(&tls.Config{ ServerName: server.acme.co, }) grpc.WithTransportCredentials(creds)

2) have the server initially use the correct certificate, but then start issuing a bad one. In real life this corresponds to a wireless access point which MITM you for a short period. Finally serve the correct certificate again. The client fails to recover once the server connection is the correct one.

Logs: ``` 2017/10/10 22:13:42 Greeting: Hello world 2017/10/10 22:13:43 Greeting: Hello world 2017/10/10 22:13:44 Greeting: Hello world // start serving bad cert

2017/10/10 22:13:45 could not greet: rpc error: code = Internal desc = connection error: desc = “transport: authentication handshake failed: x509: certificate is valid for not.acme.co:8443, not server.acme.co” 2017/10/10 22:13:46 could not greet: rpc error: code = Internal desc = connection error: desc = “transport: authentication handshake failed: x509: certificate is valid for not.acme.co:8443, not server.acme.co”

// start serving good cert again 2017/10/10 22:13:49 could not greet: rpc error: code = Internal desc = connection error: desc = “transport: authentication handshake failed: x509: certificate is valid for not.acme.co:8443, not server.acme.co” 2017/10/10 22:13:50 could not greet: rpc error: code = Internal desc = connection error: desc = “transport: authentication handshake failed: x509: certificate is valid for not.acme.co:8443, not server.acme.co” // … client never recovers ```

zip file attached with reproducible code. The certs/connection assume server.acme.co is localhost which you will need to set in /etc/hosts grpc_repro.zip playground main.go without certs/setup

Updated 13/10/2017 20:33 3 Comments

Fork me on GitHub