Contribute to Open Source. Search issue labels to find the right project for you!

use runtime.CallersFrames instead of runtime.Callers

cockroachdb/cockroach

http://talks.godoc.org/github.com/davecheney/go-1.9-release-party/presentation.slide#20

[tschottdorf@macts-2 cockroach (node-info)]$ git grep runtime.Caller
pkg/storage/timedmutex.go:                      if pc, _, _, ok := runtime.Caller(2); ok {
pkg/storage/track_raft_protos.go:               if numCallers := runtime.Callers(0, pcs[:]); numCallers == len(pcs) {
pkg/storage/track_raft_protos.go:               frames := runtime.CallersFrames(pcs[:])
pkg/util/caller/resolver.go:// A CallResolver is a helping hand around runtime.Caller() to look up file,
pkg/util/caller/resolver.go:// it's unable to look up its own location via runtime.Caller().
pkg/util/caller/resolver.go:    _, file, _, ok := runtime.Caller(0)
pkg/util/caller/resolver.go:    pc, file, line, ok := runtime.Caller(depth + 1)
pkg/util/caller/resolver.go:                    // "path/filepath" because runtime.Caller always returns unix paths.
pkg/util/caller/resolver_test.go:               // NB: runtime.Caller always returns unix paths.
pkg/util/envutil/env.go:        _, consumer, _, _ := runtime.Caller(depth + 1)
pkg/util/log/clog.go:           if runtime.Callers(2+depth, logging.pcs[:]) == 0 {
pkg/util/log/test_log_scope.go: runtime.Callers(2, pcs[:])
pkg/util/log/test_log_scope.go: frames := runtime.CallersFrames(pcs[:])
pkg/util/smalltrace.go: nCallers := runtime.Callers(skip, pcs[:])
pkg/util/smalltrace.go: frames := runtime.CallersFrames(pcs[:])
Updated 20/08/2017 04:46

type inference of `@@GLOBAL.sql_mode` and `@@SESSION.sql_mode` is incorrect

pingcap/tidb

1. What did you do?

result type’s Collation and Type of @@GLOBAL.sql_mode and @@SESSION.sql_mode is incorrect

2. What did you expect to see?

MySQL > SELECT @@GLOBAL.sql_mode;
Field   1:  `@@GLOBAL.sql_mode`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       VAR_STRING
Collation:  utf8_general_ci (33)
Length:     411
Max_length: 137
Decimals:   31
Flags:


+-------------------------------------------------------------------------------------------------------------------------------------------+
| @@GLOBAL.sql_mode                                                                                                                         |
+-------------------------------------------------------------------------------------------------------------------------------------------+
| ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION |
+-------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)
MySQL > SELECT @@SESSION.sql_mode;
Field   1:  `@@SESSION.sql_mode`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       VAR_STRING
Collation:  utf8_general_ci (33)
Length:     411
Max_length: 137
Decimals:   31
Flags:


+-------------------------------------------------------------------------------------------------------------------------------------------+
| @@SESSION.sql_mode                                                                                                                        |
+-------------------------------------------------------------------------------------------------------------------------------------------+
| ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION |
+-------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

3. What did you see instead?

TiDB > SELECT @@GLOBAL.sql_mode;
Field   1:  `@@GLOBAL.sql_mode`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       STRING
Collation:  ? (0)
Length:     0
Max_length: 42
Decimals:   31
Flags:


+--------------------------------------------+
| @@GLOBAL.sql_mode                          |
+--------------------------------------------+
| STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION |
+--------------------------------------------+
1 row in set (0.00 sec)
TiDB > SELECT @@SESSION.sql_mode;
Field   1:  `@@SESSION.sql_mode`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       STRING
Collation:  ? (0)
Length:     0
Max_length: 42
Decimals:   31
Flags:


+--------------------------------------------+
| @@SESSION.sql_mode                         |
+--------------------------------------------+
| STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION |
+--------------------------------------------+
1 row in set (0.00 sec)

4. What version of TiDB are you using (tidb-server -V)?

$./bin/tidb-server -V
Release Version: 0.8.0
Git Commit Hash: 3e1728b4b853c224daa969fcc3d03be5d0860ef4
Git Commit Branch: master
UTC Build Time:  2017-08-19 12:33:06
Updated 19/08/2017 13:19

BooksBunker

pivorakmeetup/pivorak-web-app

Idea: Create closed (access limited) club for books reader (maybe not only technical). First rule of bunker: You know it very well :) How to get in: Share one of your e-book that' yet is not in bunker’s collection or buys and share one of the recommended books (list be available at the bunker’s entrance) Inside: All bunker’s members have access to download any book and share new books. Terms of use: Don’t share this books outside the bunker. All books must be legal. Only bought books could be shared in the bunker.

Technical side: https://pivorak.com/bb - WIP as engine.

TODO: - [x] 0. Bootstarb new BB component - [ ] 1. You make “knock” and share the book. - [ ] 2. Bunker’s admin decides to enter you or not. - [ ] 3. Inside bunker, you can add new books - [ ] 4. All books should be moderated. - [ ] 5. You can download any book. - [ ] 6. Bunker track all downloads and show some sort of statistic. - [ ] 7. Everyones happy

@denysmedynskyi @floor114 FYI

Updated 19/08/2017 10:43

Behavior of SYSDATE() is different from mysql

pingcap/tidb
  1. What did you do? If possible, provide a recipe for reproducing the error. SELECT SYSDATE(), SLEEP(1), SYSDATE(), SLEEP(2), SYSDATE();

  2. What did you expect to see? mysql> SELECT SYSDATE(), SLEEP(1), SYSDATE(), SLEEP(2), SYSDATE(); +---------------------+----------+---------------------+----------+---------------------+ | SYSDATE() | SLEEP(1) | SYSDATE() | SLEEP(2) | SYSDATE() | +---------------------+----------+---------------------+----------+---------------------+ | 2017-08-18 22:33:51 | 0 | 2017-08-18 22:33:52 | 0 | 2017-08-18 22:33:54 | +---------------------+----------+---------------------+----------+---------------------+ 1 row in set (3.01 sec)

  3. What did you see instead?

in TiDB SYSDATE() behaves the same as now(), it returns statement begin time but not execute time MySQL [(none)]> SELECT SYSDATE(), SLEEP(1), SYSDATE(), SLEEP(2), SYSDATE(); +---------------------+----------+---------------------+----------+---------------------+ | SYSDATE() | SLEEP(1) | SYSDATE() | SLEEP(2) | SYSDATE() | +---------------------+----------+---------------------+----------+---------------------+ | 2017-08-18 22:33:44 | 0 | 2017-08-18 22:33:44 | 0 | 2017-08-18 22:33:44 | +---------------------+----------+---------------------+----------+---------------------+ 1 row in set (3.00 sec)

  1. What version of TiDB are you using (tidb-server -V)? Git Commit Hash: 365e4ab491b683a69c2004f30b1ae4f86256e2ad Git Commit Branch: master UTC Build Time: 2017-08-16 01:24:27
Updated 19/08/2017 12:41 2 Comments

Global loading bar issues

LiskHQ/lisk-nano

Expected behaviour

Global loading bar should work like before the migration

Actual behaviour

Global loading bar does not have blue background Global loading bar is displayed also on periodical requests (peer, account)

Updated 18/08/2017 14:14

Issues in forging tab

LiskHQ/lisk-nano

Expected behaviour

forging tab should work as before the migration

Actual behaviour

forging tab - shows Rank higher by 1 (compared to nano 1.0.0) - doesn’t round LSK amounts to 2 decimal places - Forged blocks don’t get updates after the initial load

Updated 18/08/2017 14:45

Copy-paste error in parameter description (documentation) of setTrackbarMin

opencv/opencv
System information (version)
  • OpenCV => 3.3
  • Operating System / Platform => -
  • Compiler => -
Detailed description

The parameter minval of setTrackbarMin is documented as (http://docs.opencv.org/3.3.0/d7/dfc/group__highgui.html#gabe26ffe8d2b60cc678895595a581b7aa)

New maximum position.

I suppose that this is a copy-paste error from the documentation of setTrackbarMax (http://docs.opencv.org/3.3.0/d7/dfc/group__highgui.html#ga7e5437ccba37f1154b65210902fc4480).

Steps to reproduce

Suggestion: Change the description of minval to

New minimum position.

or something similar.

Updated 18/08/2017 13:28

Focus should be in input after sending message

threema-ch/threema-web

Expected Behavior

<!— If you’re describing a bug, tell us what should happen –> <!— If you’re suggesting a change/improvement, tell us how it should work –>

After sending a message the focus should always be on the input field, so I can just continue to type the next message.

Current Behavior

<!— If describing a bug, tell us what happens instead of the expected behavior –> <!— If suggesting a change/improvement, explain the difference from current behavior –>

When clicking on the sent button, the focus seems to stay on that button.

Possible Solution

<!— Not obligatory, but suggest a fix/reason for the bug, –> <!— or ideas how to implement the addition or change –>

Steps to Reproduce (for bugs)

<!— Provide a screenshot and/or an unambiguous set of steps to reproduce this bug. –> 1. Type a message. 2. Click on the “sent button”.

Updated 18/08/2017 12:06

Fix for delegate asset schema

LiskHQ/lisk

Delegate asset should just contain a required username. Now, it is requiring a publicKey. Same problem was already addressed and resolved in lisk-js by https://github.com/LiskHQ/lisk-js/issues/296

Updated 18/08/2017 15:04

string literal compability

pingcap/tidb

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

select "ss" "a";

both TiDB and MySQL not set sql mode “ANSI_QUOTES”

  1. What did you expect to see?
mysql> select "ss" "a";
+-----+
| ss  |
+-----+
| ssa |
+-----+
1 row in set (0.00 sec)
  1. What did you see instead?
mysql> select "ss" "a";
+------+
| a    |
+------+
| ss   |
+------+
1 row in set (0.00 sec)
  1. What version of TiDB are you using (tidb-server -V)?
Release Version: 0.8.0
Git Commit Hash: 0d27b1f49e596a071b24e2a88ff9a3994910e5d0
Git Branch: master
UTC Build Time: 2017-08-18 11:00:58
Updated 20/08/2017 01:30

Improved support for Open Graph tags

Trustroots/trustroots

Trustroots should have open graph support, so user profiles, tribe pages, and other pages show up nicely on Facebook, Twitter, and other social media with proper preview image, title, summary, etc.

It’s partially there, but some things are still missing, like images on Facebook, and I think Twitter tags aren’t supported at all. (Will compose a better list later when I reunite with laptop!)

http://ogp.me/

Updated 18/08/2017 20:20 6 Comments

failed to add column comment by using alter column statement

pingcap/tidb
  1. What did you do? If possible, provide a recipe for reproducing the error. as #4224 stated, the table/column comments were lost when I executed the mysql DDL, then I tried the alter column statement: alter table ’t_bs_s_data_item' modify column ‘ITEM_CD’ comment ‘数据项代码’; and alter table ’t_bs_s_data_item' column ‘ITEM_CD’ comment ‘数据项代码’;

  2. What did you expect to see? Query OK

  3. What did you see instead? error msg: MySQL [gin]> alter table ’t_bs_s_data_item' modify column ‘ITEM_CD’ comment ‘数据项代码’; ERROR 1105 (HY000): line 0 column 31 near “modify column ‘ITEM_CD’ comment ‘数据项代码’” (total length 80) and MySQL [gin]> alter table ’t_bs_s_data_item' column ‘ITEM_CD’ comment ‘数据项代码’; ERROR 1105 (HY000): line 0 column 31 near “column ‘ITEM_CD’ comment ‘数据项代码’” (total length 73)

  4. What version of TiDB are you using (tidb-server -V)? Git Commit Hash: 365e4ab491b683a69c2004f30b1ae4f86256e2ad Git Commit Branch: master UTC Build Time: 2017-08-16 01:24:27

Updated 18/08/2017 05:25

Provide a way to specify the debug library name to use in cc.find_library

mesonbuild/meson

On Windows, the release library and the debug library are usually called different names; for instance libpcre is called ‘pcre.lib/pcre.dll’ for release and ‘pcred.lib/pcred.lib/ for debug builds. Similarly for boost.

I propose a new kwarg called ‘debug_name:’ which will peek at buildtype and use the provided name if the buildtype starts with 'debug'.

Updated 17/08/2017 14:15

Add expiration options to meet offers

Trustroots/trustroots

Not sure how this should look like to be simple. Day pickers aren’t simple but perhaps required so that it would be flexible.

Expires in: - Week - Two weeks - Three weeks - Month

Defaults to month.

For now month should be maximum time meet dots are allowed on map — in future we might remove the restriction, but first we want to observe a bit how people start using the feature.

This should be at the “details” tab.

image

Updated 17/08/2017 11:40

Image for the ACM ICPC Bootcamp '13

nihal111/WnCC

I’m not sure who sent the PR for this, or how this happened but the image for the 2013 event, ACM ICPC Bootcamp is missing/doesn’t show when you serve it. It should be a relatively easy issue. Just add the image to the images folder and the image name to the file _events/13-ACMICPCBootCamp13.markdown. <img width=“1280” alt=“screen shot 2017-08-17 at 15 23 59” src=“https://user-images.githubusercontent.com/22732781/29406946-494204f8-8360-11e7-8d53-c37091cfe4f9.png”>

Updated 17/08/2017 09:58

Unclear doc for PCA.fit(x, y)

scikit-learn/scikit-learn

Description

The documentation of the PCA.fit method does not say what the parameter y does. When I read the docs, I was slightly confused since PCA is unsupervised and hence it does not need y. After looking into the code, I realized that y is just ignored, however, I think this should be mentioned in the docs.

IncrementalPCA.fit has a short comment on this, but to me, it’s not very clear.

Documentation of other unsupervised fitters has similar issues, e.g. TSNE

Updated 17/08/2017 11:04 3 Comments

Binary literal not having the BINARY flag

pingcap/tidb

MySQL:

mysql> SELECT _binary'string';
Field   1:  `string`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       VAR_STRING
Collation:  binary (63)
Length:     6
Max_length: 6
Decimals:   31
Flags:      NOT_NULL BINARY 


+--------+
| string |
+--------+
| string |
+--------+
1 row in set (0.00 sec)

TiDB:

mysql> SELECT _binary'string';
Field   1:  `string`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       VAR_STRING
Collation:  utf8_general_ci (33)
Length:     6
Max_length: 6
Decimals:   31
Flags:      


+--------+
| string |
+--------+
| string |
+--------+
1 row in set (0.00 sec)
Updated 18/08/2017 13:40 2 Comments

not stripping unnecessary quotes around keys in flow object types

prettier/prettier

Behavior of stripping unnecessary quotes around object properties is inconsistent between flow type declarations and js object instantiation.

see example here

https://prettier.io/playground/#%7B%22content%22%3A%22type%20Foo%20%3D%20%7B%5Cn%20%20'prop'%3A%20string%2C%5Cn%7D%5Cn%5Cnconst%20foo%3A%20Foo%20%3D%20%7B%5Cn%20%20'prop'%3A%20'asdf'%2C%5Cn%7D%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingComma%22%3A%22none%22%2C%22bracketSpacing%22%3Atrue%2C%22jsxBracketSameLine%22%3Afalse%2C%22parser%22%3A%22flow%22%2C%22semi%22%3Atrue%2C%22useTabs%22%3Afalse%2C%22doc%22%3Afalse%2C%22ast%22%3Afalse%7D%7D

expected output: ```js type Foo = { prop: string };

const foo: Foo = { prop: “asdf” };

```

Updated 19/08/2017 21:34 3 Comments

The login button can have text overflowing out of the box in some locales and platforms

vector-im/riot-web

<!– This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the us to get all the necessary data to fix your issue.

You can also preview your report before submitting it. You may remove sections that aren’t relevant to your particular case.

Text between <!– and –​> marks will be invisible in the report. –>

Description

The login button can have text overflowing out of the box in some locales and platforms

Steps to reproduce

  • Go on https://riot.im/develop/#/home or https://riot.im/app/#/home without a connected account with French as requested locale and on a Mac
  • You can see the text go outside of the box (see joined screenshot)

Describe how what happens differs from what you expected.

The box should be sized to contain the text.

<!– Include screenshots if possible: you can drag and drop images below. –> Screenshot of the home

Version information

<!– IMPORTANT: please answer the following questions, to help us narrow down the problem –>

  • Platform: web

For the web app:

  • Browser: Firefox stable and nightly, Chrome.
  • OS: macOS
  • URL: riot.im/develop / riot.im/app

Additional informations:

Problem visible on both Firefox and Chrome on macOS, but not on Linux nor Windows. It seems to be related to the font and its style (Linux may have the requested font missing too). Text seems to be bold on macOS compared to other platforms. I think it’s important to check other locales for both the sign in and log in buttons as many locales can have longer texts than French.

Updated 18/08/2017 10:21 4 Comments

grant privilege for database with certain option is not valid

pingcap/tidb

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? when i use dts to transfer data from rds to local tidb, it need to check privileges; and the following grant command is valid in mysql, but invalid in tidb.

  2. What did you expect to see?

// in mysql
mysql> grant ALTER,DELETE,CREATE,TRIGGER,CREATE ROUTINE,INSERT,INDEX,CREATE VIEW,SELECT on `12345-datavisualization`.* TO 'root'@'%';
Query OK, 0 rows affected (0.07 秒)
  1. What did you see instead?
// in tidb
mysql> grant ALTER,DELETE,CREATE,TRIGGER,CREATE ROUTINE,INSERT,INDEX,CREATE VIEW,SELECT on `12345-datavisualization`.* TO 'root'@'%';
ERROR 1105 (HY000): line 0 column 48 near ",INSERT,INDEX,CREATE VIEW,SELECT on `12345-datavisualization`.* TO 'root'@'%'" (total length 125)
  1. What version of TiDB are you using (tidb-server -V)? Git Commit Hash: 18f84dd3c673616c1edd546002ecbfb3dd324a20 UTC Build Time: 2017-08-08 02:32:12
Updated 17/08/2017 09:56 2 Comments

grant privilege identified by password should be hash string

pingcap/tidb

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

In MySQL, it’s invalid:

mysql> grant select on *.* to 'genius'@'%' identified by password '0101001';
ERROR 1827 (HY000): The password hash doesn't have the expected format. Check if the correct password algorithm is being used with the PASSWORD() function.
  1. What did you expect to see?

According to mysql document, grant privilege identified by password should be hash string.

  1. What did you see instead?

TiDB accept the input grant select on *.* to 'genius'@'%' identified by password '0101001';

  1. What version of TiDB are you using (tidb-server -V)?
Updated 17/08/2017 04:23 2 Comments

Avoid using isinstance(memory, Memory) to allow for alternative Memory implementations

scikit-learn/scikit-learn

As raised in #9561, we should not be using isinstance(memory, Memory) to validate Memory arguments, as it’s not straightforward for users to realise they need to use sklearn.externals.joblib.Memory (rather than joblib.Memory).

I think we should be using ducktyping wherever we check for memory. If a memory parameter has a method cache, we should treat it as Memory. We should have test cases with dummy replacements for memory that have the right cache interface to make sure this is sufficient for our needs.

This affects hierarchical clustering and Pipeline.

Updated 18/08/2017 11:39 11 Comments

ui: Table column header toggle ux polish

cockroachdb/cockroach

Two minor visual nits:

  1. On any table, one column header should always be highlighted, so this shouldn’t happen: image

Essentially, user shouldn’t be able to deactivate column header A by clicking on it. A would be deselected if someone clicks on B automatically.

  1. The little triangle in the table header is a different ratio comparing to that in the dropdown buttons. Let’s stick with the dropdown button triangle.

cc: @dianasaur323

Updated 16/08/2017 00:49 1 Comments

expression: builtime Time compability.

pingcap/tidb

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? select time('840:59:60.000000');

  2. What did you expect to see?

mysql> select time('840:59:60.000000');
+--------------------------+
| time('840:59:60.000000') |
+--------------------------+
| NULL                     |
+--------------------------+
1 row in set, 1 warning (0.00 sec)
  1. What did you see instead?
mysql> select time('840:59:60.000000');
ERROR 1292 (22007): Truncated incorrect time value: '840:59:60.000000'
  1. What version of TiDB are you using (tidb-server -V)?
Git Commit Hash: 276defa164a840786f5ef7403aa41897b13f2812
Git Branch: master
UTC Build Time: 2017-08-15 05:10:19
Updated 16/08/2017 07:42 5 Comments

State: Refactor to use `State._init_context`

trailofbits/manticore

This is described in the bottom section of this PR description: https://github.com/trailofbits/manticore/pull/433

We should port uses of state.context to initialize their dict key in State._init_context, so code related to that dict key can be less cautious about if it exists or not. Currently only state.context['branches'] does this.

Updated 14/08/2017 20:17

EINTEGRITY error doesn't say for which module

pnpm/pnpm
  27393 debug pnpm:progress:
    status: "downloaded_manifest"
    pkgId: "registry.npmjs.org/draft-js/0.10.1"
    pkgVersion: "0.10.1"
  27394 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/draft-js/0.10.1"
  27395 debug pnpm:progress:
    status: "downloaded_manifest"
    pkgId: "registry.npmjs.org/fbjs/0.8.14"
    pkgVersion: "0.8.14"
  27396 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/fbjs/0.8.14"
  27397 debug pnpm:progress:
    status: "downloaded_manifest"
    pkgId: "registry.npmjs.org/object-assign/4.1.1"
    pkgVersion: "4.1.1"
  27398 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/object-assign/4.1.1"
  27399 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/rc-editor-core/0.7.8"
  27400 debug pnpm:fetch: "finish sha1-E7TTyxK++hVIKib+Gy665kAHHks= https://registry.npmjs.org/immutable/-/immutable-3.7.6.tgz"
  27401 debug pnpm:progress:
    status: "fetched"
    pkgId: "registry.npmjs.org/immutable/3.7.6"
  27402 debug pnpm:progress:
    status: "downloaded_manifest"
    pkgId: "registry.npmjs.org/immutable/3.7.6"
    pkgVersion: "3.7.6"
  27403 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/immutable/3.7.6"
  27404 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/draft-js/0.10.1"
  27405 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/rc-editor-mention/0.6.12"
  27406 debug pnpm:progress:
    status: "dependencies_installed"
    pkgId: "registry.npmjs.org/antd/2.12.5"
  27407 error pnpm:
    message:
      code: "EINTEGRITY"
      found: "sha1-dbSmLq6UB++20xCT5eJrkj11178="
      expected:
        - "sha1-mnHEh0chjrylHlGmbaaCA4zct78="
      algorithm: "sha1"
      sri: "sha1-mnHEh0chjrylHlGmbaaCA4zct78="
    err:
      name: "Error"
      message: "sha1-mnHEh0chjrylHlGmbaaCA4zct78= integrity checksum failed when using sha1: wanted sha1-mnHEh0chjrylHlGmbaaCA4zct78= but got sha1-dbSmLq6UB++20xCT5eJrkj11178=. (4292233 bytes)"
      code: "EINTEGRITY"
      stack: "Error: sha1-mnHEh0chjrylHlGmbaaCA4zct78= integrity checksum failed when using sha1: wanted sha1-mnHEh0chjrylHlGmbaaCA4zct78= but got sha1-dbSmLq6UB++20xCT5eJrkj11178=. (4292233 bytes)\n    at Transform.on (/usr/local/lib/node_modules/pnpm/lib/node_modules/ssri/index.js:275:19)\n    at emitNone (events.js:110:20)\n    at Transform.emit (events.js:207:7)\n    at endReadableNT (_stream_readable.js:1047:12)\n    at _combinedTickCallback (internal/process/next_tick.js:102:11)\n    at process._tickCallback (internal/process/next_tick.js:161:9)"

For my particular case it works on macOS but not on Ubuntu.

pnpm version: 1.10.2

Additional information:

  • node -v prints: 8.1.2
  • Windows, OS X, or Linux?: Ubuntu 16

BTW: Is there an easier way to check which module it was?

Updated 18/08/2017 22:42 5 Comments

`pnpm i -S an-npm-linked-module` doesn't add to package.json

pnpm/pnpm

pnpm version: 1.10.2

Code to reproduce the issue:

pnpm link foo pnpn i -S foo

Expected behavior:

foo should be added to package.json

Actual behavior:

a warning shows up saying that foo is linked

Additional information:

  • node -v prints: 8.1.2
  • Windows, OS X, or Linux?: macOS

Maybe some relevant discussion here: https://github.com/pnpm/pnpm/issues/825

Updated 16/08/2017 20:30 4 Comments

NA rows in dataframes_graph()

wlandau-lilly/drake

Sometimes, dataframes_graph() reads targets/imports from the cache that are no longer present in the current workflow plan. Solution: make sure row selectors are already in nodes$id.

dataframes_graph = function(...){
   ...
  targets = intersect(nodes$id, plan$target)
  imports = setdiff(nodes$id, plan$target)
  functions = Filter(x = imports, f = function(x)
    can_get_function(x, envir = envir))
  functions = intersect(nodes$id, functions)
  missing = Filter(x = imports, f = function(x) missing_import(x, envir = envir))
  missing = intersect(nodes$id, missing)
  ...
  outdated = outdated(plan = plan, targets = targets, envir = envir,
     verbose = verbose, jobs = jobs, parallelism = parallelism,
     packages = packages, prework = prework, config = config)
  outdated = intersect(outdated, nodes$id)
  nodes[targets, "status"] = "up-to-date"

  ...
  in_prog = in_progress()
  in_prog = intersect(in_prog, nodes$id)
  nodes[in_prog, "status"] = "in progress"
  ...
}
Updated 16/08/2017 12:05 1 Comments

low hanging fruit for optimizations?

sozu-proxy/sozu

No specific goal here, except looking for easy things we could do to improve the performance, and how to test it. First thing I’d like to try, adding this to Cargo.toml:

[profile.release]
lto = true
panic = 'abort'

we’ll probably need more benchmarks to test those ideas

Updated 17/08/2017 15:08

Cut doesn't work inside the nested table

ckeditor/ckeditor-dev

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Create the table.
  2. Put the caret at the cell.
  3. Create the nested table.
  4. Type something in two different cells (inside the nested table).
  5. Select these cells.
  6. Press <kbd>Ctrl</kbd> + <kbd>X</kbd>.

Expected result

Text should be cut.

Actual result

The selection disappears, text wasn’t removed, but cells were copied to the clipboard.

GIF

bug_cke4

Other details

  • Browser: All browsers
  • OS: Windows 10
  • CKEditor version: 4.7.2
Updated 16/08/2017 17:54 1 Comments

Fork me on GitHub