Contribute to Open Source. Search issue labels to find the right project for you!

[Help Wanted] Preview text files

mattermost/mattermost-mobile

Jira ticket: https://mattermost.atlassian.net/browse/RN-528

We currently support viewing most file types in the app (video, word docs, PDFs, etc), but we still need to add support for previewing text files.

The expected behaviour should be similar to other files: - Tapping on the file thumbnail downloads the file - The file opens in the previewer so it can be viewed

For text files, the previewer can look similar to the code block preview.

Updated 06/12/2017 12:36

[Help Wanted] [PLT-8278] Add a custom example to API reference for how to upload a file via the API

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

We’ve received multiple questions from the community about how to upload a file via the APIs. E.g., see https://github.com/mattermost/mattermost-server/issues/7907

Propose adding an example of how to do this at api.mattermost.com. This will involve 1. figuring out how to add custom examples on the site, which is auto-generated from https://github.com/mattermost/mattermost-api-reference. 2. creating an example for uploading the file via the API. A sample is given below

POST /api/v4/files HTTP/1.1
Host: localhost:8065
Connection: keep-alive
Content-Length: 444
Accept: application/json
Authorization: bearer <your token here>
Content-Type: multipart/form-data; boundary=----WebKitFormBoundary5a5WIBBw6R9BjHO7

------WebKitFormBoundary5a5WIBBw6R9BjHO7
Content-Disposition: form-data; name="files"; filename="test.txt"
Content-Type: text/plain

<your file content here>
------WebKitFormBoundary5a5WIBBw6R9BjHO7
Content-Disposition: form-data; name="channel_id"

<your channel id here>
------WebKitFormBoundary5a5WIBBw6R9BjHO7
Content-Disposition: form-data; name="client_ids"

<your optional client ids here>
------WebKitFormBoundary5a5WIBBw6R9BjHO7--
  1. Adding this example to https://github.com/mattermost/mattermost-api-reference/blob/master/v4/source/files.yaml
Updated 13/12/2017 17:17 2 Comments

[Help Wanted] [PLT-7972] Ability to reset your own password via System Console Users List

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro:

1) Sign in as a system admin 2) Go to System Console > Users and find yourself from the users list 3) Click “Reset Password” 4) Enter a new password and hit Enter

Observed: Error “Invalid or missing current_password in request body” as it expects for the current password image

Expected: Ask for the current password letting the password update be successful.

image

Updated 01/12/2017 14:49 3 Comments

[Help Wanted] [PLT-8024] Support LOGIN authentication method for SMTP

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Difficulty: Intermediate

Currently, Mattermost only supports PLAIN authentication methods. However, there are two other ones as well, LOGIN and CRAM-MD5 (http://www.samlogic.net/articles/smtp-commands-reference-auth.htm).

The Outlook Web App doesn’t support the PLAIN authentication method, and thus email notifications with an OWA enabled account fails. We’ll need to add handling for the LOGIN method to support OWA.

Go doesn’t support it by default, but someone posted a Gist of how to implement it fairly easily. We should aim to cover this feature with automated tests since we have a simulated mail server that runs during the tests.

See the GitHub issue: https://github.com/mattermost/mattermost-server/issues/7578 and discussion in Peer-to-Peer Help channel: https://pre-release.mattermost.com/core/pl/ik6rjyr9dtgptbwutt7a4qqzih

Updated 14/12/2017 16:35 1 Comments

[Help Wanted] [PLT-8173] Add username and profile picture to webhook set up pages

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

On the pages used to add and edit incoming and outgoing webhooks, add the following settings to the bottom of the page:

Username (Optional) Choose the username this integration will post as. Usernames can be up to 22 characters, and may contain lowercase letters, numbers and the symbols “-”, “_”, and “.” .

Profile Picture (Optional) Choose the profile picture this integration will use when posting. Enter the URL of a .png or .jpg file at least 128 pixels by 128 pixels.


These settings should only appear if the respective config settings “EnablePostUsernameOverride” and “EnablePostIconOverride” are set to true.

When set, this integration should use the given username and icon for posting, unless: 1. The config settings “EnablePostUsernameOverride” and “EnablePostIconOverride” are changed to false 2. The webhook payload specifies a different username or icon

Updated 21/11/2017 19:26 1 Comments

[Help Wanted] [PLT-7537] Post a system message when a channel is moved between teams

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

There is a CLI command to move channels from one team to another. This ticket is to have a System Message that gets posted in the affected channel when it has been moved to a different team by the CLI command:

"This channel has been moved to this team from {old_team}."
Updated 21/11/2017 19:27

[Help Wanted] [PLT-7536] Post a system message when a team is changed from public private.

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

There is a CLI command to modify channels from public to private and vice-versa. This ticket is to post a System message to the affected channel:

Private > Public: “This channel has been converted to a Public Channel and can be joined by any team member.”

Public > Private: “This channel has been converted to a Private Channel.”

Updated 11/12/2017 16:14 5 Comments

[Help Wanted] [PLT-7396] Add the ability to revoke all user sessions of the system in System Console > Users

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Proposed changes: Revoke sessions of all users in the system

In System Console > Users

A) To revoke all sessions in the system, add “Revoke All Sessions” button to the page. Useful if the admin suspects the system has been compromised and needs to neutralize the situation.

image

B) Clicking this button opens a popup, similar to the “Deactivate” popup menu attached below. Title: Revoke all sessions in the system Help text: This action revokes all sessions in the system. All users will be logged out from all devices. Are you sure you want to revoke all sessions? Buttons: - Cancel: Closes the popup, takes no action. - Revoke Sessions: Revokes all user sessions immediately.

image

Updated 11/11/2017 18:38 1 Comments

[Help Wanted] [PLT-8087] Optimize file attachment memory usage where possible

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

In our hardware requirements doc, we cite attachment size as a large factory for memory requirements. In many cases, we can optimize our attachment handling by streaming the attachment to S3 or disk without holding the entire file in memory.

Conversation in pre-release: https://pre-release.mattermost.com/core/pl/huod3abtmpgoxyp4uatmkyrhyc

Updated 09/11/2017 23:54

[Help Wanted] Migrate filtered_user_list.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/filtered_user_list.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 10/11/2017 13:07 2 Comments

[Help Wanted] Migrate file_upload.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/file_upload.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 13/11/2017 13:23 1 Comments

[Help Wanted] Migrate emoji/components/delete_emoji_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/emoji/components/delete_emoji_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 06/12/2017 13:05 3 Comments

[Help Wanted] Migrate code_preview.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/code_preview.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 05/11/2017 23:17

[Help Wanted] Migrate do_verify_email.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/do_verify_email.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 13/11/2017 13:23 1 Comments

[Help Wanted] Migrate create_team/* to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/create_team/* to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 05/11/2017 23:16

[Help Wanted] Migrate channel_members_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/channel_members_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 06/12/2017 13:02 1 Comments

[Help Wanted] Migrate status_icon.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/status_icon.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 03/11/2017 23:36 3 Comments

[Help Wanted] Migrate invite_member_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/invite_member_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 03/11/2017 23:36 1 Comments

[Help Wanted] Migrate removed_from_channel_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/removed_from_channel_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 03/11/2017 23:36 1 Comments

Ernest: randomizations heatmap should show node degree information

fraenkel-lab/OmicsIntegrator2

Generate a version of the heatmaps for parameter selection that simultaneously capture node degree, robustness and specificity. Since degree is fixed for a node, it could be plotted at the margin of the heatmap. Robustness and specificity depend on the parameters. Perhaps we could have two versions of the plot: (A) Color scale for robustness for each matrix element with average specificity of nodes shown in the margin and (B) color scale for specificity for each matrix element with average robustness of nodes shown in the margin.

Updated 19/10/2017 19:27

[Help Wanted] Migrate delete_post_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/delete_post_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 03/11/2017 23:37 4 Comments

[Help Wanted] Migrate channel_notifications_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/channel_notifications_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 07/11/2017 13:20 2 Comments

[Help Wanted] Migrate change_url_modal.jsx to be pure and use Redux

mattermost/mattermost-server

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/change_url_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 13/12/2017 13:28 2 Comments

[Help Wanted] [PLT-4340] Channel Mute and "/mute" command

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

See corresponding ticket for mobile: https://mattermost.atlassian.net/browse/RN-417

Functionality When a channel is muted, desktop, push and email notifications are not sent for the channel.

When a channel is unmuted, push, email and desktop notifications are sent as usual (According to the Account settings preferences, unless overridden by the channel notification settings “Send Desktop Notifications” and “Send mobile push notifications”)

User Interface

  1. Channel Header: When a channel is muted, a clickable icon appears next to the channel name in the channel header (see mock-up).
    • on-hover tooltip: “Unmute”
    • Clicking the icon unmutes the channel and the icon disappears.

image

  1. Channel Sidebar: When a channel is muted, the channel name in the left-hand sidebar is reduced to 30% opacity and the channel is sorted to the bottom of the sidebar section (secondary sorting of muted channels is based on standard channel sorting). The channel only bolds for unread mentions and the mention jewel also appears at reduced opacity:

image

When a channel is unmuted, opacity of the channel name is increased to normal in the left-hand-side and the channel is resorted among the non-muted channels as usual.

  1. Channel Notification Preferences: Add a setting to Channel > Notification Preferences, at the top.
    "Mute Channel"
    [ ] On
    [ x ] Off
    Help Text: Muting turns off desktop, email and push notifications for this channel. The channel will not be marked as unread unless you're mentioned.

When a channel is muted (via slash command or this setting), all other channel notification preferences are hidden in the UI, including “Send desktop notifications”, “Send mobile push notifications”, and “Mark Channel Unread”.

When a channel is unmuted (via slash command, this setting, or the channel header icon), all other channel notification preferences are shown as usual below this setting. “Send Desktop Notifications”, “Send mobile push notifications” and “Mark Channel Unread” settings return to the state they were in before muting.

Remove the setting Channel Notification Preferences > Mark Channel Unread. Turn on Mute Channel for any channel which had been set to “Only for mentions”.

Slash Command Add a slash command “/mute”. Autocomplete description: /mute [channel] Turns off desktop, email and push notifications for the current channel or the [channel] specified

  1. “/mute” mutes the current channel
  2. System message: “You will not receive notifications for [Channel UI Name] until Channel Mute is turned off.”

  3. “/mute” when the current channel is already muted will unmute the current channel

    • System message: “[Channel UI Name] is no longer muted.”
  4. “/mute ~channel-handle” mutes the channel listed.

    • System message: “You will not receive notifications for [Channel UI Name] until Channel Mute is turned off.”
  5. “/mute ~channel-handle” when the listed channel is already muted will unmute the listed channel.

    • System message: “[Channel UI Name] is no longer muted.”
Updated 01/11/2017 18:43 7 Comments

[Help Wanted] [PLT-7567] Team Icons

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

See corresponding ticket for mobile: https://mattermost.atlassian.net/browse/RN-418

Team Icons will appear in the team sidebar within the border of the existing team icons:

image

  • The mention counter on the team sidebar should have a 1px stroke

Add a Team Icon setting to the Team Settings modal below the Team Description setting: - Collapsed text when image is set: “Image last updated MMM DD, YYYY” - Collapsed text when no image is set: “Click Edit to upload an image.”

image

When editing the Team Icon the setting expands: - If no image has been uploaded, do not show an image preview until an image is selected:

image

  • If an image has been previously uploaded or a new image is selected, show the preview similar to the Profile Picture setting in Account Settings

image

Buttons (Same as Profile Picture setting in Account Settings): - “Select”: Opens the file selector to choose a team icon. Once selected, the image preview is rendered in the modal. - “Save”: Saves the new Team Icon after selecting a new image. Button is disabled unless an image is selected using the “Select” button. - “Cancel”: Collapses the “Team Icon” setting.

Updated 30/11/2017 19:44 9 Comments

[Help Wanted] [PLT-7793] Manage Tokens page

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

CONTEXT:

In large deployments, with several users creating personal access tokens, it’s essential for the System Admin to be able to find, manage and revoke these tokens as needed.

Some of this is currently handled by “Manage Tokens” option in the Users page, but the functionality is limited and tokens can only be viewed per users. There isn’t a single list of tokens available in the UI.

A Tokens page is a key request from some customers with respect to personal access tokens.

PROPOSED CHANGE:

1) Add a “Personal Access Tokens” page to the System Console, listed below “Users” in the sidebar.

The list includes - Token ID and Token Description - User who created the token - Option to delete the token on the right

Tokens are sorted by - Alphabetically by token id.

Admin can search tokens by - token ID - username - user ID

image

2) Deleting the token - Clicking “Delete” will bring up a confirmation dialog similar to the one below when deactivating a user, with:

Title: Delete Token Description: Any integrations using this token will no longer be able to access the Mattermost API. You cannot undo this action.\n\nAre you sure want to delete the [description] token? Buttons: Cancel // Delete

Hitting “Cancel” closes the popup and does no action. Hitting “Delete” deletes the token.

image

3) Add a client side telemetry event when a System Admin deletes a token via System Console > Access Tokens

Please use category: ‘system_console_tokens’ for the telemetry entry, in order for it to be distinguished from a System Admin deleting a token from the System Console > Users page.

4) Update the System Console > Custom Integrations help text for enabling a personal access token to:

When true, users can create personal access tokens for integrations in Account Settings > Security. They can be used to authenticate against the API and give full access to the account.

To manage who can create personal access tokens or to search users by token ID, go to the Reporting > Users page. To manage tokens, go to the Reporting > Personal Access Tokens page.
Updated 13/12/2017 13:28 3 Comments

[Help Wanted] [PLT-7776] Render at-mentions by the teammate name display

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

CURRENT CONDITION:

Currently, Mattermost uses the Teammate Name Display config setting to choose which name to display in the UI, including - channel member lists - email notifications - push notifications - DM channel sidebar

In many of the other lists like “Add Members”, channel switcher and “More Direct Messages”, all name variations are displayed.

The one place where we strictly use usernames in the UI is at-mentions.

CONTEXT (from a prospect):

We had to change our usernames from “first name” to the actual user name in LDAP config.

As a result, people have random usernames like “xyz2fe”. These random usernames appear in several places of the UI due to mentions, making the experience confusing.

PROPOSED CHANGE:

1) In the UI, render at-mentions by the teammate name display set in config.json. The entire name should be highlighted, and preceeded with an “@” symbol.

When writing a message draft, the at-mention should use the username, similar to channel linking, to guarantee the correct mention is fired (we might be able to do some fancier stuff later).

2) In system messages (e.g. user joined/left), use the teammate name display setting as well, instead of the default username.

Updated 13/12/2017 13:28 5 Comments

[Help Wanted] [PLT-7774] Add the Teammate Name Display setting back to Account Settings > Display, below "Clock Display" option.

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add the Teammate Name Display setting back to Account Settings > Display, below “Clock Display” option.

Title: Teammate Name Display Help text: Set how to display other user’s names in posts and the Direct Messages list. Options: - Show username (default) // If username is chosen by the admin in System Console > Users and Teams > Teammate Name Display - Show nickname if one exists, otherwise show first and last name - Show first and last name

Notes: 1) The end user settings would have the same options as before, but defaults to the System config setting. 2) Push and email notifications would follow the System config setting. 3) If the System config setting is updated, only override the display setting for users who were using the default

Examples: a) User has not changed the display name and is using the system default (first/last name). System Admin changes the config setting from first/last name to nickname. User’s display setting also changes to nickname. b) User has set the display name to username. System Admin changes the config setting from first/last name to nickname. User continues to have the display name set to username. c) User has set the display name to first/last name. System Admin changes the config setting from first/last name to nickname. User’s continues to have the display name set to first/last name.

Updated 13/12/2017 13:21 2 Comments

[Help Wanted] [PLT-7713] Change "View/Manage Members" dialog to use the same UI component as "Add Members to Team"

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Change “View/Manage Members” dialog to use the same UI component as “Add Members to Team”. This will make these UI dialogs consistent with each other. We already have a ticket to do this for the “Add Members” dialog: https://mattermost.atlassian.net/browse/PLT-6024

Functionally the only change should be that you can navigate through the users list with up/down arrow keys to change the selected user in the list.

Note that ENTER should open the dropdown menu for the user that’s in focus in the Manage Members modal, as it does now.

Updated 01/11/2017 18:37 1 Comments

[Help Wanted] [PLT-7395] Add the ability to search users by role in System Console > Users

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Proposed change:

Add a “Role” filter next to “Team” with the following options

  • “All Roles” (default, searches everyone)
  • “Inactive” (filters users who have been deactivated)
  • “User with Access Token Permission” (filters users who have permissions to generate an access token. This option is only shown if System Console > Integrations > Custom Integrations > Enable Personal Access Tokens is set to “true”)
  • “System Admin” (filters users who are system admins)
  • “Member” (filters users who are members)

image

Updated 13/12/2017 13:21 7 Comments

[Help Wanted] [PLT-200] Allow hosting of MM at any route like http://www.example.com/chat

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Related to https://github.com/mattermost/platform/issues/643 Also request from @botherder: https://twitter.com/botherder/status/655394442313138176 Voting: https://mattermost.uservoice.com/forums/306457-general/suggestions/12468372-install-mattermost-in-a-subdirectory Forum issue: https://forum.mattermost.org/t/how-do-i-set-the-base-url-for-apache-ssl-forwarding/573

To achieve this change, the client should reference the Site URL config.json setting instead of a relative link, when one is available. If no site URL is set, then return a slash or a blank value.

Notes: 1) For someone to host Mattermost in a subdirectory, it is assumed that Site URL is required to be set. 2) This change should not break existing deployments, including those who don’t have Site URL set. 3) Preliminary work from [~akihikodaki] in 2016 can be found here: https://github.com/mattermost/mattermost-server/compare/master…akihikodaki:PLT-200

Updated 01/11/2017 18:36 14 Comments

[Help Wanted] [PLT-7387] Mattermost-Kubernetes: Add jobserver instances to cluster

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

The goal of the Kubernetes repo at https://github.com/mattermost/mattermost-kubernetes has 2 objectives. 1) An easy to setup highly available reference implementation for running the load tests. 2) The longer term goal is a highly available production ready implementation.

The purpose of this ticket is to add an additional role to the mattermost-app container so that it can also run instances of the jobserver, and make the number of jobserver instances to run in the cluster configurable from 0 upwards. When jobservers are included in the cluster, the app servers should be configured to not run jobs.

Updated 03/11/2017 23:37

[Help Wanted] [PLT-5436] Render channel links in the channel header

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro: 1) Click a channel name 2) From the drop down menu, select “Edit Channel Header” 3) Paste the following: ~town-square

Observed: Header rendered as ~town-square image

Expected: Header rendered as ~Town Square, which works as a channel link. image

Here’s start of a PR to help you get started: https://github.com/mattermost/platform/pull/5334

Updated 13/12/2017 13:20 6 Comments

[Help Wanted] Change URLs of Direct Messages to usernames

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

For technical advice or questions, please join our “Developers” community channel.


Difficulty: Intermediate

Details: Jira ticket

This PR (https://github.com/mattermost/platform/pull/6310) added support for URLs of direct message channels in the form

https://servername.com/teamname/messages/@username
https://servername.com/teamname/messages/user_id
https://servername.com/teamname/messages/email

and for group message channels in the form

https://servername.com/teamname/messages/generated_id

Proposed change:

For direct message channels, propose all URLs to redirect to https://servername.com/teamname/messages/@username. That is

  • .../messages/user_id
  • .../messages/email
  • .../channels/userid1_userid2

should all redirect to .../messages/@username.

Similarly, for group message channels, propose

  • .../channels/generated_id redirecting to .../messages/generated_id

NOTE: Each of these URLs are already supported. This help wanted ticket simply changes the redirections to .../messages/@username or .../messages/generated_id

Updated 01/11/2017 18:34 4 Comments

[Help Wanted] [PLT-539] Update incoming webhooks to accept multipart/form-data content type such as that supplied by curl -F

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Update incoming webhooks to accept multipart/form-data content type such as that supplied by curl -F

Updated 21/11/2017 18:30 6 Comments

[Help Wanted] [PLT-7173] Kubernetes: Add mattermost-push-proxy

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add optional helm chart to deply https://github.com/mattermost/mattermost-push-proxy The goal of the Kubernetes repo at https://github.com/mattermost/mattermost-kubernetes has 2 objectives. 1) An easy to setup highly available reference implementation for running the load tests. 2) The longer term goal is a highly available production ready implementation.

Updated 29/09/2017 18:09 1 Comments

[Help Wanted] [PLT-6896] Add paging to system console log viewer

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

  1. The system console is hard coded to page=0 items_per_page=60. The setting isn’t very useful at the moment.
  2. Recommend adding proper paging to getting the servers or switch it to only load the last page.
  3. Also increase the max_per_page metics which defaults to 200. For log paging this is really low.

Also revert https://github.com/mattermost/platform/pull/6697

Updated 21/11/2017 14:58 3 Comments

[Help Wanted] [PLT-6871] Change at-mention autocomplete to prioritize entries where the username starts with the search string

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Change at-mention autocomplete to prioritize entries where the username starts with the search string

For the at mention autocomplete, it should sort users based on their username, but any user with their username starting with the search string should go first.

To give some context, if you search for “te” in the auto-complete right now on pre-release, you get the following results.

image

What you expect is this (those starting with “te” appear first, followed by other users in alphabetical order)

image

NOTE: You can compare to how the sorting is done for channel switcher shortcut (CTRL+K) https://github.com/mattermost/platform/pull/6486

Updated 01/11/2017 18:28 2 Comments

[Help Wanted] [PLT-6455] GIF images (custom emoji) and Profile Pics do not retain background transparency

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Original report: https://github.com/mattermost/platform/issues/6270

SUMMARY GIF images (custom emoji) and Profile Pics do not retain background transparency.

STEPS TO REPRODUCE Version: pre-release.mattermost.com

  1. Custom Emoji > Add Custom Emoji
  2. Save the image to your computer https://i.imgur.com/pmIfMVG.gif img
  3. On the modal that was open from step 1 use the saved GIF from step 2
  4. On the text preview in that page before clicking SAVE, it properly shows with transparency
  5. After its saved and upload the background goes black, on the emoji
  6. Using this emoji on any where will have its background black instead of transparent

EXPECTED BEHAVIOUR The GIF will retain its transparency, like the original above.

OBSERVED BEHAVIOUR The uploaded GIF had its background changed from transparent to black. It could be a global issue for any uploaded image that goes through Plan9 palette?

SIDE NOTE Created it under the name :monkey-want: if want to test it on https://pre-release.mattermost.com.

Updated 01/11/2017 18:26 2 Comments

[Help Wanted] [PLT-6074] Have deleteReaction API send the correct value for post.HasReactions

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

The changes made in https://github.com/mattermost/platform/pull/5499 make it so that the websocket event fired after removing a reaction always have the client save the post.HasReactions field to true even when the last reaction has just been removed.

Since that fix was made to solve a read replica issue (caused by saving the updated post on master and then getting the post again from a slave), we should change it so that the SqlReactionStore.Delete method returns the updated post instead of the the reaction that was just deleted (since the caller should already have that). The SqlReactionStore.Save method should probably be updated to return the post as well to keep the behaviour parallel between the two.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 02/11/2017 12:32 6 Comments

Drop support for Ruby 2.0

SciRuby/daru

I believe we can allow ourselves to it now :)

This not only means specifying 2.1 as a minimum version in the Gemfile, but also switching from option hashes to proper keyword arguments everywhere, which will greatly enchance documentability and discoverability of features.

On this change, version should be bumped at least to 0.2, I believe.

PS: As a side note, I believe 0.x becames to be a bit odd for library of this size. Maybe we need something like “Roadmap to 1.0” somewhere?..

Updated 08/10/2017 21:51 3 Comments

[Help Wanted] [PLT-3856] Help break HTML blocks to individual strings for translations

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Break HTML blocks into individual strings for easier translations.

Strings like this: http://translate.mattermost.com/nl/mattermost/translate/#filter=untranslated&unit=237152 should be decomposed to smaller strings. Mixing HTML with the translation is not a good practice.

Updated 01/11/2017 18:24

[Help Wanted] [PLT-5082] Add " v New messages below" indicator to the right-hand-side

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add new messages indicator when scrolled up in the right-hand-side and new messages are posted on the thread.

Ticket for adding this functionality in the center channel: https://github.com/mattermost/platform/issues/4250 PR that added this functionality in the center channel: https://github.com/mattermost/platform/pull/4299

image

Updated 14/12/2017 01:51 1 Comments

[Help Wanted] [PLT-4207] OAuth2.0: Incorrect Client ID during authentication allows user to go "Back to Mattermost" in the authentication window

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

If Auth2.0 Authentication fails because of an incorrect Client ID (see screenshots from Zapier), then the error message given provides an option for “Back to Mattermost” that opens Mattermost to the team selection page.

Expected: No “Back to Mattermost” button, page should just display a helpful error message.

image

image

Note: The page accepts query parameters that should allow you to submit this change

Updated 01/11/2017 18:22

[Help Wanted] Last viewed team isn't saved after logout

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details (Jira ticket)

Repro steps: 1) Join multiple teams with the current user 2) Switch to one that isn’t the first team in their sidebar 3) Log out 4) Log back in

Observed: You’re logged in to the first team in their sidebar Expected: You’re logged back into the last team you viewed

Updated 01/11/2017 18:21

[Help Wanted] Don't spike CPU usage when holding ESC key in webapp

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro steps: 1. Open task manager (windows) or activity monitor (mac) and sort by CPU usage 2. In Mattermost, select the post input box 3. Hold ESC key

Observed: CPU usage for browser rises significantly Expected: CPU usage is reasonable

Reported here: https://pre-release.mattermost.com/core/pl/3rj443164ff1frqty6de44fb5a

NOTE: Reproduces on Chrome browser. Also reproduces for other keys like CTRL and ALT

Updated 01/11/2017 18:21 2 Comments

[Help Wanted] Change direct message list to be infinite scroll

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Change direct message list to be infinite scroll.

Threshold will be 30 per list and load more when the scroll passes the threshold.

See initial commits in this PR to help you get started.

Updated 13/12/2017 13:18 2 Comments

[Help Wanted] Make /collapse and /expand only apply to previous posts in the channel

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Currently /collapse and /expand commands simply control the “Account Settings > Display > Default appearance of image link previews” setting.

Proposed change: Have the command only apply to previous posts in the current channel.

Example: Suppose - “Account Settings > Display > Default appearance of image link previews” is set to “Expanded”, and - user types /collapse in channel ABC.

Then - image links in existing posts in channel ABC collapse - new posts containing image links in channel ABC are expanded by default - image links in other channels are expanded by default

Updated 28/11/2017 13:13 6 Comments

Enhance specs style

SciRuby/daru

Our specs had grown “organically”, and many of them use outdated style of testing things (all bootstrap & several checks is made inside single example, tons of hard-to-read large objects created on the fly, instance variables are used instead of let and so on).

What should be done in this ticket is: * Refactoring of specs in accordance with BetterSpecs guidelines; * Making specs more clean/DRY (only several different dataframes are created as a test subjects, covering most of the situations) * Probably, splitting large specs files into smaller ones (e.g. for dataframe – basic functionality, math, output, import/export…) * Consider turning on Rubocop for specs files (with probably some cops turned off or tuned in spec/.rubocop.yml) * Consider introducing rubocop-rspec for rspec-specific checks (initially turned off, then turned on file-by-file & cop-by-cop)

As the full solution for the ticket will touch all spec/**/*.rb files, it is advised to make several PRs (one PR per one spec file, or one PR per one problem solution).

You can rely on my (@zverok) advices and reviews while working on this ticket.

Updated 08/10/2017 21:07 5 Comments

[Help Wanted] [PLT-5360] Clicking on email verification does not automatically fill in your email on mobile browser

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

This is a follow-up to https://github.com/mattermost/platform/pull/5140, whose PR can be found here and added this functionality for the desktop browser.

Repro (iOS, Safari browser): 1. Sign up to a site, and receive a verification email 2. On your phone, click the link in the email verification email 3. Click “Continue to browser” on the ios/android landing page.

Observed: Email verification is successful, but your email address is not filled in on the log in page. This is because you’re redirected to the switch_team page instead (and in return to the login page without the email validation URL)

Expected: To improve the user experience, your email address in already filled in and cursor is in the password field.

One solution is that if you’re redirected to Mattermost via an email verification, bypass the ios/android landing page.

Updated 01/11/2017 18:16 1 Comments

[Help Wanted] Firefox: CTRL/CMD + U to upload a file does not work

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

For technical advice or questions, please join our “Developers” community channel.


Difficulty: Intermediate

Details: Jira ticket

Repro: 1. Sign into Mattermost on a Firefox browser 2. Set focus to a message box 3. Hit CTRL/CMD + U

Observed: No action taken

Expected: A dialog opens, letting you upload files.

Updated 01/11/2017 18:12 2 Comments

[Help Wanted] Add a blue bar when email has been verified after changing your email address

mattermost/mattermost-server

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.


Details (Jira ticket)

After changing your email and clicking the “verify” link received in an email, show a blue bar when the user is taken to Town Square saying “Your email has been verified.”

Updated 01/11/2017 18:18

Support for Decimal in numpy.percentile

numpy/numpy

It would be great if numpy.percentile supported Decimal. Most numpy functions I’ve tried are fine with numpy.arrays containing Decimals, but not numpy.percentile.

from decimal import Decimal
import numpy as np
In[81]: x = np.array([[Decimal(1), Decimal(2)], [Decimal(1), Decimal(2)]])
In[82]: x
Out[82]: 
array([[Decimal('1'), Decimal('2')],
       [Decimal('1'), Decimal('2')]], dtype=object)
In[84]: np.min(x, axis=1)
Out[84]: array([Decimal('1'), Decimal('1')], dtype=object)
In[85]: np.median(x, axis=1)
Out[85]: array([Decimal('1.5'), Decimal('1.5')], dtype=object)
In[87]: np.std(x, axis=1)
Out[87]: array([Decimal('0.5'), Decimal('0.5')], dtype=object)
In[88]: np.mean(x, axis=1)
Out[88]: array([Decimal('1.5'), Decimal('1.5')], dtype=object)
In[86]: np.percentile(x, [50], axis=1)  # or np.percentile(x, [Decimal(50)], axis=1)
Traceback (most recent call last):
  File "C:\Python34\lib\site-packages\IPython\core\interactiveshell.py", line 3035, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-86-734677e766a8>", line 1, in <module>
    np.percentile(x, [50], axis=1)
  File "C:\Python34\lib\site-packages\numpy\lib\function_base.py", line 3054, in percentile
    interpolation=interpolation)
  File "C:\Python34\lib\site-packages\numpy\lib\function_base.py", line 2803, in _ureduce
    r = func(a, **kwargs)
  File "C:\Python34\lib\site-packages\numpy\lib\function_base.py", line 3143, in _percentile
    x1 = take(ap, indices_below, axis=axis) * weights_below
TypeError: unsupported operand type(s) for *: 'decimal.Decimal' and 'float'
In[14]: y = np.array([[1, 2], [1, 2]])
In[17]: np.percentile(y, [50], axis=1)  # this is fine, as expected
Out[17]: array([[ 1.5,  1.5]])

I’m using Python 3.4.3 and numpy 1.9.3.

Thanks

Updated 12/12/2017 09:40 7 Comments

Fork me on GitHub