Contribute to Open Source. Search issue labels to find the right project for you!

[Help Wanted] [PLT-4257] Prompt user when status is manually set /away or /offline upon login

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

When your status is manually set to away/offline, prompt user through a dialog (similar to attachment) to set themselves back online if they - close or exit the Desktop App, then re-open it - close the browser tab, then re-open it - log out / quit, and then log back in

Repro: 1. Set yourself as /away or /offline using slash commands. 2. Log out then log back in

Observed: Nothing happens. (poor awareness of status/situation)

image

Expected: Dialog prompt to set yourself as online.

Updated 26/04/2017 18:26

[Help Wanted] [PLT-5562] Profile picture of other users doesn't update until logout/login

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro:

1) User A uploads new profile picture 2) User B clicks on User A’s username in center channel

Observed:

User A’s profile picture hasn’t changed, even after a refresh. Login/logout is required, although in at least one case, a full clearing of cache was required until the profile picture was visible to other users.

Expected:

User A’s profile picture updates after User B starts a new session such as after refresh. The behaviour should match when User A updates their username or full name (which User B sees reflected after refresh).

Note: When investigating a fix, make sure it’s using the user update timestamp properly. There might be a bug where we’re using the old timestamp for profile pictures, causing it not to update for other users.

Updated 26/04/2017 00:16

[Help Wanted] [PLT-4440] Investigate updating emoji list to support Unicode 9.0 Emoji

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Community report: https://github.com/mattermost/platform/issues/4281

We are missing emoji from the new Unicode 9.0 emoji list: http://emojipedia.org/unicode-9.0/

These changes should be made in the emoji.json of https://github.com/hmhealey/emoji once that’s made public. Then that script can be used to generate a new emoji.jsx file.

You can talk to @hmhealey on GitHub (@harrison on pre-release) for help generating emoji.jsx.

Updated 24/04/2017 16:42

Drop support for Ruby 2.0

SciRuby/daru

I believe we can allow ourselves to it now :)

This not only means specifying 2.1 as a minimum version in the Gemfile, but also switching from option hashes to proper keyword arguments everywhere, which will greatly enchance documentability and discoverability of features.

On this change, version should be bumped at least to 0.2, I believe.

PS: As a side note, I believe 0.x becames to be a bit odd for library of this size. Maybe we need something like “Roadmap to 1.0” somewhere?..

Updated 29/04/2017 15:55 3 Comments

[Help Wanted] [PLT-4843] Add CLI tools for archiving channels

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

We have one for delete channels, we need to add one for archive (delete the channel from UI but leave it in the database).

The command name should be platform channel archive. Channels can be specified by {team}:{channel} using the team and channel names or IDs.

Format: platform channel archive {channels}

Example: sudo ./platform channel archive myteam:mychannel

See related doc for deleting a channel from the CLI: https://docs.mattermost.com/administration/command-line-tools.html#platform-channel-delete See a PR that added a CLI command for searching for users: https://github.com/mattermost/platform/pull/5918

Updated 22/04/2017 19:20

[Help Wanted] [PLT-4922] Change Channel Picker and At Mention autocomplete to prioritize entries where the username/display_name starts with the search string

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

For the at mention autocomplete, it should sort users based on their username, but any user with their username starting with the search string should go first. For the channel switcher, it should sort the same way, but it should be based off of the channel’s display name for non-DM channels and the other user’s username for DM channels.

To give some context, if you search for “t” in the channel switcher right now, it’ll show like: - Analytics (analytics) - Dave Thomas (dthomas) - Town Square (town-square)

But the emoji autocomplete prioritizes entries that start with the search string so searching for “t” gives: - :tree: - :hat: - :out:

Updated 22/04/2017 19:19

[Help Wanted] [PLT-3856] Help break HTML blocks to individual strings for translations

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Break HTML blocks into individual strings for easier translations.

Strings like this: http://translate.mattermost.com/nl/mattermost/translate/#filter=untranslated&unit=237152 should be decomposed to smaller strings. Mixing HTML with the translation is not a good practice.

Updated 20/04/2017 18:01

[Help Wanted] [PLT-5082] Add " v New messages below" indicator to the right-hand-side

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add new messages indicator when scrolled up in the right-hand-side and new messages are posted on the thread.

Ticket for adding this functionality in the center channel: https://github.com/mattermost/platform/issues/4250 PR that added this functionality in the center channel: https://github.com/mattermost/platform/pull/4299

image

Updated 16/04/2017 21:25

[Help Wanted] Add unit tests to APIv4 for creating users with hashes and invite ids

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

In api4/user_test.go need to add tests for creating users with hashes and with invite ids. See the api/user_test.go for examples of how it was done in v3.

Might need to add more model/client4.go functions as well.

If you have questions or need help, ask in the APIv4 channel on the community Mattermost instance: https://pre-release.mattermost.com/core/channels/apiv4

Updated 12/04/2017 06:49 1 Comments

[Help Wanted] Confirm before sending (at)all, (at)channel message

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Opening ticket based on volunteer contributor. https://mattermost.uservoice.com/forums/306457-general/suggestions/18607111-confirm-with-ping-warning-before-sending-all-eve

Propose when sending a message containing (at) all or (at) channel create a pop-up dialog with confirmation:

TITLE: Confirm sending notifications to entire channel TEXT: By using @all or @channel you are about to send notifications to XXX people. Are you sure you want to do this?

BUTTONS

Cancel // Confirm

NOTE

You may use the same pop-up dialog, which appears when attempting to delete a message

image

Updated 26/04/2017 21:45 3 Comments

[Help Wanted] [PLT-2780] Re-add login redirect

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Prior to 3.0, if you went to a URL such as example.mm/team/channels/public-channel when you weren’t logged in, you would be sent to the login screen, but once you logged in, you would be directed back to example.mm/team/channels/public-channel. We want to re-add this feature.

When this gets re-added, make sure to test to make sure that you can only be redirected to a web page and not a javascript link. Previously, the login link would be something like example.mm/login?redirect=LINK which would allow a link such as example.mm/login?redirect=javascript:alert(‘hax’) to run arbitrary javascript

Updated 11/04/2017 16:32

[Help Wanted] [PLT-6096] In desktop web app, remove unnecessary steps for copying permalink

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

1) Click […] next to a message 2) Choose “Permalink”

Observed: A separate dialog appears where you can click the “Copy Link” button to copy the permalink.

Proposed change:

1) Change “Permalink” menu option in […] to “Copy Link”

2) Once you click “Copy Link”, the permalink is copied to the clipboard. The […] remains open but the “Copy Link” term changes to “(/) Copied”

image

NOTE: If the browser doesn’t allow you to directly copy to the clipboard (e.g. mobile browser), then show the “Copy Link” popup as before

image

Updated 27/04/2017 14:14 4 Comments

[Help Wanted] [PLT-3711] Add websocket event for creating a custom emoji

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

When one user creates a custom emoji, other users don’t see it until they refresh the page. We can use websockets to get the new emoji without the user needing to refresh.

This new websocket event will need to contain the emoji json (but not the image) as part of the payload so that the client doesn’t immediately contact the server for any information

Updated 12/04/2017 12:03 2 Comments

[Help Wanted] [PLT-4207] OAuth2.0: Incorrect Client ID during authentication allows user to go "Back to Mattermost" in the authentication window (Proposed Help Wanted)

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

If Auth2.0 Authentication fails because of an incorrect Client ID (see screenshots from Zapier), then the error message given provides an option for “Back to Mattermost” that opens Mattermost to the team selection page.

Expected: No “Back to Mattermost” button, page should just display a helpful error message.

image

image

Note: The page accepts query parameters that should allow you to submit this change

Updated 11/04/2017 16:29

[Help Wanted] Adding a member doesn't update member count until refresh

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.a


Details (Jira ticket)

Repro (also reproduces with other invite methods):

1) Go to Main Menu > Add Members to Team 2) Choose members, then hit “Go”

Observed: User joins the team, but channel member count for Town Square or Off-Topic don’t update for existing users until refresh Expected: Channel member count updates

Updated 04/04/2017 18:34

[Help Wanted] Last viewed team isn't saved after logout

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details (Jira ticket)

Repro steps: 1) Join multiple teams with the current user 2) Switch to one that isn’t the first team in their sidebar 3) Log out 4) Log back in

Observed: You’re logged in to the first team in their sidebar Expected: You’re logged back into the last team you viewed

Updated 06/04/2017 09:05

[Help Wanted] Swipe up to close in-app notifications

mattermost/mattermost-mobile

If you’re interested please comment here and come join our “Native Mobile Apps” channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Developer’s Guide, specifically for machine setup.


Notes: Jira Ticket

Observed: Currently it’s not possible to dismiss in-app notifications

Proposed Change: Add the ability to swipe up to dismiss the notification.

<img width=“320” alt=“screenshot 2017-03-29 16 06 09” src=“https://cloud.githubusercontent.com/assets/9354841/24480509/a2a9b396-1499-11e7-927c-5fbeaa9b038b.png”>

Updated 29/03/2017 23:06

[Help Wanted] Clicking on @mention of a user in a post should show the profile popover.

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details (Jira ticket)

Clicking on @mention of a user in a post should show the profile popover.

Repro: 1) Post a message hey @username 2) Click on the mention, @username

Observed: Currently clicking on an @mention searches for the user’s name.

Proposed change: Clicking on an @mention opens the “profile popover”. (This should be the same popover that shows up when clicking on a person’s name beside their profile picture in the center channel - see screenshot for an example).

image

Updated 09/04/2017 21:09 3 Comments

[Help Wanted] Swipe down to close keyboard

mattermost/mattermost-mobile

If you’re interested please comment here and come join our “Native Mobile Apps” channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Developer’s Guide, specifically for machine setup.


Notes: Jira Ticket

Repro of issue: 1. Click into the texbox to open the keyboard 2. Swipe down to scroll the channel, extending over top of the text input box

Observed: Keyboard stays open

Expected: Keyboard should close if the swipe action goes overtop the text input box. Do not close the keyboard if the swipe action is only on the channel, and not on the keyboard.

[See iMessage, FB messenger, most other apps for example]

Updated 12/04/2017 21:58 2 Comments

[Help Wanted] Add ability to link to channels based on unchanging channel_id instead of channel_url (which users can change)

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add ability to link to channels based on unchanging channel_id instead of channel_url (which users can change)

Proposed format: https://my-mattermost-server.com/channels/channel_id, which redirects to https://my-mattermost-server.com/team/team_url/channels/channel_url

See this discussion for original request: https://pre-release.mattermost.com/core/pl/x3unq3s15pd6zenc68qfc64pze

Updated 30/03/2017 14:04

Define JSON importer/exporter

SciRuby/daru

I think this is a good time to work on this. There is already a to_h method for dataframe and vectors but no such File.write method for json. API calls mostly follow json formats so the importer should be able to read json data from api calls. We can start off by a simple write_to_json method and from_json method in Daru::IO module. Since Ruby comes with json we don’t need to add any extra dependency. We just need to require json .

Updated 27/03/2017 21:21 1 Comments

[Help Wanted] Don't spike CPU usage when holding ESC key in webapp

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro steps: 1. Open task manager (windows) or activity monitor (mac) and sort by CPU usage 2. In Mattermost, select the post input box 3. Hold ESC key

Observed: CPU usage for browser rises significantly Expected: CPU usage is reasonable

Reported here: https://pre-release.mattermost.com/core/pl/3rj443164ff1frqty6de44fb5a

Updated 22/03/2017 13:07

[Help Wanted] Change direct message list to be infinite scroll

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Change direct message list to be infinite scroll.

Threshold will be 30 per list and load more when the scroll passes the threshold.

See initial commits in this PR to help you get started.

Updated 16/03/2017 20:46

[Help Wanted] Make /collapse and /expand only apply to previous posts in the channel

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Currently /collapse and /expand commands simply control the “Account Settings > Display > Default appearance of image link previews” setting.

Proposed change: Have the command only apply to previous posts in the current channel.

Example: Suppose - “Account Settings > Display > Default appearance of image link previews” is set to “Expanded”, and - user types /collapse in channel ABC.

Then - image links in existing posts in channel ABC collapse - new posts containing image links in channel ABC are expanded by default - image links in other channels are expanded by default

Updated 10/03/2017 22:24

[Help Wanted] A single collapsed preview re-opens after refresh

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

  1. Insert a gif link into a direct chat that shows up with the preview.
  2. Collapse preview using the icon beside the image.
  3. Refresh

Observed: GIF uncollapses Expected: GIF stays collapsed

Updated 20/03/2017 13:28 4 Comments

Disallow adding/editing of retrospectives for users no longer in the group

ElixirCLE/pairmotron

Currently, if a user is no longer in a group, they can still edit retrospectives that they created while they were in that group. They can also add retrospectives for pairs they were in while they were in the group. This allows the user to view the group’s projects (which they should not have access to if they are no longer in that group).

Users that are no longer in a group associated with a pair they were in should not be allowed to access the :new, :create, :edit, or :update routes for such a retrospective. They should be allowed to view the retrospective if they are no longer in the group, so they should be allowed to access the :show route for such a restrospective.

Updated 06/03/2017 16:44

Enhance specs style

SciRuby/daru

Our specs had grown “organically”, and many of them use outdated style of testing things (all bootstrap & several checks is made inside single example, tons of hard-to-read large objects created on the fly, instance variables are used instead of let and so on).

What should be done in this ticket is: * Refactoring of specs in accordance with BetterSpecs guidelines; * Making specs more clean/DRY (only several different dataframes are created as a test subjects, covering most of the situations) * Probably, splitting large specs files into smaller ones (e.g. for dataframe – basic functionality, math, output, import/export…) * Consider turning on Rubocop for specs files (with probably some cops turned off or tuned in spec/.rubocop.yml) * Consider introducing rubocop-rspec for rspec-specific checks (initially turned off, then turned on file-by-file & cop-by-cop)

As the full solution for the ticket will touch all spec/**/*.rb files, it is advised to make several PRs (one PR per one spec file, or one PR per one problem solution).

You can rely on my (@zverok) advices and reviews while working on this ticket.

Updated 17/03/2017 20:19 4 Comments

[Help Wanted] [PLT-1015] Make all Mattermost system emails Multi-Part, with both a HTML and Plain Text version.

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Currently all emails sent by the Mattermost server are in HTML only. This ticket is to change them to be multi-part, including both an HTML and Plain Text version of the email.

Steps involved: 1. Identify a suitable golang library for constructing multi-part emails (please discuss the chosen library with us before starting implementation to ensure there are no issues with the license). 2. Migrate the existing code sending emails to use that library. 3. Implement a plain-text version of all the emails, and combine that in multi-part messages with the existing HTML messages.

Updated 08/03/2017 16:28 15 Comments

[Help Wanted] [PLT-5268] Always show link previews on comment threads in right-hand sidebar

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Right now if you are viewing a thread on the right-hand sidebar, the link previews are only shown for the parent post, not for comments.

Proposed change: Always show link previews on comment threads in right-hand sidebar.

NOTE: Search results (including flagged posts and recent mentions) should not show the link preview.

Updated 18/02/2017 16:30

[Help Wanted] [PLT-5360] Clicking on email verification does not automatically fill in your email on mobile browser

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

This is a follow-up to https://github.com/mattermost/platform/pull/5140, whose PR can be found here and added this functionality for the desktop browser.

Repro (iOS, Safari browser): 1. Sign up to a site, and receive a verification email 2. On your phone, click the link in the email verification email 3. Click “Continue to browser” on the ios/android landing page.

Observed: Email verification is successful, but your email address is not filled in on the log in page. This is because you’re redirected to the switch_team page instead (and in return to the login page without the email validation URL)

Expected: To improve the user experience, your email address in already filled in and cursor is in the password field.

One solution is that if you’re redirected to Mattermost via an email verification, bypass the ios/android landing page.

Updated 07/03/2017 10:28 1 Comments

[Help Wanted] Failed slash command should show input

mattermost/platform

Summary

On Slack, when a slash commands fails for any reason, the input (slash command and its parameters) are shown back to the user. Would love to have this in Mattermost too as now a timeout, or IO error might mean a lot of retyping.

Steps to reproduce

Create a slash commands which times out. And trigger it.

Expected behavior

Feedback it failed, and slash command in the typing section.

Observed behavior

Feedback, but lost my input.

NOTE: Slash command refers to Mattermost slash commands: https://docs.mattermost.com/developer/slash-commands.html

Updated 30/03/2017 18:34 2 Comments

Make activity group-specific

ElixirCLE/pairmotron

Currently, users can be active or inactive globally for the purposes of pairing. Add the ability to toggle user activity for specific groups individually.

Users will want to be able to be active for certain group pairings, but not others.

This card should leave the is_active field on Users present, as using this group-specific activity is outside the scope of this card, as it will be a part of redesigning pairing.

Updated 20/03/2017 02:48

[Help Wanted] Improve join/leave messages

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details: (Jira Ticket)

Part 1: Join/leave messages should:

  1. Never trigger a desktop notification unless you are mentioned by someone else (eg @lindsay added @asaad to the channel)
  2. [Already implemented] Never trigger an “Unread” bolded channel name unless you are mentioned by someone else (eg @lindsay added @asaad to the channel)

Part 2: Update the grammar for the messages:

  1. Switch the joined a channel message to say: @lindsay joined the channel.
  2. Switch the left a channel message to say: @lindsay left the channel.
  3. Switch the added to a channel message to say: @lindsay added @asaad to the channel.

Part 3: Combine Consecutive join/leave messages:

System messages related to joining, leaving, and adding/removing people from channels are combined into one post if they happen one after another, without any non-action messages in between. The messages are simply appended to the first message, and appear in the order that they occur.

Example:

@lindsay joined the channel. @lindsay added @asaad to the channel. @lindsay left the channel. @jason joined the channel.

Updated 20/03/2017 17:58 3 Comments

[Help Wanted] Create screens to edit OAuth 2.0 Applications

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details: (Jira Ticket)

Tip: Before getting started, take a look at how edit screens for slash commands were created by @bolecki.

It’s also a good idea to test the edit screens so you can see how they work for slash commands.

1 - Add an “Edit” button that offers an Edit screen (similar to the create screen) that saves back changes.

image Above: Add “Edit” button left of the “Delete” option

image Above: Edit screen that opens after clicking “Edit” in the previous screenshot for OAuth 2.0 apps

2 - If it’s a change that will break existing integrations (a change to one of the callback URLs), add a confirmation dialog notifying the user of the consequences of the update.

The dialog has two buttons, where “Cancel” brings the user back to the edit screen, and “Update” updates the OAuth 2 app.

Text should read Your changes may break the existing OAuth 2.0 application. Are you sure you would like to update it?

Below: Sample confirmation dialog for slash commads image

Updated 21/04/2017 08:44 1 Comments

[Help Wanted] Add [...] menu to search results list

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details: (Jira Ticket)

Currently there’s no […] menu in the search results list, so you need to open the post to access it.

Proposed Change: Have the […] menu show in the search results lists. Screenshot of the UI attached, and where the […] menu would appear.

NOTE: - On desktop, the […] menu should only show when hovering over the post, similar to the reply arrow - On mobile app and mobile browser, the […] menu should always show (similar to the reply arrow) as there is no hover effect on mobile

image

Updated 11/04/2017 03:40 1 Comments

Daru::Index#[] should only be used for index value and Index#at for position.

SciRuby/daru

Daru::Index#[] behaves as follows:

index = Daru::Index.new([100, 200, 300])

# access with Range:
index[0..1] # => #<Daru::Index(2): {100, 200}>

# access with Integer:
index[1] # => 1

# What I assumed:
index.at(1) # => 200

From the behavior of index[0..1], I assumed that index[] takes position as argument and returns value of index.

In other words, Index#[] sometimes takes position as argument and at other times takes value.

Is there any special reason for this confusing (at least for me) behavior ?

Updated 27/03/2017 17:13 25 Comments

[Help Wanted] "No Channels Found" should appear without pressing Enter in Channel Switcher (CTRL/CMD+K)

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

For technical advice or questions, please join our “Developers” community channel.


Difficulty: Introductory

Details: Jira ticket

Repro Steps: 1. Open Channel Switcher (CTRL/CMD+K) 2. Type something that doesn’t exist as a channel. 3. Press Enter.

Observed: Step 2: No feedback after searching for something that doesn’t exist.

image

Step 3: Error message No matches found. in red colour.

image

Proposed Changes: Step 2:

1) Feedback should appear if no channels are found (ie search results are blank) immediately if at least one character is typed.

2) Moreover, the error message should not be red. It should use the same colour when searching for members in “Manage/View Members” list with no results (see screenshot below)

Note: The “Manage/View Members” list can be found from the three-dotted Mattermost Main Menu next to your username and profile picture in the top left corner.

image

Step 3: The message should persist if ENTER is pressed, i.e. no change from step 2.

Updated 27/04/2017 21:21 2 Comments

[Help Wanted] Converting Public Channels to Private Groups

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.


Difficulty: Intermediate

From the channel context menu, a “Convert to Private” option for public channels should be offered as an option to convert public channels to private groups. This should be visible to everyone. Additionally, the option should not be available for any team’s default town square channel.

image

On click, a full-screen modal should appear with the layout and text shown below. Once confirmed, a system message should be be sent: @channel: [USERNAME] has converted this channel to a private group.

image

Convert [CHANNEL NAME] to a private group?

[CHANNEL NAME] is currently a public channel.

Converting it to a private group means:

  • Only people currently in the channel will be able to see and message in the channel
  • All previous uploaded files (unless accessed via the Public Link) and past conversations in the public channel will become inaccessible to users not in the channel
  • Members will have to be invited to join this channel in the future

Are you sure you want to convert [CHANNEL NAME] to a private group?

[No, cancel] [Yes, convert to private group]

Updated 04/04/2017 19:26 14 Comments

Fork me on GitHub