Contribute to Open Source. Search issue labels to find the right project for you!

[Help Wanted] [PLT-6871] Change at-mention autocomplete to prioritize entries where the username starts with the search string

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Change at-mention autocomplete to prioritize entries where the username starts with the search string

For the at mention autocomplete, it should sort users based on their username, but any user with their username starting with the search string should go first.

To give some context, if you search for “te” in the auto-complete right now on pre-release, you get the following results.

image

What you expect is this (those starting with “te” appear first, followed by other users in alphabetical order)

image

NOTE: You can compare to how the sorting is done for channel switcher shortcut (CTRL+K) https://github.com/mattermost/platform/pull/6486

Updated 20/06/2017 21:04

[Help Wanted] [PLT-6847] If a message starts with a / but is not a slash command, put the text back in the input box when it fails to send

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro: 1. Send a message “/path/to/directory and a nice message”

Observed: You get an error saying it’s not a slash command, and the message disappears. (Very bad experience for the user since they lose everything they just typed).

Proposed change:

  1. Change the error message to say: Command with a trigger of ‘path/to/directory’ not found. To send a message beginning with “/”, try adding an empty space at the beginning of the message."

  2. Put the message back in the text box after it fails to send, so the user doesn’t lose everything they’ve typed

Report: https://github.com/mattermost/platform/issues/6646

Updated 20/06/2017 14:42 4 Comments

[Help Wanted] [PLT-6842] User's role does not update in their client until the page is refreshed

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro: 1. User A makes User B team admin (or switched to any other role, eg demote from Team Admin to Member) 2. Observe User B’s Main menu

Observed: User B’s menu options do not update to show Team Settings until after refresh.

If it’s the reverse and User B is switched from Team Admin to member, they still see the Team Settings until refresh but get a permissions error if they try to change anything.

Expected: User B should see updated menu options / permissions when the role gets changed (pushes a websocket event)

Updated 14/06/2017 16:47

Add cli argument to create a new component

andela-iamao/react-raise

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

currently I can only create a new react application

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

N/A

What is the expected behavior?

I should be able to create a new component by typing something like: $ raise component -C Dashboard - where -C is connected. i.e I intend to make Dashboard a container component. It then generates Dashboard and connects it to the redux store - Dashboard is the name of the component - if -C is not provided then it is a presentational component by default

Which versions of react-raise, and which browser / OS are affected by this issue? Did this work in previous versions of react-raise?

N/A

NB: You can drop a comment below for more clarification
Updated 14/06/2017 06:39

Configure express server if the option was chosen

andela-iamao/react-raise

Do you want to request a feature or report a bug?

Feature & Bug

What is the current behavior?

Currently it just installs express and its dependencies when a user selects to use with express

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

N/A

What is the expected behavior?

It should set up a basic express server when the use chooses so. - It should use the port 7000 on local - It should serve static files at ‘/dist/’ - It should be integrated with webpack-dev-server

Which versions of react-raise, and which browser / OS are affected by this issue? Did this work in previous versions of react-raise?

N/A

NB: You can drop a comment below for more clarification
Updated 14/06/2017 06:27

from_csv should support loading specified columns as date columns

SciRuby/daru

CSVs frequently contain multiple date columns. These are not necessarily indexes. It would be good if from_csv function provided an easy way to load column(s) as dates. As it stands now, the CSV needs to be loaded and the columns converted in to dates.

For reference, Pandas read_csv function supports a parse_dates argument for a similar purpose.

At the moment I have a simple wrapper csv_as_dataframe(path, date_columns=[]) to from_csv that reads the CSV and convert the columns using the below naive implementation: ruby date_columns.each do |col| df[col] = df[col].map do |v| if v Date.parse(v) else nil end end end It can probably be better optimized to handler multiple columns at once so it’s not N2. Not sure if something like this is already supported in Daru as I am fairly new to it.

Updated 13/06/2017 15:25 1 Comments

Parse the cli arguments

andela-iamao/react-raise

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

Currently the project does not handle any cli argument

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).

N/A

What is the expected behavior?

Command line arguments should be parsed. For example, if I type: $ raise new app Then it should know I wish to create a new react application List of cli args: new - create new react app component - create new component action - create new action reducer - create new reducer test:e2e - create new e2e test spec test:component - create new component test spec test:action - create new action test spec test:reducer - create new reducer test spec

Which versions of react-raise, and which browser / OS are affected by this issue? Did this work in previous versions of react-raise?

N/A

NB: You can drop a comment below for more clarification
Updated 12/06/2017 03:00

[Help Wanted] [PLT-3893] Clean up our common logger and move to structured logging

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Updated 14/06/2017 00:38 13 Comments

[Help Wanted] [PLT-6739] Convert theme color pickers to use react-color

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

The theme color pickers in “components/user_settings/custom_theme_chooser.jsx” use a jQuery plugin. We should switch to using the react-color library, similar to how it’s done in “webapp/components/admin_console/color_setting.jsx”

Updated 06/06/2017 18:12

Convenient way of setting new/existing column: df[:colx] = 1.0

SciRuby/daru

It may be worthwhile having df[:c] = 1.0 as a convenient method of setting a new column and existing columns. Right now it errors out.

Daru: 0.1.5 Ruby: 2.4.0

[4] pry(main)> df = Daru::DataFrame.new({a: [1, 2, 3], b: [10, 20, 30]})
=> #<Daru::DataFrame(3x2)>
       a   b
   0   1  10
   1   2  20
   2   3  30
[5] pry(main)> df[:c] = 1.0
NoMethodError: undefined method `size' for 1.0:Float
from /home/user/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/daru-0.1.5/lib/daru/dataframe.rb:2188:in `prepare_vector_for_insert'
[6] pry(main)> df[:c] = [1.0] * df.nrows
=> [1.0, 1.0, 1.0]
[7] pry(main)> df
=> #<Daru::DataFrame(3x3)>
       a   b   c
   0   1  10 1.0
   1   2  20 1.0
   2   3  30 1.0

While we can do df[:c] = [1.0] * df.nrows it’s probably more intuitive and clearer to do df[:c] = 1.0, especially for new users from other libs like pandas.

Behavior for pandas.

In [1]: import pandas as pd

In [2]: df = pd.DataFrame({'a': [1, 2, 3], 'b' : [10, 20, 30]})

In [3]: df
Out[3]: 
   a   b
0  1  10
1  2  20
2  3  30

In [4]: df['c'] = 1.0

In [5]: df
Out[5]: 
   a   b    c
0  1  10  1.0
1  2  20  1.0
2  3  30  1.0

In [6]: 
Updated 05/06/2017 16:06 1 Comments

[Help Wanted] [PLT-6659] File preview images uploaded from mobile may be rotated

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

This may require an additional library to read the EXIF flags from the image file and manually rotate the image, but there may be a CSS property or something we can use to do it without that

Repro steps: 1) Take a photo on a mobile device 2) Log into Mattermost using the old mobile app or browser 3) Upload the photo as a file attachment or profile picture

Observed: Before sending the post/saving the profile picture, the image appears rotated. After sending/saving, it will be upright Expected: The image is upright in the preview

Updated 26/06/2017 12:56 6 Comments

[Help Wanted] [PLT-3470] Update formatting of user lists to include both full name and nickname

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Update the user list formatting in the Direct Messages “More” Menu, Channel Add Members and Channel Manage Members, Team Manage Members and System Console users pages to include both nickname and full name.

The format should be as follows (see screenshot): @username - full_name (nickname) email address

If full name isn’t filled out but nickname is, the format should be: @username - nickname email address

image

Updated 11/06/2017 03:58 1 Comments

[Help Wanted] [PLT-1649] Support Slack-compatible delayed slash commands

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Support Slack-compatible delayed slash commands

Slack supports a response_url field for slash commands, which lets you post additional messages to a channel for a period of time after a command is triggered. Response URLs can be used to send five additional messages within a thirty minute window from the original command invocation

Any request that are made to the response URL should support either a plain text or JSON-encoded body.

You can find more information about the delayed responses below - https://api.slack.com/slash-commands - https://api.slack.com/tutorials/slash-commands-style-guide

For an example use case, see https://claudiajs.com/tutorials/slack-delayed-responses.html

Updated 22/06/2017 23:05 2 Comments

[Help Wanted] [PLT-3038] Update notification for webhooks sending attachments

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro: 1. Set up an incoming webhook 2. Send the following as a payload: { "attachments": [ { "title": "Title", "pretext": "Pretext _supports_ mrkdwn", "text": "Testing *right now!*", "mrkdwn_in": ["text", "pretext"] } ] }

Observed: The notification triggered says “webhook did something new”

Expected: Notification should follow the normal format (for example, “webhook wrote:”), and use the following priority for the body of the notification (for example, if fallback text is present use that as the body, but if not, use pre-text): 1) fallback text 2) pre-text 3) text 4) “posted an image” if there is an image URL 5) “did something new”

Updated 19/05/2017 18:48

[Help Wanted] Migrate add_outgoing_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/add_outgoing_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 02/06/2017 14:08 1 Comments

[Help Wanted] Migrate installed_commands.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_commands.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 21/05/2017 22:50 2 Comments

[Help Wanted] Migrate installed_oauth_apps.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_oauth_apps.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:19

[Help Wanted] Migrate installed_outgoing_webhooks.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_outgoing_webhooks.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:18

[Help Wanted] Migrate installed_incoming_webhooks.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_incoming_webhooks.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:18

[Help Wanted] Migrate installed_command.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_command.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:16

[Help Wanted] Migrate installed_oauth_app.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_oauth_app.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:16

[Help Wanted] Migrate installed_outgoing_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_outgoing_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:15

[Help Wanted] Migrate installed_incoming_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/installed_incoming_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:15

[Help Wanted] Migrate edit_command.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/edit_command.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:14

[Help Wanted] Migrate edit_outgoing_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/edit_outgoing_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 19:14

[Help Wanted] Migrate edit_incoming_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/edit_incoming_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 18:41

[Help Wanted] Migrate add_command.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/add_command.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 18:40

[Help Wanted] Migrate add_oauth_app.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/add_oauth_app.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 18/05/2017 18:39

[Help Wanted] Migrate add_incoming_webhook.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/integrations/components/add_outgoing_webhook.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 30/05/2017 19:38 1 Comments

[Help Wanted] Migrate channel_info_modal.jsx to be pure and use Redux

mattermost/platform

If you’re interested please comment here and come join our “Redux” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Redux contribution process to help get you started.


Difficulty: Intermediate

Details: Mattermost is moving their webapp to Redux over the next months and we’re looking for contributors to help with that effort. This Help Wanted issue is to move components/channel_info_modal.jsx to Redux.

Before submitting the pull request, make sure it has proper component testing as described here.

For a sample pull request for migrating a component to use Redux, see https://github.com/mattermost/platform/pull/6416

Updated 29/05/2017 11:25 2 Comments

[Help Wanted] [PLT-6455] GIF images (custom emoji) and Profile Pics do not retain background transparency

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Original report: https://github.com/mattermost/platform/issues/6270

SUMMARY GIF images (custom emoji) and Profile Pics do not retain background transparency.

STEPS TO REPRODUCE Version: pre-release.mattermost.com

  1. Custom Emoji > Add Custom Emoji
  2. Save the image to your computer https://i.imgur.com/pmIfMVG.gif img
  3. On the modal that was open from step 1 use the saved GIF from step 2
  4. On the text preview in that page before clicking SAVE, it properly shows with transparency
  5. After its saved and upload the background goes black, on the emoji
  6. Using this emoji on any where will have its background black instead of transparent

EXPECTED BEHAVIOUR The GIF will retain its transparency, like the original above.

OBSERVED BEHAVIOUR The uploaded GIF had its background changed from transparent to black. It could be a global issue for any uploaded image that goes through Plan9 palette?

SIDE NOTE Created it under the name :monkey-want: if want to test it on https://pre-release.mattermost.com.

Updated 10/05/2017 14:48 1 Comments

[Help Wanted] [PLT-6229] Post should show a plus sign for adding to existing emoji reactions

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

When a post already has reactions, add an extra box next to the list of reactions, containing a + sign. When clicked upon, this box should open up the emoji picker.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

NOTE: While the emoji picker is behind the feature flag, the plus sign should ONLY appear if the user has enabled the picker from Account Settings > Advanced > Preview pre-release features.

Updated 01/05/2017 13:36

[Help Wanted] [PLT-6165] Load the emoji picker once and reuse the modal, instead of destroying it each time

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Load the emoji picker once and reuse the modal, instead of destroying it each time.

This should make the picker appear faster, instead of having a ~0.5 second delay.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 01/05/2017 13:40

[Help Wanted] [PLT-6039] When searching in emoji picker, remove categorization

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

When searching in emoji picker, remove categorization and instead simply list all the emoji that match the search result, nine emoji per row.

Notes: 1) The order should follow the order in emoji picker, i.e. “People” emoji first, followed by “Nature”, “Food”, etc. 2) Recently used emoji shouldn’t be included in the list, to avoid having the same emoji twice. 3) At the header of the emoji picker, the “Recently Used” section should be highlighted when doing the search.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 01/05/2017 13:40

[Help Wanted] [PLT-6074] Have deleteReaction API send the correct value for post.HasReactions

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

The changes made in https://github.com/mattermost/platform/pull/5499 make it so that the websocket event fired after removing a reaction always have the client save the post.HasReactions field to true even when the last reaction has just been removed.

Since that fix was made to solve a read replica issue (caused by saving the updated post on master and then getting the post again from a slave), we should change it so that the SqlReactionStore.Delete method returns the updated post instead of the the reaction that was just deleted (since the caller should already have that). The SqlReactionStore.Save method should probably be updated to return the post as well to keep the behaviour parallel between the two.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 01/05/2017 13:41

[Help Wanted] [PLT-5576] Add emoji picker for edit message dialog

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker.

Currently there is no emoji picker in the edit dialog - this ticket adds an emoji picker for that dialog.

image

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 01/05/2017 14:09 2 Comments

[Help Wanted] [PLT-5894] Show all emoji aliases on the picker

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Repro: 1) Enable emoji picker from Account Settings > Advanced > Preview pre-release features. 2) Click emoji icon to open the emoji picker. 3) Find the thumbs up (or +1) emoji from the “People” category.

Observed: Only one of the emoji aliases for “:+1:” is shown when hovering an emoji on the picker

image

Expected: All emoji aliases (“:+1:”, “:thumbsup”) are shown when hovering an emoji on the picker.

See https://github.com/mattermost/platform/pull/5157 which added the emoji picker. See https://github.com/mattermost/platform/pull/5904 which added the emoji picker for reactions.

Updated 01/05/2017 13:41

[Help Wanted] [PLT-4440] Investigate updating emoji list to support Unicode 9.0 Emoji

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Community report: https://github.com/mattermost/platform/issues/4281

We are missing emoji from the new Unicode 9.0 emoji list: http://emojipedia.org/unicode-9.0/

These changes should be made in the emoji.json of https://github.com/hmhealey/emoji once that’s made public. Then that script can be used to generate a new emoji.jsx file.

You can talk to @hmhealey on GitHub (@harrison on pre-release) for help generating emoji.jsx.

Updated 24/04/2017 16:42

Drop support for Ruby 2.0

SciRuby/daru

I believe we can allow ourselves to it now :)

This not only means specifying 2.1 as a minimum version in the Gemfile, but also switching from option hashes to proper keyword arguments everywhere, which will greatly enchance documentability and discoverability of features.

On this change, version should be bumped at least to 0.2, I believe.

PS: As a side note, I believe 0.x becames to be a bit odd for library of this size. Maybe we need something like “Roadmap to 1.0” somewhere?..

Updated 29/04/2017 15:55 3 Comments

[Help Wanted] [PLT-3856] Help break HTML blocks to individual strings for translations

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Break HTML blocks into individual strings for easier translations.

Strings like this: http://translate.mattermost.com/nl/mattermost/translate/#filter=untranslated&unit=237152 should be decomposed to smaller strings. Mixing HTML with the translation is not a good practice.

Updated 20/04/2017 18:01

[Help Wanted] [PLT-5082] Add " v New messages below" indicator to the right-hand-side

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add new messages indicator when scrolled up in the right-hand-side and new messages are posted on the thread.

Ticket for adding this functionality in the center channel: https://github.com/mattermost/platform/issues/4250 PR that added this functionality in the center channel: https://github.com/mattermost/platform/pull/4299

image

Updated 16/04/2017 21:25

[Help Wanted] [PLT-6096] In desktop web app, remove unnecessary steps for copying permalink

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

1) Click […] next to a message 2) Choose “Permalink”

Observed: A separate dialog appears where you can click the “Copy Link” button to copy the permalink.

Proposed change:

1) Change “Permalink” menu option in […] to “Copy Link”

2) Once you click “Copy Link”, the permalink is copied to the clipboard. The […] remains open but the “Copy Link” term changes to “(/) Copied”

image

NOTE: If the browser doesn’t allow you to directly copy to the clipboard (e.g. mobile browser), then show the “Copy Link” popup as before

image

Updated 02/05/2017 07:32 6 Comments

[Help Wanted] [PLT-3711] Add websocket event for creating a custom emoji

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

When one user creates a custom emoji, other users don’t see it until they refresh the page. We can use websockets to get the new emoji without the user needing to refresh.

This new websocket event will need to contain the emoji json (but not the image) as part of the payload so that the client doesn’t immediately contact the server for any information

Updated 12/04/2017 12:03 2 Comments

[Help Wanted] [PLT-4207] OAuth2.0: Incorrect Client ID during authentication allows user to go "Back to Mattermost" in the authentication window

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

If Auth2.0 Authentication fails because of an incorrect Client ID (see screenshots from Zapier), then the error message given provides an option for “Back to Mattermost” that opens Mattermost to the team selection page.

Expected: No “Back to Mattermost” button, page should just display a helpful error message.

image

image

Note: The page accepts query parameters that should allow you to submit this change

Updated 01/05/2017 13:43

[Help Wanted] Adding a member doesn't update member count until refresh

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.a


Details (Jira ticket)

Repro (also reproduces with other invite methods):

1) Go to Main Menu > Add Members to Team 2) Choose members, then hit “Go”

Observed: User joins the team, but channel member count for Town Square or Off-Topic don’t update for existing users until refresh Expected: Channel member count updates

Updated 04/04/2017 18:34

[Help Wanted] Last viewed team isn't saved after logout

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details (Jira ticket)

Repro steps: 1) Join multiple teams with the current user 2) Switch to one that isn’t the first team in their sidebar 3) Log out 4) Log back in

Observed: You’re logged in to the first team in their sidebar Expected: You’re logged back into the last team you viewed

Updated 06/04/2017 09:05

[Help Wanted] Clicking on @mention of a user in a post should show the profile popover.

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details (Jira ticket)

Clicking on @mention of a user in a post should show the profile popover.

Repro: 1) Post a message hey @username 2) Click on the mention, @username

Observed: Currently clicking on an @mention searches for the user’s name.

Proposed change: Clicking on an @mention opens the “profile popover”. (This should be the same popover that shows up when clicking on a person’s name beside their profile picture in the center channel - see screenshot for an example).

image

Updated 01/05/2017 21:14 3 Comments

[Help Wanted] Swipe down to close keyboard

mattermost/mattermost-mobile

If you’re interested please comment here and come join our “Native Mobile Apps” channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

New contributors please see our Developer’s Guide, specifically for machine setup.


Notes: Jira Ticket

Repro of issue: 1. Click into the texbox to open the keyboard 2. Swipe down to scroll the channel, extending over top of the text input box

Observed: Keyboard stays open

Expected: Keyboard should close if the swipe action goes overtop the text input box. Do not close the keyboard if the swipe action is only on the channel, and not on the keyboard.

[See iMessage, FB messenger, most other apps for example]

Updated 26/05/2017 01:11 4 Comments

[Help Wanted] Add ability to link to channels based on unchanging channel_id instead of channel_url (which users can change)

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Add ability to link to channels based on unchanging channel_id instead of channel_url (which users can change)

Proposed format: https://my-mattermost-server.com/channels/channel_id, which redirects to https://my-mattermost-server.com/team/team_url/channels/channel_url

See this discussion for original request: https://pre-release.mattermost.com/core/pl/x3unq3s15pd6zenc68qfc64pze

Updated 30/03/2017 14:04

[Help Wanted] Create screens to edit OAuth 2.0 Applications

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.

New contributors please see our Developer’s Guide, specifically for machine setup and for developer workflow.


Details: (Jira Ticket)

Tip: Before getting started, take a look at how edit screens for slash commands were created by @bolecki.

It’s also a good idea to test the edit screens so you can see how they work for slash commands.

1 - Add an “Edit” button that offers an Edit screen (similar to the create screen) that saves back changes.

image Above: Add “Edit” button left of the “Delete” option

image Above: Edit screen that opens after clicking “Edit” in the previous screenshot for OAuth 2.0 apps

2 - If it’s a change that will break existing integrations (a change to one of the callback URLs), add a confirmation dialog notifying the user of the consequences of the update.

The dialog has two buttons, where “Cancel” brings the user back to the edit screen, and “Update” updates the OAuth 2 app.

Text should read Your changes may break the existing OAuth 2.0 application. Are you sure you would like to update it?

Below: Sample confirmation dialog for slash commads image

Updated 21/04/2017 08:44 1 Comments

[Help Wanted] Converting Public Channels to Private Groups

mattermost/platform

If you’re interested please comment here and come join our “Contributors” community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our “Developers” community channel.


Difficulty: Intermediate

From the channel context menu, a “Convert to Private” option for public channels should be offered as an option to convert public channels to private groups. This should be visible to everyone. Additionally, the option should not be available for any team’s default town square channel.

image

On click, a full-screen modal should appear with the layout and text shown below. Once confirmed, a system message should be be sent: @channel: [USERNAME] has converted this channel to a private group.

image

Convert [CHANNEL NAME] to a private group?

[CHANNEL NAME] is currently a public channel.

Converting it to a private group means:

  • Only people currently in the channel will be able to see and message in the channel
  • All previous uploaded files (unless accessed via the Public Link) and past conversations in the public channel will become inaccessible to users not in the channel
  • Members will have to be invited to join this channel in the future

Are you sure you want to convert [CHANNEL NAME] to a private group?

[No, cancel] [Yes, convert to private group]

Updated 23/06/2017 11:59 17 Comments

[API] Redesign of `DataFrame#group_by`

SciRuby/daru

Planned to do this myself, but, unfortunately, in upcoming weeks I will have much less spare time. So, just writing it here to not forget.

The idea: we don’t need separate Core::GroupBy object. It adds to users confusion, code and tests complexity and makes grouping too rigid and fragile.

The solution: Part 1: make DataFrame#group_by to produce DF with MultiIndex, like this:

df = Daru::DataFrame.new(
  employee: %w[John Jane Mark John Jane Mark],
  month: %w[June June June July July July],
  salary: [1000, 500, 700, 1200, 600, 600]
)
# => #<Daru::DataFrame(6x3)>
#          employee    month   salary
#        0     John     June     1000
#        1     Jane     June      500
#        2     Mark     June      700
#        3     John     July     1200
#        4     Jane     July      600
#        5     Mark     July      600 

df.group_by(:employee)
# => #<Daru::DataFrame(6x2)>
#                month salary
#   John      0   June   1000
#             3   July   1200
#   Jane      1   June    500
#             4   July    600
#   Mark      2   June    700
#             5   July    600 

I think, it is pretty intuitive (in fact, that was what I’ve expected when first met with Daru) – we just have MultiIndex of summary column + source index.

Part 2: Add DataFrame#summarize for multi-indexed DFs, like this (considering DF above):

df.group_by(:employee).summarize(salary: :sum)
# => #<Daru::DataFrame(3x2)>
#         month salary
#   John   June   2200
#   Jane   June   1100
#   Mark   June   1300 

Things to note: - all index parts except first column are dropped (for wide indexes we can have first param of how many columns of index to take) - default operation (for “month” column) is just take a first of each group; - we can provide operation (as for “salary”) column in form of symbol or lambda.

Another example with same DF:

df.group_by(:employee)
  .summarize(
    salary: :sum,
    month: ->(vec) { vec.to_a.join('/') } # argument for lambda is grouped part of vector
  )
# => #<Daru::DataFrame(3x2)>
#               month    salary
#      John June/July      2200
#      Jane June/July      1100
#      Mark June/July      1300 

And another one:

df.group_by(:employee)
  .summarize(
    salary: :sum,
    month: ->(vec) { vec.to_a.join('/') },
    mean_salary: ->(df) { df.salary.mean }, # when column name is not in orig.DF,
    periods: ->(df) { df.size }             # argument is part of entire dataframe
                                            # belonging to the group
  )

# => #<Daru::DataFrame(3x4)>
#                 month     salary mean_salar    periods
#       John  June/July       2200       1100          2
#       Jane  June/July       1100        550          2
#       Mark  June/July       1300        650          2 

WDYT?

Updated 20/06/2017 20:12 9 Comments

Fork me on GitHub